From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423157AbcBQNqz (ORCPT ); Wed, 17 Feb 2016 08:46:55 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:33591 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423037AbcBQNqy (ORCPT ); Wed, 17 Feb 2016 08:46:54 -0500 Subject: Re: [PATCHv4 6/7] eeprom: 93xx46: extend driver to plug into the NVMEM framework To: Andrew Lunn , GregKH References: <1455666097-9115-1-git-send-email-andrew@lunn.ch> <1455666097-9115-7-git-send-email-andrew@lunn.ch> Cc: maxime.ripard@free-electrons.com, wsa@the-dreams.de, broonie@kernel.org, vz@mleia.com, fd@ti.com, linux-kernel@vger.kernel.org, pantelis.antoniou@konsulko.com, bgolaszewski@baylibre.com From: Srinivas Kandagatla Message-ID: <56C479CA.5010308@linaro.org> Date: Wed, 17 Feb 2016 13:46:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455666097-9115-7-git-send-email-andrew@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/02/16 23:41, Andrew Lunn wrote: > if (!(pd->flags & EE_READONLY)) { > - edev->bin.write = eeprom_93xx46_bin_write; > - edev->bin.attr.mode |= S_IWUSR; > } > Is this check really required? --srini