From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424194AbcBQQLz (ORCPT ); Wed, 17 Feb 2016 11:11:55 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:33783 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161077AbcBQQLx (ORCPT ); Wed, 17 Feb 2016 11:11:53 -0500 From: "R, Vignesh" Subject: Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read request To: Mark Brown References: <1449807000-6457-1-git-send-email-vigneshr@ti.com> <1449807000-6457-4-git-send-email-vigneshr@ti.com> <20160209193616.GN13270@sirena.org.uk> <56BC1D3E.5020203@ti.com> <20160212223711.GD18988@sirena.org.uk> <56C2D731.6050306@ti.com> <20160216123854.GJ18327@sirena.org.uk> CC: Tony Lindgren , Brian Norris , Rob Herring , Russell King , "hramrach@gmail.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mtd@lists.infradead.org" , "linux-spi@vger.kernel.org" Message-ID: <56C49B9E.8060506@ti.com> Date: Wed, 17 Feb 2016 21:41:10 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160216123854.GJ18327@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/2016 06:08 PM, Mark Brown wrote: > On Tue, Feb 16, 2016 at 01:30:49PM +0530, Vignesh R wrote: >> On 02/13/2016 04:07 AM, Mark Brown wrote: >>> On Thu, Feb 11, 2016 at 11:03:50AM +0530, Vignesh R wrote: >>>> On 02/10/2016 01:06 AM, Mark Brown wrote: > >>>>> Looking at this I can't help but think that spi_flash_read() ought to >>>>> have the stub in rather than the caller. But given that we're pretty >>>>> much only ever expecting one user I'm not 100% sure it actually matters. > >>>> Well, my initial patch set passed long list of arguments to >>>> spi_flash_read(), but Brian suggested to use struct[1] in order to avoid >>>> unnecessary churn when things need changed in the API. > >>> I don't see what that has to do with my point? > >> AFAIU, your previous comment was to move initialization of >> spi_flash_read_message struct to spi_flash_read(). This would mean > > No, not at all. I'm talking about how we handle the case where we don't > have hardware support for this and need to implement it in software - > currently that's in a separate place to the place where we call the > driver. > Yeah, but AFAIK, hardware accelerated read support is applicable for m25p80 flashes only, I doubt whether spi_flash_read() will be used by other types. I felt keeping the software implementation in m25p80_read() will be consistent with m25p80_write(). -- Regards Vignesh