Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle period

From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle period
Date: Fri, 19 Feb 2016 15:01:05 +0000	[thread overview]
Message-ID: <56C72E31.9010707@linaro.org> (raw)
In-Reply-To: <CAJZ5v0icpNoW3SFxvsj5bSo9MnH3cvthece1bMVJRHm7i8HhAw@mail.gmail.com>

On 02/18/2016 07:57 PM, Rafael J. Wysocki wrote:
> On Thu, Feb 18, 2016 at 11:25 AM, Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>> On 02/17/2016 11:21 PM, Rafael J. Wysocki wrote:
>>
>> [ ... ]
>>
>>>>> Reviewed-by: Nicolas Pitre <nico@linaro.org>
>>>>
>>>>
>>>> Well, I'm likely overlooking something, but how is this going to be
>>>> hooked up to the code in idle.c?
>>>
>>>
>>> My somewhat educated guess is that sched_idle() in your patch is
>>> intended to replace cpuidle_idle_call(), right?
>>
>>
>> Well, no. I was planning to first have it to use a different code path as
>> experimental code in order to focus improving the accuracy of the prediction
>> and then merge or replace cpuidle_idle_call() with sched_idle().
>
> In that case, what about making it a proper cpuidle governor that
> people can test and play with in a usual way?  Then it may potentially
> benefit everybody and not just your experimental setup and you may get
> coverage on systems you have no access to normally.
>
> There is some boilerplate code to add for this purpose, but that's not
> that bad IMO.

Hi Rafael,

sorry for the delay in the responses.

Actually, adding a new governor is precisely what I would like to avoid 
because the objective is the scheduler acts as the governor. Here, it is 
the 'predictor' and the API to enter an idle state conforming the idle 
duration and the latency constraint.

Concerning the testing, it is quite easy to switch from idle_sched to 
'menu' via on sched_debug or whatever option we want to add.

>
> So I'm still unsure why you want to replace cpuidle_idle_call() with
> sched_idle().  Is there anything wrong with it that it needs to be
> replaced?

I don't want to replace cpuidle_idle_call() with sched_idle(). How we 
integrate the API is something I would like to discuss with another 
patchset focused in this integration only.

For reference: https://lkml.org/lkml/2016/1/12/530

-- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog