From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Wenyou Yang <wenyou.yang@atmel.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Brown <broonie@kernel.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
Russell King <linux@arm.linux.org.uk>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Josh Wu <josh.wu@atmel.com>, Josh Wu <rainyfeeling@outlook.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node
Date: Mon, 22 Feb 2016 13:58:23 +0100 [thread overview]
Message-ID: <56CB05EF.9020105@atmel.com> (raw)
In-Reply-To: <1455687741-9625-1-git-send-email-wenyou.yang@atmel.com>
Le 17/02/2016 06:42, Wenyou Yang a écrit :
> From: Josh Wu <josh.wu@atmel.com>
>
> In sama5d3, sama5d4 chips, pmecc will use the hsmc clock. As pmecc is
> part of HSMC. So move out hsmc_clk from nfc node to nand node.
>
> Signed-off-by: Josh Wu <rainyfeeling@outlook.com>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
I'm not against this change, but beware, it must be applied in
synchronization with the patch just posted "[PATCH] mtd: atmel_nand:
move the hsmc_clk from nfc node to nand node"
Bye,
> ---
>
> arch/arm/boot/dts/sama5d3.dtsi | 2 +-
> arch/arm/boot/dts/sama5d4.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index a532791..a242d27 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -1474,6 +1474,7 @@
> atmel,nand-has-dma;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_nand0_ale_cle>;
> + clocks = <&hsmc_clk>;
> atmel,pmecc-lookup-table-offset = <0x0 0x8000>;
> status = "disabled";
>
> @@ -1486,7 +1487,6 @@
> 0xffffc000 0x00000070 /* NFC HSMC regs */
> 0x00200000 0x00100000 /* NFC SRAM banks */
> >;
> - clocks = <&hsmc_clk>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index b8032bc..1499b33 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -295,6 +295,7 @@
> atmel,nand-has-dma;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_nand>;
> + clocks = <&hsmc_clk>;
> status = "disabled";
>
> nfc@90000000 {
> @@ -306,7 +307,6 @@
> 0xfc05c000 0x00000070 /* NFC HSMC regs */
> 0x00100000 0x00100000 /* NFC SRAM banks */
> >;
> - clocks = <&hsmc_clk>;
> atmel,write-by-sram;
> };
> };
>
--
Nicolas Ferre
next prev parent reply other threads:[~2016-02-22 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 5:42 [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node Wenyou Yang
2016-02-22 12:58 ` Nicolas Ferre [this message]
2016-02-23 6:02 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB05EF.9020105@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=rainyfeeling@outlook.com \
--cc=robh+dt@kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).