From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755767AbcBVOgb (ORCPT ); Mon, 22 Feb 2016 09:36:31 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:29909 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755752AbcBVOgW (ORCPT ); Mon, 22 Feb 2016 09:36:22 -0500 Subject: Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check To: Borislav Petkov , "Luis R. Rodriguez" References: <1455887316-9223-1-git-send-email-mcgrof@kernel.org> <1455887316-9223-9-git-send-email-mcgrof@kernel.org> <56C71704.9080404@suse.com> <20160219144841.GP25240@wotan.suse.de> <20160222060756.GB25240@wotan.suse.de> <20160222102743.GB17895@pd.tnic> Cc: Juergen Gross , rusty@rustcorp.com.au, x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, xen-devel@lists.xensource.com, david.vrabel@citrix.com From: Boris Ostrovsky Message-ID: <56CB1C72.2000603@oracle.com> Date: Mon, 22 Feb 2016 09:34:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160222102743.GB17895@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22/2016 05:27 AM, Borislav Petkov wrote: > On Mon, Feb 22, 2016 at 07:07:56AM +0100, Luis R. Rodriguez wrote: >> diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h >> index 1ae89a2721d6..fe0d579b63e3 100644 >> --- a/arch/x86/include/asm/x86_init.h >> +++ b/arch/x86/include/asm/x86_init.h >> @@ -84,11 +84,14 @@ struct x86_init_paging { >> * boot cpu >> * @timer_init: initialize the platform timer (default PIT/HPET) >> * @wallclock_init: init the wallclock device >> + * @no_cmos_rtc: set when platform has no CMOS real-time clock >> + * present >> */ >> struct x86_init_timers { >> void (*setup_percpu_clockev)(void); >> void (*timer_init)(void); >> void (*wallclock_init)(void); >> + bool no_cmos_rtc; > I'd add > > u64 flags; > > to x86_init_ops and then set X86_PLATFORM_NO_RTC or so in there. The > reason being, others could use that flags field too, for other stuff and > define more bits. Maybe timer_flags or platform_flags (or something else) to be a little more cscope-friendly? -boris