From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757287AbcBWE1H (ORCPT ); Mon, 22 Feb 2016 23:27:07 -0500 Received: from mga02.intel.com ([134.134.136.20]:20383 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757231AbcBWE1F (ORCPT ); Mon, 22 Feb 2016 23:27:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,488,1449561600"; d="scan'208";a="751357427" Subject: Re: [PATCH v3 05/11] KVM: page track: introduce kvm_page_track_{add,remove}_page To: Paolo Bonzini References: <1455449503-20993-1-git-send-email-guangrong.xiao@linux.intel.com> <1455449503-20993-6-git-send-email-guangrong.xiao@linux.intel.com> <56C6FE97.3080806@redhat.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kai.huang@linux.intel.com, jike.song@intel.com From: Xiao Guangrong Message-ID: <56CBDDA2.3080806@linux.intel.com> Date: Tue, 23 Feb 2016 12:18:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56C6FE97.3080806@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2016 07:37 PM, Paolo Bonzini wrote: > > > On 14/02/2016 12:31, Xiao Guangrong wrote: >> +static bool check_mode(enum kvm_page_track_mode mode) >> +{ >> + if (mode < 0 || mode >= KVM_PAGE_TRACK_MAX) >> + return false; >> + >> + return true; >> +} > > Oops, forgot about this; please rename to page_track_mode_is_valid and > make it "static inline". Sure, it looks good to me. :)