From: Vlastimil Babka <vbabka@suse.cz>
To: Rik van Riel <riel@surriel.com>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, hannes@cmpxchg.org,
akpm@linux-foundation.org, mgorman@suse.de
Subject: Re: [PATCH] mm,vmscan: compact memory from kswapd when lots of memory free already
Date: Tue, 23 Feb 2016 10:18:47 +0100 [thread overview]
Message-ID: <56CC23F7.8010709@suse.cz> (raw)
In-Reply-To: <20160222225054.1f6ab286@annuminas.surriel.com>
On 02/23/2016 04:50 AM, Rik van Riel wrote:
> If kswapd is woken up for a higher order allocation, for example
> from alloc_skb, but the system already has lots of memory free,
> kswapd_shrink_zone will rightfully decide kswapd should not free
> any more memory.
>
> However, at that point kswapd should proceed to compact memory, on
> behalf of alloc_skb or others.
>
> Currently kswapd will only compact memory if it first freed memory,
> leading kswapd to never compact memory when there is already lots of
> memory free.
>
> On my home system, that lead to kswapd occasionally using up to 5%
> CPU time, with many man wakeups from alloc_skb, and kswapd never
> doing anything to relieve the situation that caused it to be woken
> up.
Hi,
I've proposed replacing kswapd compaction with kcompactd, so this hunk
is gone completely in mmotm. This imperfect comparison was indeed one of
the things I've noted, but it's not all:
http://marc.info/?l=linux-kernel&m=145493881908394&w=2
> Going ahead with compaction when kswapd did not attempt to reclaim
> any memory, and as a consequence did not reclaim any memory, is the
> right thing to do in this situation.
>
> Signed-off-by: Rik van Riel <riel@redhat.com>
> ---
> mm/vmscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 71b1c29948db..9566a04b9759 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3343,7 +3343,7 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
> * Compact if necessary and kswapd is reclaiming at least the
> * high watermark number of pages as requsted
> */
> - if (pgdat_needs_compaction && sc.nr_reclaimed > nr_attempted)
> + if (pgdat_needs_compaction && sc.nr_reclaimed >= nr_attempted)
> compact_pgdat(pgdat, order);
>
> /*
>
next prev parent reply other threads:[~2016-02-23 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 3:50 [PATCH] mm,vmscan: compact memory from kswapd when lots of memory free already Rik van Riel
2016-02-23 9:18 ` Vlastimil Babka [this message]
2016-02-23 15:39 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC23F7.8010709@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).