From: Prarit Bhargava <prarit@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH] lib/bug.c: use common WARN helper
Date: Tue, 23 Feb 2016 08:13:46 -0500 [thread overview]
Message-ID: <56CC5B0A.5080107@redhat.com> (raw)
In-Reply-To: <14cbeea6c0eb49dc17437b2b8f9448e9e8d40236.1456199584.git.jpoimboe@redhat.com>
On 02/22/2016 10:54 PM, Josh Poimboeuf wrote:
> The traceoff_on_warning option doesn't have any effect on s390, powerpc,
> arm64, parisc, and sh because there are two different types of WARN
> implementations:
>
> 1) The above mentioned architectures treat WARN() as a special case of a
> BUG() exception. They handle warnings in report_bug() in lib/bug.c.
>
> 2) All other architectures just call warn_slowpath_*() directly. Their
> warnings are handled in warn_slowpath_common() in kernel/panic.c.
>
> Support traceoff_on_warning on all architectures and prevent any future
> divergence by using a single common function to emit the warning.
>
> Also remove the '()' from '%pS()', because the parentheses look funky:
>
> [ 45.607629] WARNING: at /root/warn_mod/warn_mod.c:17 .init_dummy+0x20/0x40 [warn_mod]()
>
> Reported-by: Chunyu Hu <chuhu@redhat.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
<snip>
> -
> - print_modules();
> - show_regs(regs);
> - print_oops_end_marker();
> - /* Just a warning, don't kill lockdep. */
> - add_taint(BUG_GET_TAINT(bug), LOCKDEP_STILL_OK);
> + __warn(file, line, (void *)bugaddr, BUG_GET_TAINT(bug), regs,
> + NULL);
> +
^^^ minor minor minor nit: extra line here. Not a big deal but change it if
anyone else complains.
Other than that ...
Acked-and-tested-by: Prarit Bhargava <prarit@redhat.com>
P.
> return BUG_TRAP_TYPE_WARN;
> }
>
>
next prev parent reply other threads:[~2016-02-23 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 3:54 [PATCH] lib/bug.c: use common WARN helper Josh Poimboeuf
2016-02-23 12:14 ` Heiko Carstens
2016-02-23 13:13 ` Prarit Bhargava [this message]
2016-02-23 13:35 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC5B0A.5080107@redhat.com \
--to=prarit@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).