From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755895AbcBWXSF (ORCPT ); Tue, 23 Feb 2016 18:18:05 -0500 Received: from mail-bn1bon0087.outbound.protection.outlook.com ([157.56.111.87]:31106 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755741AbcBWXSB (ORCPT ); Tue, 23 Feb 2016 18:18:01 -0500 Authentication-Results: linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error To: Borislav Petkov References: <1455659111-32074-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1455659111-32074-4-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160223121142.GA3673@pd.tnic> CC: , , , , , , , , , , , , , , From: Aravind Gopalakrishnan Message-ID: <56CCE510.1010906@amd.com> Date: Tue, 23 Feb 2016 17:02:40 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160223121142.GA3673@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN1PR12CA0002.namprd12.prod.outlook.com (25.162.96.140) To SN1PR12MB0431.namprd12.prod.outlook.com (25.162.105.12) X-MS-Office365-Filtering-Correlation-Id: 43e28c5a-6439-4ffa-5e56-08d33ca571ba X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0431;2:G2/dr5rRTF4LkCPO9zsb8hizPEzKX2D+WawYhqixdKmeQJb0IFoX4kXmnoj4MApDVAWjgqT0UBz/Hhm0iSbM/Y/pEF4TjSOrzPUnZOUdX2SSM1gKNHuQeZl0A+TeOPGJaK0TQqf5eHd7Vtpql7++1sUHkgupVylmuBhYNzZwO6paGoSIkoDzD0r7f0/N3CEN;3:JmQMn1zfd7w7PnxVLkFIMF0q7P/96CaKMLH99erdTyF3YGG/cxfe+DMTgF4LXHJtNm3+Q23Y34HPYpmMipbAbNHfdra3v9xYEGTBKYsSnp5b2nA65A+gzgdlHFh6S/gS;25:mexOL2KtXTOXTLgm+71bRXGBMe9uqolJBf+G8fF+udGYak3MCrXH4MxagpfTPvfBY7jORfYbxPr5HBuH+4N9wrqhHcHt9rDCArTQaTbfW7kA43kcVvcSjcPtv7ANXj9PIuAB2aHlD2W4NlvXadbU3Jjhm2nNv3r0q2BLITBnQd9d90P6iRs5G80tdNUzaPwr9cVEEPIzIS6ClrfmgpYDMdoUnp1DYFFOwfieNqICxKvsWp+U+WYbApWpLtr/MoG4FUDiClkSxiRx7DbrjmiRF7P2p9AnxyXQlpgryzmOZ4sQhRWXJtlvB/wPq3nWb6cz73EX++YOoQxdk1vSfMEF1P3wGxwwEBaxmIPOzro78io= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0431; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0431;20:gq3cLuksdbI5jOik+s/7I1nA9tTw56rl9PW4eVlGlT0y11Svp3I9KSHyUWUvF2aqG0yu+Hqg8b1kc6SRrp44dmzM0fa50zxaOtWQVuww9zw47IgyL2lcGEJXKwxqSkcbD1UlLc2SjEbS1F4UH6mUQZ9rPa9V4FpQ7sSLVIGv4aaTseKPMA4Z1nV/FRD+vSXBB+uNZQ2DjkZOwslbIX1rRE5oGBFF4h0z9MT1VHIaH3sDpXEc2o9eyxKWnMeN65i7fD5d2gg6earRNz5s0ud/v8U8sMobQ3hATM52mPXQZyvqG77bHhHFoUvKXuRyH49RUKYxyMUghQj2DK5mv+ABM/dIrZXX0OlXPkCQMSM7ea058/jEWjo2YxlCJbY6xjezHD4Y9QFgyItj/fMNu0ba2UM8TZjNSgi6Mwvrn9YPygJjB+O+8lqkndCYN4csKeUbGqpLz82DecouAc1t/c9Ddvbjx53VFyjZW1NSj757GIBZ7rwx52n0/Xy5bqxf5Xq6;4:qySDjMQ9n45nI7qPFri/tPv5rPghvYocTotf7ws/Xz63ZlOD2cZA1Q83ZySAPxE0ntY8G6/1xDh/9ZX71cGT+ollQSvN9G18AirQ79ioK+UXf3w39SalSsrWTtDw2yCBKIyBhPS4OyG5xb5opYh4ysKqgleV9IKzykxaK3qa/ktUOEQgu0GbBWrrsLBNauI3RpxFS0Ldw28jqU69C5dODiQ3T8HJ4+HS+1EQ+KoNGzh/zpYaakgDO4/+1fGCWeSCmuzOTEzeyrwNnhZMvHhk9UvTrYyNunb8ZZ0Z8ksCJh6CkQiIDFK0UlSII1ugeL50fZLKIA5X5/HAYQ9KnMoF/LQgTRpnhRgP7ilBJAPdysZdQKFE+weq5BNVdC1N21NO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:SN1PR12MB0431;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0431; X-Forefront-PRVS: 08617F610C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(479174004)(164054003)(377454003)(1096002)(42186005)(87976001)(53416004)(3846002)(23676002)(50986999)(87266999)(54356999)(189998001)(65816999)(76176999)(110136002)(36756003)(65956001)(86362001)(230700001)(47776003)(4326007)(66066001)(586003)(5008740100001)(2906002)(5004730100002)(6116002)(2950100001)(50466002)(92566002)(40100003)(4001350100001)(122386002)(33656002)(77096005)(80316001)(65806001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0431;H:wsp100563wss.amd.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwNDMxOzIzOmRURHJqRlhtVHFPVTVuRTh4a1llRXBkSkpi?= =?utf-8?B?S1BjWkNQMlA4bG13OEc2MUk1QmZSREhzODRkNC9yTThUV2Iwb3lnNGJwbWVk?= =?utf-8?B?MWpXMVhQTlVvZE40TnVuRjRYellNWGZYb0czbll5bUJ3elV2akFqUHNjcXdK?= =?utf-8?B?aVdCYXFZV2liRGxuVnR3bUp0S25wYUc4NFZnYXNyYjRMTndpZTBmNGx5QjI2?= =?utf-8?B?bmJNbUo4Q1NnSHI4Tm04VStIRTJOKzZnNkF5T2tHTjJVUTU1YWtNdEFVNCtj?= =?utf-8?B?OXNlUEluT1I2YXEwM0s3MkdycXFuQ3hieEFqMVhoZDhNY1hrMTNDN1NwL1VE?= =?utf-8?B?YkRnS1MrN1NualJWc293Rk4yNnRwZHdaY1RzMFRZNVc2WTdoL1crY2k0bUNn?= =?utf-8?B?KzlaVkI0elNYYUY3YzhxZldXZ3IvN0hHaGFjSXBJcitHMktQWGF1eWt3SXRE?= =?utf-8?B?Z1VFcDBnOEpuQXNxOXBBN2p1SUVzOW5jRTVUOUVmcHVBVkpIUWVNbjlNdHVQ?= =?utf-8?B?emxzN1lWYW9UUEpyT3RpeGF6eTQrM2laWjUxUER2VkFIeXc1eXBlZFBGN0RI?= =?utf-8?B?NFpuVVhPcHpuVmhSaFZPSnJrbXpsK3hMU0dIK1B5THNpVTVmMlE3OUFqKy9J?= =?utf-8?B?TGlLVVJaMWpEekRqWHlkcDdNZHY0UEZIb2NMM2VScTlBRDE1Tk1XMWhyQVhT?= =?utf-8?B?Nzk3TmZZbHliQTNPQzdYa0E1VUpOQXpibFdISzcwVGxPMWo1WFJPNUxGVjMv?= =?utf-8?B?UDRhV09INm9kZFFwNnZrMjY3cFFlREtsQW4vdzFkUDhDVjF3SWpGaFFOVEJ6?= =?utf-8?B?dlBQbGlPUVh4c3FmeDU0dUFDVDJ6V2k0NlNXMXdpRGR1RTYwV1lXdjRzRklG?= =?utf-8?B?bjZIaWJnRC8zSE50Z2ZMK09aeHlwNE02Z0VHeVdpTk1qMHpZVUd1ZHFURENz?= =?utf-8?B?aG5WZ0NzS2h0ZTJlT2ZuTlpUdGNDditkbjJQNitydjVLUlFIdmFOZ2Z0ajB2?= =?utf-8?B?WGlZdmJjY3UzbDlsaDdCMG51ZTNpUWFobzVyUXc1K1RhYjJrZ1JkNWI2NWUy?= =?utf-8?B?eWxETDlRSVd6NHlwRkJNNXpmMWk3M2JvR3J0TExReUZta2VYS05ZbzNmVVdN?= =?utf-8?B?d0lxMExzT1pVSU5MU3FCRVoxNzZpOS85cHlMaW9WZStZdzF1WkZabEk2dGht?= =?utf-8?B?Wk9sMDJKSmV3RHVlS3d5eFd6cDJGMHRoSEdZR1hIODFlU2FMQUY1SitmOGtk?= =?utf-8?B?WE8vaTN0OXVnQ3poTWRPaTROckgwYklQeXBXL2RjazFGYStwNXY3cmJzQjNE?= =?utf-8?B?c2JSQVZkcnFjWWZsRkljaUF0Z09ST21DNWZBNkU2UDU1a1VPMWQ2b0hERURx?= =?utf-8?B?T2dhdnRsVktUaXU5c3pDL3BvbkM4OVZ1VXVXd3dISlM2YlNKZkh0WDRpWE00?= =?utf-8?Q?ddTsTqq4oq531xuN0KMaAHmB1MB?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0431;5:6BroOB/jjk9oPPLmsDhrpWvccf9ddYTgNpgWmvPl59yrDNhy8ZW3djz2fqf8jF0KKlVQQ0u/C5E9LueKkxB9hx+NGXWoXbcF/scO9TuW5zg9LK2TZV4OGK8zSB399z0A0QAxLFpGUJdcssf1exn8DA==;24:gWjFnt2V8Eg636ksmh8lCxshXfom9U/xGh8hMa0x2t4uW65PfEvapRDKlapGtFAeAsgHZr+fzis21y6U59ExThJZ4SRb8S/vBjqOqWrZFMs=;20:UKmBExr1BeC3wNARty7hEFPSPEoCvwQLkfq12Ks0GvmO/U4KuBdwAFpfF7OAShQNn2wTqDm4G7fwenwszGOY0lTj9DoMmro8n5oIVhjc52JtLTKtr04TIf6/t1SrgUMVq9T+OutkbQ8A3KoPdnGUzSPFaVznRy+pL4Hikni4UWEkyxM/Ho8am/AVNVz6zXS10E94WavoCDcbRHUoYTMoxf8IKdsv+TEU7rXUo58maU0ljUglT15D3G/aykzBv7O3 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2016 23:02:45.3118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0431 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/23/16 6:11 AM, Borislav Petkov wrote: > On Tue, Feb 16, 2016 at 03:45:10PM -0600, Aravind Gopalakrishnan wrote: >> /* AMD-specific bits */ >> -#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare an uncorrected error */ >> +#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare a deferred error */ > /* uncorrected error, deferred exception */ > > sounds better to me. Hmm. Well, Deferred error is a separate class of error by itself. It's neither Corrected in HW nor is it Uncorrected like a MCE. If you feel "Uncorrected error, deferred error exception" won;t be confusing, that's OK with me. > > For the future, such cleanups/fixes should always go first in the patch > set. > Ok, I'll retain the order this time for V2 patchset as well. But noted for future. Thanks, -Aravind.