From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756978AbcBXGCH (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Feb 2016 01:02:07 -0500
Received: from mail-pf0-f175.google.com ([209.85.192.175]:34498 "EHLO
	mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752633AbcBXGCF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Feb 2016 01:02:05 -0500
Subject: Re: commit 271e1b86e691 is breaking DMA uart on SoCFPGA
To: Dinh Nguyen <dinguyen@opensource.altera.com>,
        Alexander Kochetkov <al.kochet@gmail.com>
References: <56BBB201.7060004@opensource.altera.com>
 <20160211085748.GW19598@localhost> <3095560.0L3m2DPBqY@amdc1976>
 <CAPUzuU1nDx2PpZrD=JO5mm+Ygq9Pa_zoEjeONqPzzdGvRwb-2A@mail.gmail.com>
 <56CC775E.1020203@opensource.altera.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Vinod Koul <vinod.koul@intel.com>, shawn.lin@rockchips.com,
        Addy Ke <addy.ke@rock-chips.com>, Boojin Kim <boojin.kim@samsung.com>,
        dmaengine@vger.kernel.org, olof Johansson <olof@lixom.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: Caesar Wang <caesar.upstream@gmail.com>
Message-ID: <56CD4757.4080501@gmail.com>
Date: Wed, 24 Feb 2016 14:01:59 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <56CC775E.1020203@opensource.altera.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Thanks Dinh & Alexander for the intergration testing.

---

@Dinh,

Can you test it again with the patch[0]?

patch[0]:
https://patchwork.kernel.org/patch/8398511/



-
Caesar
在 2016年02月23日 23:14, Dinh Nguyen 写道:
> Hi,
>
> Sorry that I couldn't get to this sooner.
>
> On 02/18/2016 10:07 AM, Alexander Kochetkov wrote:
>> Hello!
>>
>> Bartlomiej, could you please tell what uart driver is used on Samsung
>> Exynos4412?
>> Dinh, could you please tell what uart driver is used on SoCFPGA?
>>
> SoCFPGA is using the 8250_dw.c uart driver.
>
>> Could you make two test?
>>
>> 1) Checkout tree at commit 848e9776fee4 "dmaengine: pl330: support
>> burst mode for
>>   dev-to-mem and mem-to-dev transmit", make it buildable and see is it
>> works. In order to make in buildable remove bursts argument from the
>> line:
>>
>>      if (*bursts == 1)
>>      - return _bursts(pl330, dry_run, buf, pxs, 1);
>>      + return _bursts(dry_run, buf, pxs, 1);
>>
> This case still fails for me.
>
>> 2) Checkout next-20160211 kernel tree and set src_maxburst and
>> dst_maxburst to 1 inside UART driver to see is it works?
>>
> This case works and the UART is able to operate in DMA mode.
>
> Dinh
>
>
>
>
> -- 
> Thanks,
> Caesar