From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758483AbcBXSHG (ORCPT ); Wed, 24 Feb 2016 13:07:06 -0500 Received: from mail-bl2on0091.outbound.protection.outlook.com ([65.55.169.91]:30176 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758401AbcBXSHC (ORCPT ); Wed, 24 Feb 2016 13:07:02 -0500 X-Greylist: delayed 69377 seconds by postgrey-1.27 at vger.kernel.org; Wed, 24 Feb 2016 13:07:01 EST Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O32CZK-07-2W2-02 X-M-MSG: Subject: Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error To: Borislav Petkov References: <1455659111-32074-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1455659111-32074-4-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160223121142.GA3673@pd.tnic> <56CCE510.1010906@amd.com> <20160224113744.GC3888@pd.tnic> CC: , , , , , , , , , , , , , , From: Aravind Gopalakrishnan Message-ID: <56CDF13D.1070703@amd.com> Date: Wed, 24 Feb 2016 12:06:53 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160224113744.GC3888@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(24454002)(164054003)(479174004)(189002)(377454003)(199003)(23676002)(110136002)(11100500001)(2906002)(4326007)(1096002)(1220700001)(59896002)(54356999)(50466002)(76176999)(189998001)(65816999)(230700001)(5008740100001)(5004730100002)(33656002)(80316001)(87266999)(83506001)(86362001)(106466001)(87936001)(47776003)(36756003)(101416001)(65806001)(92566002)(65956001)(2950100001)(77096005)(105586002)(50986999)(3846002)(6116002)(93886004)(586003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0718;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 98bfea75-2442-4f0a-e656-08d33d4549c6 X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;2:A6RTA0OXuTS8ABgubsT6gf7I8wFjPOXNaBrr+82W8+e+17VCV4RcNApbJ6/tHhebdU4ljFFdWUUKfQMckg6K9KMXICQGS8h8MKAnRfQfV3fidP0pbDFNxW3i4P2ZZhP2J2YEqWvalEJaKPY+t1XKn1yQNKzat9itSUdDpTtOfv4u7xVIpV1c5xFG5dt6Mg86;3:ESo5GpbZp2tU7izSuqbY8mAT4iqnsdFz1OXjexadLlXxL6GlHEW6OkB5lrBBNw42UmF2nPXVhj0G6y4z66Blt7iARd4KUPQQyDEfnIO35VbZlcGbMtJxaBYaGE8CQ48/Y59uAwKZyI5YJxM3G6BMcTvFMW5ZUbUNCCyyCR9NtpSqD6LmivFHbzwPuMIIH9fdI9B6tRoJ5B3tfjr9W911MORIK9iWX3vlOw7jimLlygM=;25:2azfaQ/AcC367SYvfNBsnZbTu65kef7oPy6cWGGzcidfmpRD+GEzVXWqKrWGnNscCGyJCR5zbGhaLHwojrQsf+jQ+Le64gWSaXVS3zC30+kojlLfp37MfQO5xyrAFndPqwAU/ovPo+GnebsZlPZMEQQrv6hurTFOM/ZpNTkhyDa9z37K1fbt/Ale/3FN+LCC2M4b5e7MuhZVPZh72RepT3fdeR1fvGG/Ihqmr+4KGEome/bBGUQC50WW1DtOuxuZ/awH9Lh5DK3XgvTzOEw2JTNMLM3W38VEVbBRsWu1HOP8kGkU7tehG7NiYrVwwwTtzGqWwxdt/ORwRzEoum1vFg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0718; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;20:Uh/l8Chagq7+n1qcUHyOVd/R0ZjOzsFJdBUk4lmx1Am/WuoEAKzvMdOiF6i2dRuJ4szqM7xBl5FendlKVUTvkR28DCTS8sdR+aQENkoEpPpL0Qkh6LjJuFmKFMVzGjUy9iv4rHrgsr0TZnaqkuBhRfyQ8p+azv/ABx5O2H5n4NUoUFmxzVrk6UERUcfvtwxo3WgV2kU+OsfcRtKbAnBuyB0867lMFmyy1iDXDtYMVFmdZN/tQ5a2ImqBpwsNfzX2GIVntf+oeP5ga5motitnG9Bo0I04TUlJ1TeHHWGNke/QAf+h28sDD6HCnA5XH4IBGm9trZMh5f4erm6UQjD7bHwRRoqARufx037wUzgxwNTX4pAephXdSyTZzzJeKoT0Y5gHlar1arRIUVcyo9QWuV5+wR+9h0p9YbLJJS0UhEp3oW8ypV0UhP8waA3hBCz4X9R8xG3Ba0qRl2zz5o1XPt2rJjT74VJT4BiNjqqidCpOxM68N98VvFMJBsNAc3NW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13024025)(8121501046)(13015025)(13018025)(13023025)(13017025)(5005006)(10201501046)(3002001);SRVR:SN1PR12MB0718;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0718; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;4:kLhe0CaTSkosa4uoPzvtC7pv/DkZUm7h2SajcEIB4JQyBlWG6Cg6P9Ri7yquw9zSnYSVGfberk7DO6deF4TVVYeg4ozmlDPcEq+/wfHLq+A7s7mTD20TUcU9P+V1oIl/r3xSPUrEyf6mfRGwCbYghv9UTxSS2bRzPXGVzC0DZPCfxktm+QaXgEnvMWtfSvcT7lg5nZrw9nc5ecKx45tqeW2enYp+iC3ep9YU0x5oTZBub8NenvsPp53YlNLzkjn/hW3SSniKIzAi0MMhNL3nmQjqoWLV2/EHL0DMg3/ItfbvNWsoD1ri6YWQZGsRbWSl6k5iHA0jXcu33fkBLZqXu4A9d8I6jH4DxTqIBZbgrU3gSxH4pTcD0ycp0hC72DbOMCZUbiV2Ho40hDLsJUHajbNOyKvClg+j17ooPRQhPVqsNCo0yb8tAN+/jJZOlSu/WhfZjFgneOJNnE1eUmM8Bg== X-Forefront-PRVS: 08626BE3A5 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwNzE4OzIzOjhkd1RKck9PRXFVNjF0QjBQWC91Y0VXOFZM?= =?utf-8?B?OEZvcGdBT2tneXNUUjZZRm1qTjZveS9XdXJPLzkxRC8zVkFod1Job3JFc3do?= =?utf-8?B?NnRTRHBCTEY2SzlHU3NtVjJVVVk1dWsxamRwMVU2clFaTWl4R2NINkk1ZGJZ?= =?utf-8?B?Wno4M2FIODFJb2xhL2YwUUhCTm1IRmF0eDlCWEpJU29zSXh5RkplWVdKZC9k?= =?utf-8?B?M1kvQjE5WW1BVnM0SFdwUklCZG01dmhxaVgzMmk4Vm1ZUVAzdTZxOHF1UlpH?= =?utf-8?B?bmdKRXFpTlRsVzd0YXcxZE5VZ00zaDFwaGtqOHdubDJISGdqaUpXbUUzS2pp?= =?utf-8?B?UzdMNnQyYzh6MEpWdmpIY3pEcmVUdWFnemI0dnpkci81S1F3ckdEM0NwL0xZ?= =?utf-8?B?dGRWNnNuS2ZOSU9KYW1SYnlzSDhkTjBuS2RxMjVnWXYvWFNlRmQ3dHUwRERS?= =?utf-8?B?WU5CM1FJMWhjMGJac0g0UmpVa3RuSGQ2SEFvdjFKYy94b3BlVlRTbi91ODl3?= =?utf-8?B?S0U5cCtLZVc2VnNoNkU4RkZxdzlDTlZRZ1Y1bXUvMTh4d2VFYkR5Mm9XdkNO?= =?utf-8?B?R2VIcTVhZGJhOFZlZmdaTzF6bXZKQVFhUTBxenNXczdwNnhMekpDbzg0bC9U?= =?utf-8?B?ZFExa2lEMFBQM3VCR0xpbWNwS2tHSmJxS0FqbUNJVjdxRjFFbVlTc0xENlZC?= =?utf-8?B?aGZwejUvNGl4U1Q4b1R2WlFXdy9sZ21kOXpzaStVNE10L3FNMU42QVc3Z2l6?= =?utf-8?B?bUR0VUR1QjU5YUNiUnJDV0tMNzh3NjQwZVVxUGdyWmtqRENkQmxaMUE0dXNI?= =?utf-8?B?Q29WMDJLTW51R01YcWVWSS9HVXJMc1ZURXlmRzZEOEZQSW4yb3lSc1lldm0y?= =?utf-8?B?MXdZMDJWbzFQeExIZ1E3REJXMUFrOXNvTHRjL2xqZ3h6YXU2aDJ3Y3VMdCtJ?= =?utf-8?B?QkhGNmY3VEttVEFBN0JpMUU1bEtSYzgwTmVnTVJURGt2UVlrbStGT244OVhp?= =?utf-8?B?WEErLzZlc0tjYzZaUkpzeHJ0NVljckpYUEFQSnB2UjdzM1kza2pzSUY0Q1RT?= =?utf-8?B?alVPNjdoZFpYbXd2K3FORnhXYnlnUDM4aWMwUFdEY0FSNHZFWndXS1k1NE5z?= =?utf-8?B?eG45TkI2Z0x2eVhMU25tTWowODErTXpCcWhHeDd1bjRZTk9weU5xUm9VQ2NQ?= =?utf-8?B?Mk0vTlRESk1CNmNFK0QvTmVPRmZiTzRQeXFiYU9oOXVHcHZXa2Vzcmt5ZEJz?= =?utf-8?B?NXk1QnlVbkl5MjZpWUxzYVRQNStocEtUdFo0aERROXlDUCszeDl2akZUL0Iz?= =?utf-8?B?SkpJeFA5NGFRVXlVVzd0WTR5bkF0UkphT3hlU0FUT2dGbVhWQnNiSUNmOVg0?= =?utf-8?B?ODNmN0ZaYzhtN2FJMFFmZTA1OFJiWlJaMVdpWTkyWjFtVXFzYm9FQ21HQUw0?= =?utf-8?B?SDYzSm1oeGk0Q2NOdmJnVlpPbnQyY1dRKzFpSkZIMXlWWEJ6MVh6djlJK3pO?= =?utf-8?B?aHZLRmVnemJwanlRVForenAzRjQ0akxrNXd3VlUrYjhnYTIvZzlhVjBtMWFu?= =?utf-8?B?VTNROW42ZW1nMktCd0swdmp0a0dKV3c9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;5:vCoOCzwoe8a/drhDMq642QwJ7Ifc47g+LmFlDdEQZINinDD8xRcV/i4SozW/hip014MaNXytodeFW17qPQ+hXG0oSrmD2eQmQ+1K1gvlS4emQ4rflc0UNO/YtjzZ0OgKh1f3nTt9qWKDKxiVYAVOsA==;24:XXVrRjD+kGaK9EhNWXYNBUh/c9G7z5sct6kw2QNuiH5O4s9q28HHp1NKLwU9eC1WHm2rR+hYuQ5t/KvL2bcNs+PgIF+HGCUQbkF82XWahgc=;20:jSk6LmGCqJrOOnFYbfGDPdYKwioWFxNbdH4YRwF/8YMLkvMrRj5GBIJFcIQfnMwGAr8jtdHepbjWsZnQoMt/ZFrQfFwzmGF861FatXXKLBKR8wlomHrEzGU34aMg8dpbL52HC+7I41XlczyrdQ/7W/v+YIuWc8jvFXZY2/dZiHyqFrV9veB+jhjWOnVjvONHpjjpZyfeTmfpaHo//oXcUucwmO0O96LTjcsxwjxP3x2AXq+VkXt+FcjyG3W8b4f6 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2016 18:06:57.6640 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0718 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/2016 5:37 AM, Borislav Petkov wrote: > On Tue, Feb 23, 2016 at 05:02:40PM -0600, Aravind Gopalakrishnan wrote: >> On 2/23/16 6:11 AM, Borislav Petkov wrote: >>> On Tue, Feb 16, 2016 at 03:45:10PM -0600, Aravind Gopalakrishnan wrote: >>>> /* AMD-specific bits */ >>>> -#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare an uncorrected error */ >>>> +#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare a deferred error */ >>> /* uncorrected error, deferred exception */ >>> >>> sounds better to me. >> Hmm. Well, Deferred error is a separate class of error by itself. >> It's neither Corrected in HW nor is it Uncorrected like a MCE. > Let's consult the BKDG: > > "Deferred: deferred error. > > > So it is an uncorrected error for which the raising of the error > exception was deferred until consumption. Yep. Okay, I'll fix as you suggested. >> If you feel "Uncorrected error, deferred error exception" won;t be >> confusing, that's OK with me. > Why would it be confusing? It is describing exactly what a deferred > error is, albeit a bit too laconic but people can find the longer > description. > That's precisely it- I thought I wasn't descriptive enough. But yeah, I guess I can include a reference to BKDG as well if anyone wants a detailed description. Thanks, -Aravind.