From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933431AbcBZPYy (ORCPT ); Fri, 26 Feb 2016 10:24:54 -0500 Received: from arrakis.dune.hu ([78.24.191.176]:42988 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933261AbcBZPYw (ORCPT ); Fri, 26 Feb 2016 10:24:52 -0500 Subject: Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW) To: Andrew Lunn References: <1456496504-50429-1-git-send-email-blogic@openwrt.org> <1456496504-50429-4-git-send-email-blogic@openwrt.org> <20160226151813.GD12022@lunn.ch> Cc: "Fred Chang (?????????)" , "Steven Liu (?????????)" , netdev@vger.kernel.org, "Carlos Huang (?????????)" , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , "David S. Miller" , linux-arm-kernel@lists.infradead.org From: John Crispin Message-ID: <56D06E3F.1020100@openwrt.org> Date: Fri, 26 Feb 2016 16:24:47 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160226151813.GD12022@lunn.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/02/2016 16:18, Andrew Lunn wrote: > On Fri, Feb 26, 2016 at 03:21:35PM +0100, John Crispin wrote: >> The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 >> external ports, 1 cpu port and 1 further port that the internal HW >> offloading engine connects to. >> >> This driver is very basic and only provides basic init and irq support. >> The SoC and switch core both have support for a special tag making DSA >> support possible. > > Hi Crispin > > There was recently a discussion about adding switches without using > DSA or switchdev. It was pretty much decided we would not accept such > drivers. > > Sorry > > Andrew > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek > Hi, would the series be ok if we just dropped those parts and then have a driver in the kernel that wont do much with the out of tree patches ? the problem here is that on one side people complain about vendors not sending code upstream. once they start being a good citizen and provide funding to send stuff upstream the feedback tends to be very bad as seen here. we are planning on doing a DSA driver but one step at a time. this kind of feedback will inevitably lead to vendors doing second thoughts of upstream contributions. John