From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933789AbcBZRGH (ORCPT ); Fri, 26 Feb 2016 12:06:07 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:48961 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933769AbcBZRGD (ORCPT ); Fri, 26 Feb 2016 12:06:03 -0500 Subject: Re: [PATCH] regmap: irq: Enable irq retriggering for nested irqs To: Grygorii Strashko , Mark Brown , Greg Kroah-Hartman , References: <1456502037-17036-1-git-send-email-grygorii.strashko@ti.com> CC: Lee Jones , Laxman Dewangan , Sekhar Nori From: Nishanth Menon Message-ID: <56D085F3.5090603@ti.com> Date: Fri, 26 Feb 2016 11:05:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456502037-17036-1-git-send-email-grygorii.strashko@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2016 09:53 AM, Grygorii Strashko wrote: > When nested interrupts are handled with regmap irq framework, we need to > mark the interrupts to be resend for pending interrupts on enable_irq. > Else the events might be lost for nested irqs. > > Signed-off-by: Grygorii Strashko > --- > drivers/base/regmap/regmap-irq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c > index 9b0d202..8d9004d 100644 > --- a/drivers/base/regmap/regmap-irq.c > +++ b/drivers/base/regmap/regmap-irq.c > @@ -379,6 +379,7 @@ static int regmap_irq_map(struct irq_domain *h, unsigned int virq, > irq_set_chip_data(virq, data); > irq_set_chip(virq, &data->irq_chip); > irq_set_nested_thread(virq, 1); > + irq_set_parent(virq, data->irq); > irq_set_noprobe(virq); > > return 0; > This is part of the fixes seen to be needed for VBUS irq over Palmas seen on BeagleBoard-X15. this patch was part of an internal series which finally resolved the crash (and associated hang) on X15 resume path. Tested-by: Nishanth Menon -- Regards, Nishanth Menon