From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933878AbcBZUpz (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Feb 2016 15:45:55 -0500
Received: from s12p02o150.mxlogic.net ([208.65.145.73]:32810 "EHLO
	s12p02o150.mxlogic.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754998AbcBZUpx convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Feb 2016 15:45:53 -0500
X-MXL-Hash: 56d0b9814459ffd4-e633ac0c100250d7cf6b8ba4c16e8edefe264e61
X-MXL-Hash: 56d0b97d7f5676f9-fb293ed9d1cdbd248f087de0a1367c2a4f6e974f
From: Kevin Smith <kevin.smith@elecsyscorp.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@savoirfairelinux.com" <kernel@savoirfairelinux.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH net-next 7/9] net: dsa: mv88e6xxx: restore VLANTable map
 control
Thread-Topic: [PATCH net-next 7/9] net: dsa: mv88e6xxx: restore VLANTable
 map control
Thread-Index: AQHRcMHqCp0O6NhAkk+MbjRlX7JmWJ8/MEwA
Date: Fri, 26 Feb 2016 20:45:28 +0000
Message-ID: <56D0B964.4090002@elecsyscorp.com>
References: <1456510568-13679-1-git-send-email-vivien.didelot@savoirfairelinux.com>
 <1456510568-13679-8-git-send-email-vivien.didelot@savoirfairelinux.com>
In-Reply-To: <1456510568-13679-8-git-send-email-vivien.didelot@savoirfairelinux.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.63.192.142]
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <A09C442420252148AAF47F002923ECA3@dciincorporated.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-AnalysisOut: [v=2.1 cv=Xb2PudN5 c=1 sm=1 tr=0 a=51qEjsKpZkmECDgIwGerrA==]
X-AnalysisOut: [:117 a=51qEjsKpZkmECDgIwGerrA==:17 a=Ubgksy_53ZIA:10 a=N65]
X-AnalysisOut: [9UExz7-8A:10 a=xqWC_Br6kY4A:10 a=jFJIQSaiL_oA:10 a=NEKDbFe]
X-AnalysisOut: [3jgU4DMWKdVsA:9 a=pILNOxqGKmIA:10 a=SJeXO3RuxwcA:10]
X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2016022613); S=0.200(2015072901)]
X-MAIL-FROM: <kevin.smith@elecsyscorp.com>
X-SOURCE-IP: [64.198.156.98]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vivien,

On 02/26/2016 12:16 PM, Vivien Didelot wrote:
> +	/* allow CPU port or DSA link(s) to send frames to every port */
> +	if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port)) {
> +		output_ports = mask;
> +	} else {
Is this always correct?  Are there situations where a CPU or neighboring 
switch should not be allowed to access another port? (e.g. Figure 6 or 7 
in the 88E6352 functional specification).

Thanks,
Kevin