From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756187AbcB0IkP (ORCPT <rfc822;w@1wt.eu>);
	Sat, 27 Feb 2016 03:40:15 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:47015 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754571AbcB0IkN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 27 Feb 2016 03:40:13 -0500
Subject: Re: [PATCH v8 1/5] mfd: hi655x: Add document for mfd hi665x PMIC
To: Chen Feng <puck.chen@hisilicon.com>, Lee Jones <lee.jones@linaro.org>
References: <1455431363-113771-1-git-send-email-puck.chen@hisilicon.com>
 <1455431363-113771-2-git-send-email-puck.chen@hisilicon.com>
 <20160215083204.GD3455@x1> <56C279B3.80300@hisilicon.com>
CC: <lgirdwood@gmail.com>, <broonie@kernel.org>,
        <linux-kernel@vger.kernel.org>, <w.f@huawei.com>,
        <kong.kongxinwei@hisilicon.com>, <haojian.zhuang@linaro.org>,
        <suzhuangluan@hisilicon.com>, <dan.zhao@hisilicon.com>
From: Wei Xu <xuwei5@hisilicon.com>
Message-ID: <56D16019.3020102@hisilicon.com>
Date: Sat, 27 Feb 2016 16:36:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <56C279B3.80300@hisilicon.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.46.4.134]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090204.56D1601B.00B3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 2f56c2c9e141c4f8cf3825e39d20245c
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Leo,

On 16/02/2016 09:21, Chen Feng wrote:
> Lee,
> Thanks for your review.
> 
> On 2016/2/15 16:32, Lee Jones wrote:
>> On Sun, 14 Feb 2016, Chen Feng wrote:
>>
>>> DT bindings for hisilicon hi655x MFD PMIC chip.
>>>
>>> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
>>> Signed-off-by: Fei Wang <w.f@huawei.com>
>>> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
>>> Reviewed-by: Haojian Zhuang <haojian.zhuang@linaro.org>
>>> ---
>>>  .../devicetree/bindings/mfd/hisilicon,hi655x.txt   | 27 ++++++++++++++++++++++
>>>  1 file changed, 27 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>>
>> For my own reference:
>>   Acked-by: Lee Jones <lee.jones@linaro.org>
>>
> 
> Will you merge this into your git-repo?
> 
> git git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
> 
> I saw mark already merged the part of regulator into his git tree.
> 
> 
> 
> 
> Hi Wei,
> 
> Could you help merge the DTS part of these patch sets.

Applied the 5th patch into the hisilicon soc tree.
Thanks!

Best Regards,
Wei

> 
>>> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>>> new file mode 100644
>>> index 0000000..0548569
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>>> @@ -0,0 +1,27 @@
>>> +Hisilicon Hi655x Power Management Integrated Circuit (PMIC)
>>> +
>>> +The hardware layout for access PMIC Hi655x from AP SoC Hi6220.
>>> +Between PMIC Hi655x and Hi6220, the physical signal channel is SSI.
>>> +We can use memory-mapped I/O to communicate.
>>> +
>>> ++----------------+             +-------------+
>>> +|                |             |             |
>>> +|    Hi6220      |   SSI bus   |   Hi655x    |
>>> +|                |-------------|             |
>>> +|                |(REGMAP_MMIO)|             |
>>> ++----------------+             +-------------+
>>> +
>>> +Required properties:
>>> +- compatible:           Should be "hisilicon,hi655x-pmic".
>>> +- reg:                  Base address of PMIC on Hi6220 SoC.
>>> +- interrupt-controller: Hi655x has internal IRQs (has own IRQ domain).
>>> +- pmic-gpios:           The GPIO used by PMIC IRQ.
>>> +
>>> +Example:
>>> +	pmic: pmic@f8000000 {
>>> +		compatible = "hisilicon,hi655x-pmic";
>>> +		reg = <0x0 0xf8000000 0x0 0x1000>;
>>> +		interrupt-controller;
>>> +		#interrupt-cells = <2>;
>>> +		pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
>>> +	}
>>
> 
> 
> .
>