From: Laxman Dewangan <ldewangan@nvidia.com>
To: Rhyland Klein <rklein@nvidia.com>, Lee Jones <lee.jones@linaro.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes
Date: Mon, 29 Feb 2016 18:08:57 +0530 [thread overview]
Message-ID: <56D43BE1.1080501@nvidia.com> (raw)
In-Reply-To: <56D07ED6.7030607@nvidia.com>
On Friday 26 February 2016 10:05 PM, Rhyland Klein wrote:
> On 2/19/2016 11:28 AM, Rhyland Klein wrote:
>> On 2/19/2016 3:50 AM, Lee Jones wrote:
>>> On Thu, 18 Feb 2016, Rhyland Klein wrote:
>>>
>>>> #define MFD_ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
>>>>
>>>> -#define MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, _match) \
>>>> +#define MFD_CELL_ALL(_name, _nres, _res, _pdata, _id, _compat, _match) \
>>>> { \
>>>> .name = (_name), \
>>>> .resources = (_res), \
>>>> - .num_resources = MFD_ARRAY_SIZE((_res)), \
>>>> + .num_resources = (_nres), \
>>>> .platform_data = (_pdata), \
>>>> .pdata_size = MFD_ARRAY_SIZE((_pdata)), \
The pdata_size initialization is also not correct. This is not the array
count but the size
of the platform data which is passed. Should be sizeof((_pdata))
>>
>> #define MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, _match) \
>> { \
>>
>> That was my first thought too. However, I see this when I try to compile
>> that:
>>
>> In file included from drivers/mfd/max77620.c:18:0:
>> include/linux/mfd/core.h:19:34: warning: the address of ‘gpio_resources’
>> will always evaluate as ‘true’ [-Waddress]
>> #define MFD_ARRAY_SIZE(arr) (arr ? (sizeof(arr) / sizeof((arr)[0])) : 0)
>>
>> 7 different times. This patch was the only way I seemed to be able to
>> WAR around compile time warnings.
>>
>> -rhyland
>>
> Did you not see warnings like this when you compiled the kernel? Did you
> find a different approach than what I proposed above to deal with it?
> I'd like to get this in soon so that when the max77620 drivers are all
> in and using it, it should be functional.
>
I think the following change also crash in runtime:
/***
commit e60a946f05db2cac857025da6ffb72df48d3be54
Author: Lee Jones <lee.jones@linaro.org>
mfd: ab8500: Provide a small example using new MFD cell MACROs
***/
Should we have something MFD_CELL_RES, MFD_CELL_RES_PDATA,
MFD_CELL_PDATA, for more common user and not to pass the NULL here.
next prev parent reply other threads:[~2016-02-29 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 18:52 [PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes Rhyland Klein
2016-02-19 8:50 ` Lee Jones
2016-02-19 16:28 ` Rhyland Klein
2016-02-26 16:35 ` Rhyland Klein
2016-02-29 12:38 ` Laxman Dewangan [this message]
2016-03-02 13:08 ` Lee Jones
2016-03-09 13:22 ` Laxman Dewangan
2016-03-11 8:39 ` Lee Jones
2016-03-11 8:57 ` Laxman Dewangan
2016-03-16 8:42 ` Lee Jones
2016-03-16 9:22 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D43BE1.1080501@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).