From: Marc Zyngier <marc.zyngier@arm.com>
To: mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com,
tglx@linutronix.de, tn@semihalf.com, christoffer.dall@linaro.org,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/core] hrtimer: Add support for CLOCK_MONOTONIC_RAW
Date: Wed, 2 Mar 2016 11:30:56 +0000 [thread overview]
Message-ID: <56D6CEF0.8060607@arm.com> (raw)
In-Reply-To: <tip-9c808765e88efb6fa6af7e2206ef89512f1840a7@git.kernel.org>
Thomas,
On 27/01/16 11:42, tip-bot for Marc Zyngier wrote:
> Commit-ID: 9c808765e88efb6fa6af7e2206ef89512f1840a7
> Gitweb: http://git.kernel.org/tip/9c808765e88efb6fa6af7e2206ef89512f1840a7
> Author: Marc Zyngier <marc.zyngier@arm.com>
> AuthorDate: Fri, 15 Jan 2016 17:41:08 +0000
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 27 Jan 2016 12:38:04 +0100
>
> hrtimer: Add support for CLOCK_MONOTONIC_RAW
>
> The KVM/ARM timer implementation arms a hrtimer when a vcpu is
> blocked (usually because it is waiting for an interrupt)
> while its timer is going to kick in the future.
>
> It is essential that this timer doesn't get adjusted, or the
> guest will end up being woken-up at the wrong time (NTP running
> on the host seems to confuse the hell out of some guests).
>
> In order to allow this, let's add CLOCK_MONOTONIC_RAW support
> to hrtimer (it is so far only supported for posix timers). It also
> has the (limited) benefit of fixing de0421d53bfb ("mac80211_hwsim:
> shuffle code to prepare for dynamic radios"), which already uses
> this functionnality without realizing wasn't implemented (just being
> lucky...).
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Tomasz Nowicki <tn@semihalf.com>
> Cc: Christoffer Dall <christoffer.dall@linaro.org>
> Link: http://lkml.kernel.org/r/1452879670-16133-2-git-send-email-marc.zyngier@arm.com
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
I'm afraid this patch is terminally broken - I managed to make this fall
over pretty easily (hint to self: __hrtimer_get_next_event needs some
serious thoughts to deal with MONOTONIC_RAW, and so does hrtimer_forward
at the very least).
Can you please drop (or revert):
a6e707d KVM: arm/arm64: timer: Switch to CLOCK_MONOTONIC_RAW
9006a01 hrtimer: Catch illegal clockids
9c80876 hrtimer: Add support for CLOCK_MONOTONIC_RAW
Thanks, and sorry for the noise.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-03-02 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 17:41 [PATCH 0/3] Enabling htimer support for CLOCK_MONOTONIC_RAW Marc Zyngier
2016-01-15 17:41 ` [PATCH 1/3] hrtimer: Add " Marc Zyngier
2016-01-27 11:42 ` [tip:timers/core] " tip-bot for Marc Zyngier
2016-03-02 11:30 ` Marc Zyngier [this message]
2016-03-03 10:27 ` [tip:timers/core] hrtimer: Revert CLOCK_MONOTONIC_RAW support tip-bot for Thomas Gleixner
2016-01-15 17:41 ` [PATCH 2/3] hrtimer: Catch illegal clockids Marc Zyngier
2016-01-27 11:43 ` [tip:timers/core] " tip-bot for Marc Zyngier
2017-02-18 10:01 ` [tip:timers/core] hrtimer: Catch invalid clockids again tip-bot for Marc Zyngier
2016-01-15 17:41 ` [PATCH 3/3] KVM: arm/arm64: timer: Switch to CLOCK_MONOTONIC_RAW Marc Zyngier
2016-01-27 11:43 ` [tip:timers/core] " tip-bot for Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D6CEF0.8060607@arm.com \
--to=marc.zyngier@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).