From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Daniel Bristot de Oliveira <bristot@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] kernel: sched: fix preempt_disable_ip recodring for preempt_disable()
Date: Thu, 3 Mar 2016 13:51:41 +0100 [thread overview]
Message-ID: <56D8335D.3050003@linutronix.de> (raw)
In-Reply-To: <56D0A364.5060203@redhat.com>
On 02/26/2016 08:11 PM, Daniel Bristot de Oliveira wrote:
>
>
> On 02/26/2016 10:54 AM, Sebastian Andrzej Siewior wrote:
>> - trace_preempt_off(CALLER_ADDR0, get_parent_ip(CALLER_ADDR1));
>> + trace_preempt_off(CALLER_ADDR0, get_lock_parent_ip());
>
> If !lock_functions(CALLER_ADDR0), the start/stop_critical_timing() will
> be called with parent_ip == ip.
>
> Hence, the following trace on start_critical_timing():
>
> __trace_function(tr, ip, parent_ip, flags, preempt_count());
>
> Will show the function calling itself.
>
> Is it a problem? am I missing something?
It might be that for !lock_functions() we get the same caller. But then
get_parent_ip() was not inlined (in my .o file) so ADDR1 in
get_parent_ip() should correspond to ADDR0 in the inline case.
> -- Daniel
Sebastian
next prev parent reply other threads:[~2016-03-03 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 15:20 [PATCH v2] kernel: sched: fix preempt_disable_ip recodring for preempt_disable() Sebastian Andrzej Siewior
2016-02-25 14:15 ` Steven Rostedt
2016-02-26 13:54 ` [PATCH v3] " Sebastian Andrzej Siewior
2016-02-26 19:11 ` Daniel Bristot de Oliveira
2016-03-03 12:51 ` Sebastian Andrzej Siewior [this message]
2016-02-29 11:19 ` [tip:sched/core] sched/debug: Fix preempt_disable_ip recording " tip-bot for Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8335D.3050003@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).