From: Peter Hurley <peter@hurleysoftware.com>
To: Aleksey Makarov <aleksey.makarov@linaro.org>,
Aleksey Makarov <amakarov.linux@gmail.com>,
linux-acpi@vger.kernel.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Leif Lindholm <leif.lindholm@linaro.org>,
Graeme Gregory <graeme.gregory@linaro.org>,
Al Stone <ahs3@redhat.com>,
Christopher Covington <cov@codeaurora.org>,
Yury Norov <ynorov@caviumnetworks.com>,
"Zheng, Lv" <lv.zheng@intel.com>
Subject: Re: [PATCH v4 0/4] ACPI: parse the SPCR table
Date: Fri, 4 Mar 2016 07:47:33 -0800 [thread overview]
Message-ID: <56D9AE15.106@hurleysoftware.com> (raw)
In-Reply-To: <56D9772B.5000402@linaro.org>
On 03/04/2016 03:53 AM, Aleksey Makarov wrote:
>
>
> On 03/03/2016 06:35 PM, Peter Hurley wrote:
>> On 03/03/2016 03:59 AM, Aleksey Makarov wrote:
>>>
>>>
>>> On 03/01/2016 06:31 PM, Peter Hurley wrote:
>>>> On 02/29/2016 04:02 AM, Aleksey Makarov wrote:
>>>>> 'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
>>>>> Console Redirection Table) [2] as a mandatory ACPI table that
>>>>> specifies the configuration of serial console.
>>>>>
>>>>> Introduce a new function acpi_console_check(). At the uart port
>>>>> registration, this function checks if the ACPI SPCR table specifies
>>>>> its argument of type struct uart_port to be a console
>>>>> and if so calls add_preferred_console().
>>>>
>>>> How will a user enable an earlycon on the same console as the SPCR
>>>> console if there is no DBG2 table?
>>>
>>> ...
>>> [ 0.000000] earlycon: pl11 at MMIO 0x0000000009000000 (options '')
>>> [ 0.000000] bootconsole [pl11] enabled
>>> ...
>>> [ 0.000000] Kernel command line: root=/dev/vda1 rw systemd.show_status=no acpi=force earlycon=pl011,0x9000000
>>> ...
>>> [ 0.318248] ACPI: SPCR: adding preferred console [ttyAMA0]
>>> [ 0.318736] ARMH0011:00: ttyAMA0 at MMIO 0x9000000 (irq = 5, base_baud = 0) is a SBSA
>>> [ 0.319502] console [ttyAMA0] enabled
>>> [ 0.319502] console [ttyAMA0] enabled
>>> [ 0.319933] bootconsole [pl11] disabled
>>> [ 0.319933] bootconsole [pl11] disabled
>>> ...
>>>
>>> Why?
>>
>> That's pretty disingenuous; via command line?
>>
>> By that measure, none of your patches are required because a user
>> can already start both console and earlycon without them.
>>
>> With the console location specified in the SPCR, earlycon should
>> be opt-in on the command-line simply with "earlycon" command-line
>> parameter.
>
> Yes. That's why we have SPCR *and* DBG2.
> DBG2 specifies where we should run earlycon.
>
>>>> How will a user enable an earlycon on the same console as the SPCR
>>>> console if there is no DBG2 table?
>
> In no way. You need DBG2 to run earlycon.
And that's an entirely arbitrary decision being made by you.
Which I think is unnecessarily limited.
> (If you don't want to specify it's address etc explicitly)
next prev parent reply other threads:[~2016-03-04 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 12:02 [PATCH v4 0/4] ACPI: parse the SPCR table Aleksey Makarov
2016-02-29 12:02 ` [PATCH v4 1/4] ACPI: parse SPCR and enable matching console Aleksey Makarov
2016-02-29 13:29 ` Andy Shevchenko
2016-02-29 13:47 ` Aleksey Makarov
2016-03-17 17:20 ` Timur Tabi
2016-02-29 12:02 ` [PATCH v4 2/4] ACPI: enable ACPI_SPCR_TABLE on ARM64 Aleksey Makarov
2016-03-01 15:27 ` Peter Hurley
2016-03-01 17:35 ` Aleksey Makarov
2016-03-17 17:20 ` Timur Tabi
2016-02-29 12:02 ` [PATCH v4 3/4] ACPI: add definitions of DBG2 subtypes Aleksey Makarov
2016-02-29 12:02 ` [PATCH v4 4/4] serial: pl011: use ACPI SPCR to setup 32-bit access Aleksey Makarov
2016-03-01 15:27 ` [PATCH v4 0/4] ACPI: parse the SPCR table Peter Hurley
2016-03-01 15:31 ` Peter Hurley
2016-03-03 11:59 ` Aleksey Makarov
2016-03-03 15:35 ` Peter Hurley
2016-03-04 11:53 ` Aleksey Makarov
2016-03-04 15:47 ` Peter Hurley [this message]
2016-03-11 16:25 ` Aleksey Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D9AE15.106@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=ahs3@redhat.com \
--cc=aleksey.makarov@linaro.org \
--cc=amakarov.linux@gmail.com \
--cc=cov@codeaurora.org \
--cc=graeme.gregory@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lv.zheng@intel.com \
--cc=rjw@rjwysocki.net \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).