From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754293AbcCHPhp (ORCPT ); Tue, 8 Mar 2016 10:37:45 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:57854 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbcCHPhi (ORCPT ); Tue, 8 Mar 2016 10:37:38 -0500 Subject: Re: [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver To: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, eric.auger@linaro.org References: <1457451209-21462-1-git-send-email-okaya@codeaurora.org> Cc: shankerd@codeaurora.org, vikrams@codeaurora.org, marc.zyngier@arm.com, mark.rutland@arm.com, devicetree@vger.kernel.org, vinod.koul@intel.com, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Baptiste Reynal , Alex Williamson , Dan Carpenter , Arnd Bergmann , linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: <56DEF1BE.8010701@codeaurora.org> Date: Tue, 8 Mar 2016 10:37:34 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457451209-21462-1-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/8/2016 10:33 AM, Sinan Kaya wrote: > + int rc = 0; > + I should have initialized this to -1. > + vdev->reset = vfio_platform_lookup_reset(vdev->compat, vdev->acpihid, > + &vdev->reset_module); > + if (vdev->reset) > + return 0; > + > + if (vdev->acpihid) > + rc = request_module("vfio-reset:%s", vdev->acpihid); > + > + if (rc && vdev->compat) > + rc = request_module("vfio-reset:%s", vdev->compat); > + -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project