From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935042AbcCJFNO (ORCPT ); Thu, 10 Mar 2016 00:13:14 -0500 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:32974 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbcCJFNK (ORCPT ); Thu, 10 Mar 2016 00:13:10 -0500 X-IBM-Helo: d23dlp02.au.ibm.com X-IBM-MailFrom: khandual@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Message-ID: <56E10227.2010608@linux.vnet.ibm.com> Date: Thu, 10 Mar 2016 10:42:07 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Aneesh Kumar K.V" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org CC: hughd@google.com, kirill@shutemov.name, n-horiguchi@ah.jp.nec.com, mgorman@techsingularity.net, akpm@linux-foundation.org Subject: Re: [RFC 6/9] powerpc/hugetlb: Enable ARCH_WANT_GENERAL_HUGETLB for BOOK3S 64K References: <1457525450-4262-1-git-send-email-khandual@linux.vnet.ibm.com> <1457525450-4262-6-git-send-email-khandual@linux.vnet.ibm.com> <8760wv1kzr.fsf@linux.vnet.ibm.com> In-Reply-To: <8760wv1kzr.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031005-0005-0000-0000-0000038847D6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2016 01:28 AM, Aneesh Kumar K.V wrote: > Anshuman Khandual writes: > >> > [ text/plain ] >> > This enables ARCH_WANT_GENERAL_HUGETLB for BOOK3S 64K in Kconfig. >> > It also implements a new function 'pte_huge' which is required by >> > function 'huge_pte_alloc' from generic VM. Existing BOOK3S 64K >> > specific functions 'huge_pte_alloc' and 'huge_pte_offset' (which >> > are no longer required) are removed with this change. >> > > You want this to be the last patch isn't it ? And you are mixing too Yeah, it should be the last one. > many things in this patch. Why not do this > > * book3s specific hash pte routines > * book3s add conditional based on GENERAL_HUGETLB > * Enable GENERAL_HUGETLB for 64k page size config which creates three separate patches ?