From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965631AbcCJKrp (ORCPT ); Thu, 10 Mar 2016 05:47:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46389 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965528AbcCJKrh (ORCPT ); Thu, 10 Mar 2016 05:47:37 -0500 Subject: Re: [PATCH 1/2] KVM: MMU: fix ept=0/pte.u=0/pte.w=0/CR0.WP=0/CR4.SMEP=1/EFER.NX=0 combo To: Xiao Guangrong , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1457437467-65707-1-git-send-email-pbonzini@redhat.com> <1457437467-65707-2-git-send-email-pbonzini@redhat.com> <56E12FF0.90202@linux.intel.com> Cc: stable@vger.kernel.org, Andy Lutomirski From: Paolo Bonzini Message-ID: <56E145F6.6030000@redhat.com> Date: Thu, 10 Mar 2016 11:01:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E12FF0.90202@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/03/2016 09:27, Xiao Guangrong wrote: > So it only hurts the box which has cpu_has_load_ia32_efer support otherwise > NX is inherited from kernel (kernel always sets NX if CPU supports it), > right? Yes, but I think !cpu_has_load_ia32_efer && SMEP does not exist. On the other hand it's really only when disabling ept, so it's a weird corner case that only happens during testing. Paolo