From: Ian Abbott <abbotti@mev.co.uk>
To: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
geliangtang@163.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] Staging: comedi: fix WARNING issue in s626.c
Date: Thu, 10 Mar 2016 10:42:20 +0000 [thread overview]
Message-ID: <56E14F8C.9040802@mev.co.uk> (raw)
In-Reply-To: <1457592730-14347-3-git-send-email-ravishankarkm32@gmail.com>
On 10/03/16 06:52, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a line over
> 80 characters issues found by the checkpatch.pl tool.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> ---
> drivers/staging/comedi/drivers/s626.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index 6ebae3a..2a5e650 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -2543,7 +2543,8 @@ static int s626_initialize(struct comedi_device *dev)
> for (i = 0; i < 2; i++) {
> writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
> s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
> - ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
> + ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
> + 0);
> if (ret)
> return ret;
> }
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-03-10 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 6:52 [PATCH 1/5] Staging: comedi: fix type issue in s626.c Ravishankar Karkala Mallikarjunayya
2016-03-10 6:52 ` [PATCH 2/5] Staging: comedi: fix WARNING " Ravishankar Karkala Mallikarjunayya
2016-03-10 10:42 ` Ian Abbott
2016-03-11 3:32 ` Greg KH
2016-03-10 6:52 ` [PATCH 3/5] " Ravishankar Karkala Mallikarjunayya
2016-03-10 10:42 ` Ian Abbott [this message]
2016-03-10 6:52 ` [PATCH 4/5] Staging: comedi: fix CHECK issue in ni_tio.c Ravishankar Karkala Mallikarjunayya
2016-03-10 10:42 ` Ian Abbott
2016-03-10 6:52 ` [PATCH 5/5] Staging: comedi: fix type " Ravishankar Karkala Mallikarjunayya
2016-03-10 10:42 ` Ian Abbott
2016-03-10 10:41 ` [PATCH 1/5] Staging: comedi: fix type issue in s626.c Ian Abbott
2016-03-11 3:32 ` Greg KH
2016-03-14 11:06 [PATCH 1/5] Staging: comedi: Fix type issues " Ravishankar Karkala Mallikarjunayya
2016-03-14 11:06 ` [PATCH 3/5] Staging: comedi: Fix WARNING issue " Ravishankar Karkala Mallikarjunayya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E14F8C.9040802@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=geliangtang@163.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankarkm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).