From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751554AbcCJNkl (ORCPT ); Thu, 10 Mar 2016 08:40:41 -0500 Received: from prv-mh.provo.novell.com ([137.65.248.74]:60674 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbcCJNkd convert rfc822-to-8bit (ORCPT ); Thu, 10 Mar 2016 08:40:33 -0500 Message-Id: <56E1876002000078000DB479@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 10 Mar 2016 06:40:32 -0700 From: "Jan Beulich" To: "Jianyu Zhan" Cc: , , , , , , , , , , , Subject: Re: [PATCH RFC] x86/traps: show unhandled signal for i386 in do_trap() References: <1457612398-4568-1-git-send-email-nasa4836@gmail.com> In-Reply-To: <1457612398-4568-1-git-send-email-nasa4836@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 10.03.16 at 13:19, wrote: > Commit abd4f7505baf ("x86: i386-show-unhandled-signals-v3") did turn on > the showing-unhandled-signal behaviour for i386 for some exception handlers, > but for no reason do_trap() is left out(my naive guess is because turning it > on > for do_trap() would be too noisy since do_trap() is shared by several > exceptions). > > And since the same commit make "show_unhandled_signals" a debug tunable(in > /proc/sys/debug/exception-trace), and x86 by default turning it on. So it > would be > strange for i386 users who turing it on manually and expect seeing the > unhandled signal > output in log, but nothing. > > This patch turns it on for i386 in do_trap(). > > Signed-off-by: Jianyu Zhan I've been carrying this patch for years, without ever being able to decide whether the distinction between 32-bit and 64-bit was intentional. Reviewed-by: Jan Beulich