From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbcCLF0i (ORCPT ); Sat, 12 Mar 2016 00:26:38 -0500 Received: from mail-pa0-f68.google.com ([209.85.220.68]:36817 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbcCLF0g (ORCPT ); Sat, 12 Mar 2016 00:26:36 -0500 Subject: Re: [PATCH 5/5] hwrng: exynos - Disable runtime PM on driver unbind To: Matt Mackall , Herbert Xu , Kukjin Kim , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1457682562-21219-1-git-send-email-k.kozlowski@samsung.com> <1457682562-21219-5-git-send-email-k.kozlowski@samsung.com> Cc: k.kozlowski.k@gmail.com From: Krzysztof Kozlowski Message-ID: <56E3A887.1000807@samsung.com> Date: Sat, 12 Mar 2016 14:26:31 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457682562-21219-5-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 11.03.2016 o 16:49, Krzysztof Kozlowski pisze: > Driver enabled runtime PM but did not revert this on removal. Re-binding > of a device triggered warning: > exynos-rng 10830400.rng: Unbalanced pm_runtime_enable! > > Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number generator") > Signed-off-by: Krzysztof Kozlowski > --- > drivers/char/hw_random/exynos-rng.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c > index 68c349bf66a0..cba1ff538c46 100644 > --- a/drivers/char/hw_random/exynos-rng.c > +++ b/drivers/char/hw_random/exynos-rng.c > @@ -154,6 +154,13 @@ static int exynos_rng_probe(struct platform_device *pdev) > return ret; > } > > +static int exynos_rng_remove(struct platform_device *pdev) > +{ > + pm_runtime_disable(&pdev->dev); > + This is not sufficient. pm_runtime_dont_use_autosuspend() is also necessary here. I will send a v2. BTW, no problem if it is too late for taking this for v4.6. If this patchset misses merge window I'll resend it later. Best regards, Krzysztof