From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933679AbcCNGJc (ORCPT ); Mon, 14 Mar 2016 02:09:32 -0400 Received: from mail-by2on0055.outbound.protection.outlook.com ([207.46.100.55]:32624 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932525AbcCNGJX (ORCPT ); Mon, 14 Mar 2016 02:09:23 -0400 Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PART1 RFC v2 09/10] svm: Do not intercept CR8 when enable AVIC To: Paolo Bonzini , , , , , References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1457124368-2025-10-git-send-email-Suravee.Suthikulpanit@amd.com> <56DDA0B7.4010709@redhat.com> CC: , , , From: Suravee Suthikulpanit Message-ID: <56E6557C.6080208@amd.com> Date: Mon, 14 Mar 2016 13:09:00 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56DDA0B7.4010709@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: KL1PR02CA0019.apcprd02.prod.outlook.com (25.165.15.29) To BLUPR12MB0434.namprd12.prod.outlook.com (25.162.92.14) X-MS-Office365-Filtering-Correlation-Id: 2b5eb681-47ff-4741-ef90-08d34bcf2eb9 X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;2:chlbFCxD2q799R0uzoScZwpIS/GJhtCEAUevKV916jzGHuLVqAkQtX0WXXOA8DqUi+t+rNWMUK5bjD062ZqSKpSfN4Wv/IGWsaELDAaKfOyGOUyVrNeblYnlJGt0ZZBbLk+Z5jTRUIy3Rhuasov3pbXMoVqE+qfHjnk4/LwvhJUfx6/yxcqSaZVeNuBXKrIk;3:LJodiBiYks4hc37+x9IkJA4ZuyApBeM6B2nnQ3Q3fGH4o0U/22GEtsX3zRuF9BhEwz8AHGTSPFXbnp22VUu98B0YN+TUeARegRI4RZS/gW4krW1ckts8eqByB6ows3p3;25:yHd5y+J8Qm3c/Jn/UcG3mBC3yXRotg4EKw//kBuAU6Q9l8aIszN1Qwh/ItCKuzKNUY5Fa0slCitkP8l2oxKbC5VeqV/hEwnUufdea3OvXG4q9EPaHSKg0NjxX7LI+HJDVRQNHm/5tpMsMd7PLuA9ouaMvvh+e5QOPhmSBaC9q4Jr1OopulverdYsXV5pfjOiqRXI8LH9eHdrpMVc8BO2k9Fg6x/Q3DoIZkup1MvBV6JvyfsvyQan2yXT4BuiPiiBOWvjq4Ky2ULv8ZNaJFzlJoQumMzizWANJ1uNArVm/XmxVlgcQ/cmi4TmFFAO/cgpjP073HzkW91o+4+l1lMkUg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0434; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;20:o9TIx2m63d0fI7D5YTavknLavX6KcAsO/1R+Ny8FASM0t8r+4ZfBO9Up3R5JzAx7hXUXrC4Hy5n3OWsaQ0TTA/FFVanpWLl3ebs1QPgljeGK83YLGOoNDYiDxKpaqf7A3v1LHxZ6hw2ohbieyDr6FCa3hQb54DZsTCiZFAduo1VuqExDPAo3KNEAGFPvF2WQK1WIQtPvcjtQQwgCTMpRJAgnyDAhy5dRwrlmza4X0wDoH15IbRB45tLpOxSbuehfT8r5jG+RYwHrAd4u7AMVbuM3m+G4gSDEZXHIcAD7B8Bbd359sCzkmvhIvq+VOlt0dL1stRdd/EetFHUd/ZMT13/iX7rBlpmtZXU28j16damK67RxxX7Gcpa6AFY44zfhIbMaE3cYybRA9h9VHcz0BMXaUPmLsz3hjsvNr/Lwc3ih+YxAqbPgNkGN8jn6BbKfQMcgVgqd+ic10BxhasLOBqTVcqSlAX6KD1l7whBLDIZrOvvmhXHFDmJ5hsk0MlSe;4:1HfFv9kyStXVyQA9o7r6ukOPcO2et1n2y7TCwFtTV9s/bPxHedEiDYdbRPn7qJTWHTHJi2JlKblz71XU4KkdhyxKFyZADtkfw1kIkjkcs2Lb+3PrcHRjvDl1kXHBGZFh4AmZIP8khDhgAIMd7V+KEGUMS4xNpSwVfkj4lOzsPCyR1PJUVw/C4hWL7qNlc7wnbAYXRmEnFEs2TyiLS1k1QKS8sWNCgRinZ4AV1dasf18hzyJ2ujNjVX6tfaejFFt2M+b4WufAuEsTra275qE5KRF0OBRxmMvdoRTtBE1+ktEpuEvdQt5l5OzO1H9GFEELlLUvByDvbiFqh8SUn3OnjaUuGbab/0/PyC3mRsz1ZTIAxO0ptKP2JRqvgqcc/6kA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BLUPR12MB0434;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0434; X-Forefront-PRVS: 0881A7A935 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(164054003)(24454002)(52034003)(377454003)(479174004)(189998001)(5001770100001)(4326007)(86362001)(50986999)(4001350100001)(117156001)(54356999)(1096002)(5008740100001)(3846002)(64126003)(6116002)(77096005)(36756003)(76176999)(586003)(80316001)(87266999)(59896002)(2906002)(83506001)(230700001)(33656002)(2950100001)(23746002)(66066001)(2201001)(92566002)(47776003)(50466002)(81166005)(65956001)(65806001)(42186005);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0434;H:[192.168.0.19];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR12MB0434;23:UmasHIlKwmcw+MlI2aLWRXgT93iyKIHFwzWRl?= =?Windows-1252?Q?v6Spdl2p0jmxdu7s1ov0hyBIhZVy1uWQ4Zwfkqo/E8cC/6v9z7uCcBjv?= =?Windows-1252?Q?KR1JEYrzOykwP5HK0hK1MOf5YeeiO3kz1JPd9bZkrm9FfSgIGCzJAsWV?= =?Windows-1252?Q?gIqrBu/NA2hMykmxsbZyAH99RfzVsb3RuNTnOsol/iv7A8MOZ60cpamt?= =?Windows-1252?Q?Za/PHsQIdn+Jc2kwTyhYjJnjiyFTRaOAHouqliBiyehBOI8ggRje0P7c?= =?Windows-1252?Q?x7DFaH2D8YbVpNaXgMy3gnPrPoTMzZZ02qNy3cZTN04SaFLX52ca9/3/?= =?Windows-1252?Q?Ym+Tr+KVjpUrpSyGuQqAQk0glcwiS0Zd2UyvXmp6vWOUlJn69C9Z5hjh?= =?Windows-1252?Q?t0vUInEMZExgvX6kSgjEmS4JlajM2GIWoptHXXFpixsLTLS1lcF2xGf+?= =?Windows-1252?Q?SHEOQgxRJjTfbe7YL6RZJ1q2k4M6KlyBAEP9+sJMfa1KTJ755j7HOY9U?= =?Windows-1252?Q?riDd2X+9L9y8lZnuKVgzOWO2ECsXON0eultkQ1rUhxmXvOuzqexJ2P17?= =?Windows-1252?Q?06SESdc70LKMzOtODkrhmFmHI450hfxdKGS6boH5QDoxSfMN8d8jyl8T?= =?Windows-1252?Q?l2XEq4T1Qqi4v91LvaY3qk483chxrMB82Xb/GlI7JM7r36PtW+iQRQrA?= =?Windows-1252?Q?EK2vUPJSPrUWUBRr6iCfmhk4U7g0XsEC5vDc/OnRnCexZ5DT3H56KzAz?= =?Windows-1252?Q?8y++AmgIx6A2XWOqS37c+tLC64J41PEmcG7JYyT8a+PmjNzhEC6kYK/e?= =?Windows-1252?Q?P9D13wy4cJT+IgQ4TDFsZnEntX5ucZ2z6yaA5FgvtOIK9Yiks7hOPVQe?= =?Windows-1252?Q?taGT7Zx9Q99YrnmJJLpTGi7WPgzH0DkZKaQuEPrEWQCYqsGBNn41uX/x?= =?Windows-1252?Q?0oh8WgAj3AL61Err5MpDXkJHEiYddKmzsMALx6PhvV3hYuiOmoPHH2zI?= =?Windows-1252?Q?pCAx+gi3qBqaC47DorSENYf7ADAnx8Qw95Z4ZhUlHpV40kKj0cgAsmnA?= =?Windows-1252?Q?CgG98PodM2u96bNtln4UwDY5RCKji5FUDpwuX9N++NM4g1OIKKHiye2k?= =?Windows-1252?Q?8WtVwUb0ZxE4JGn61fbU557opgcYva4fi50knD4qMYwzr1GwHuJp3Vlg?= =?Windows-1252?Q?KfHweYBzxAE3M2KixEnNU3yUB/Ywkw=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;5:3vTsK2LGZQg6jaxoXw3IfJbGrX6s4HRP91bzmjRR36h0G6ovb1A5aaohVVPMe4yiqBYvy2XLPYQygXjsLif4m9+hLTrJZsat0/bcuCMZpGmScyRVHsQ6hJ79tZoHJY/mHn+57EVMrzzTAT5o6O53rQ==;24:7xdeWQj69CS/CvwTTqej9VBRQBX3axRC6F3GKNjUzWhuk4dQclJ6UyGUJQIOFzxRomuLlT16BpRWdrhGF0ehD3WYZpIZdr4hghAInGiYjmY=;20:lS4FZnOEDont/mQbt56WwbwFDprtiUxpkpL5luRsA/r6fFnSjAgjxJSR+RyVN8gr08XjjwvPi3aac4gI63eOw8nE/Pkb3X6i2zCos8HAUL7z1w4TQePdWLMO8ULwdV8Jyf00QfhG3FeYp3heT7m6Vkv8OLuRGkG95HqivH4hTGCixhzopHCTlUy1OEcBKTkG+DRytbVIGvXzHWRUc2G4v/50KsHjUtlQS6M/48RpvRtu4kcMTJXQyofe9o3Tvvje X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2016 06:09:17.0652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0434 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 03/07/2016 10:39 PM, Paolo Bonzini wrote: >> + svm_x86_ops.update_cr8_intercept = NULL; >> > } else { >> > svm_x86_ops.deliver_posted_interrupt = NULL; >> > } >> >@@ -1116,7 +1119,8 @@ static void init_vmcb(struct vcpu_svm *svm) >> > set_cr_intercept(svm, INTERCEPT_CR0_WRITE); >> > set_cr_intercept(svm, INTERCEPT_CR3_WRITE); >> > set_cr_intercept(svm, INTERCEPT_CR4_WRITE); >> >- set_cr_intercept(svm, INTERCEPT_CR8_WRITE); >> >+ if (!avic) > Remember that AVIC enabled/disabled must be refreshed when the > .refresh_apicv_exec_ctrl callback is invoked, so it is not enough to use > the global variable. > > Paolo > Good point. I'll fix this. By the way, how can we enable APICv only in certain VM? Does Qemu/KVM have any specific flags that we can pass to enable/disable this? Thanks, Suravee