From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755466AbcCNIzF (ORCPT ); Mon, 14 Mar 2016 04:55:05 -0400 Received: from mail-bn1bon0058.outbound.protection.outlook.com ([157.56.111.58]:24423 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752138AbcCNIy6 (ORCPT ); Mon, 14 Mar 2016 04:54:58 -0400 Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC To: Paolo Bonzini , , , , , References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1457124368-2025-7-git-send-email-Suravee.Suthikulpanit@amd.com> <56DD9FF5.7010201@redhat.com> <56E64B39.5040609@amd.com> CC: , , , From: Suravee Suthikulpanit Message-ID: <56E67C49.6070807@amd.com> Date: Mon, 14 Mar 2016 15:54:33 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56E64B39.5040609@amd.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: PS1PR04CA0024.apcprd04.prod.outlook.com (25.169.60.34) To BY1PR12MB0440.namprd12.prod.outlook.com (25.162.147.141) X-MS-Office365-Filtering-Correlation-Id: 5a1c739f-0cb7-4aee-bf07-08d34be64f93 X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;2:n1JWn4cYiah5th8A3AfW83PF0FGy9tdD7FmmCFf6v9OuAyQXf5wuRqK+/cJO+IEE479FFss3JQMK89CtO77IfG0gUnrodOrY8eqbEMhNH+isB2xEbUWHoDJWAidFGxJBj0NGgga5xK6/5Qf1ukRgPvW4WL7Kmk8wwL926Pe+bWs72bfWGvYa/vVtIQjNZQqX;3:f1P7q1WKAJHmEWb9WvTsdX2XKTxQ+XGdy/Lf6KCTNYU7Sc1rhSOYZ2rU2Czhxp5uDU4mFxD6xy7vK1BTeOKyNk5mR8L4vaMo3T7qJSs5D+NcEjgYTxbrzyDme0feIB3w;25:fTU3N0NAOdrxjvPPS0OmTu9nvdArGHOiHFxxJ/4iYZRxp/iQSUPOXGxnAby4h5VYAhIwf6XHZys0m1Be2qJAOdojGSIIVJDNhh3G7koZ6Y16zBZhqwUug8tx8U9+QC4En59wZk6CVjU9/QMmcSAGyrilWCtoIJrB7MrOFn0w01dNzalGT8F7v1rFYGIEHvQwef52pyYUH3AIx0QrNPf2hLN9hXNTJ6yTlzZwwCraTokLYzZntyVPRML6TLPDIUiFJWHzlQKP5vcdn3LLsDPeW0DyqL2dBrMLURQnN2TngZELs2p7FA9NJiOPLuprfazMSHNktQ9h3RlpoeC5j3FpCg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;20:pWh34SK+CvxWczmGzwaPZLPkf7sZyGV7TTaT8J86yN1tdNwb9Wy2K5jxuJa1icjAN/fHSXwAbxdywusQ5ERANxSJvgKdXs2B8shIIPNQ8/nkfM0ko+Fw4vJubXJTZOTuHM3Eoq6EEvS1fzbsn1lYnCnmaen5dPKN9TuU6IO5820Xko6ELWtf476MRWrGD0+DNnAqClXQ9H1khc7f7uysOKDDdHKz0Jj6bU5vDPxrD4WlBYPgZyOpsDsOBRbGYAj8uqiIFA/DptOlmlaLRnqGQByEaNNnkL0UFh9qJzgyILjKSOx6kz5pWrzmynP39mcTJxbqcdt4UU0j3rQFtRq0AAVWP3ffr9nlwCivTb0eIvjqAi67tNp5FAlfWstz+5efUcgokONknnD5fO0+hxdhpvJBAUVoLDExmwls+gmpkKBi0IAmvD0E/nvl7Nc6BeglF6DNiXWPCDGpH6+4HXBDYRHFf2C7I+3sctsxdBNYoTJhC5Ezs06lcs6J6nHAkEjY;4:Le+hx1o/BuiHhPdfV8McOIs+0Gi+DJtddfKgsygBIh+iCKG68EFjoKaYwbm3Kc9Xl2nliHtSPbpEBaOGLcfDvn30N/CybTvry9LUImOAXdYyuNQ0DXtqP7KsLZBIIkVMfEWumSYekWCzt2N1Db0wzfw6CBrb/XfgZ0rgDDb8zVx70ThwoN5LRu2zYoxYT7wi9VeNxETlca0m2LjRdJc0zCFvYEunkNk+kJ5AIaD0bDnP2aMyYrr5aEkFnkqor3kNUYvw6EwknoNak4gtU9erkpAQHb28p/IRe8PqCjiJ6FpchG3wzDBOVs9DHbhGqRbMcNAhX3GmMwORxPvmHtChqGvcsMinsWl0j7xZ0fdyceVFSebHONzCfhHvbiaT6V+E X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BY1PR12MB0440;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-Forefront-PRVS: 0881A7A935 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(24454002)(479174004)(164054003)(377454003)(54356999)(42186005)(33656002)(5004730100002)(64126003)(77096005)(23746002)(2950100001)(1096002)(83506001)(92566002)(5001770100001)(2906002)(50466002)(47776003)(50986999)(86362001)(81166005)(93886004)(59896002)(586003)(66066001)(3846002)(2201001)(87266999)(5008740100001)(230700001)(117156001)(4326007)(189998001)(65806001)(65956001)(6116002)(36756003)(65816999)(76176999);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0440;H:[192.168.0.19];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR12MB0440;23:RDwCdk/zLX9poY0d9BEF2QThakTTEpxIIONZs?= =?Windows-1252?Q?gWVHJKDoyBf9baU0KldQHdySPpCrlR6HK+MR5eh/Nl+6zWyqJLuafyj4?= =?Windows-1252?Q?hOpMEEW+26V9Ie0DMWcIf8Zk+kTXW94csdNTkPaFC6O2GTuULTfmj/9c?= =?Windows-1252?Q?AWfvZw9QDm1u3/yw/ptQCkOTucLEP7FiCqd8o2z7Kqcyp5UxhAJVzsUS?= =?Windows-1252?Q?tB4b0kMQRwAckM3bXH2w/ZjRWO0Z3O7W9LJMUTWsMw6kxb7tincJedW+?= =?Windows-1252?Q?CbxytEOKVUnYjzd+r2+Lb2mZ68Kk86eU82+gsyylmui9TkJg3Hj8K2z7?= =?Windows-1252?Q?VpuEC2B/bZEAgkHuqMD0Fct9jTyKb/v82L/1HHwSS+QV3usm8u8/hXXD?= =?Windows-1252?Q?LPrWb9Aie0+N3bbLeIwBJweCgb8EqCi5A7RLK1zPqMhQ9Vv+6jGMebeX?= =?Windows-1252?Q?kxVR2aKO4xbouwylKSqDNBvP4cUDOo7P5r6vCCNnO4pJSHUnqgfiZV3Q?= =?Windows-1252?Q?FFZ/vioEN9FsAowNp+5XNnXg9NdPQnEd4IJRKNX4EJxOar7cWpCYBAPl?= =?Windows-1252?Q?Z5fakfoOzoQd2yaL3hAZwTzn1M9mCTVOslIANlLweRK+dMA8KC6lNM9b?= =?Windows-1252?Q?hoLKFJWC0hjKQFLDwAwmJuOCYyam0gbH92FsP0UbpNM3iOf4JL22YDJg?= =?Windows-1252?Q?8azpAIB/LlL3EyJ7944+fM7uN00hI0Cu7aaknLcjg9QNQoB0uj1DY6ic?= =?Windows-1252?Q?SRmfScDqjE8ccZQcLANTwPjdNhOUsuU7tBd5jCleGadHExYYM43TDfPt?= =?Windows-1252?Q?QBtM/Qsrs94Qmzl0/cuWf3qM/7RnWx52SaqUUReApTmSUVOcCuuRLWYd?= =?Windows-1252?Q?tOC1GAQ/aJF7xmGcCGto0wO76oIcEXA3c/vZ/GfdsMBuBb3u4sjqy6ep?= =?Windows-1252?Q?kVLeJdfw8oLdkuFmKljrk5U9AVOgpMSgWBBdi2VHKS8nPxChQcJG8fl3?= =?Windows-1252?Q?oo7Qpsw1uRcs+kcbeJdNkV0kqeknMNPHjVbnUltmrj1TYDpZe8eboz0P?= =?Windows-1252?Q?45oZm86MSoeX1uzNPKkqdLVutjoHZRAqONqCv4CLBmxSr0i1IDZYdrcy?= =?Windows-1252?Q?7rB+REmaUrIbqIZ3n1hg0H64KtGw2N94p3bgxTi3btt/dLXzX3Ns25rc?= =?Windows-1252?Q?V8H33wZXa2fJDRcDP9LBsk4YdenU/Q=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;5:ITV6tGAo7cl/gbRl6ylMDDXZW7OQCZu9dU79b4IujWM81bXk31xmLEszGdPF9jO5pMiItlFxTSUJ5XS4y0AjM3fuVswL8CjbYIuyLsWQxnkuhqUJYHlbxhiUyGIW3ncuTBE2WppwLu98RjhrzlO8Uw==;24:USf429W9yz81GMav3cXKRLvAlGy1yHenD0oq4Q3XTjzbROLWewcwcUvjoWeJg3gJI3o+ZWzCDCgGurD3QBWdUYyF3S28k2AuPnBZkWyeSNk=;20:M2X/AqqMIXTbpZ5t3UopJX1R+SOrqXPWPbXyXqRGhPpX+vjXGhGHEjsuXQNMGcEkuQDYcMfuSTfOfZQRFsb03JLZlRlutW38eZIdcnSHmtWcPRAY1acR4e/FijWUdhepr2d/Iwfwckm3b/FJz12K7hGTtklwXZBNobaiD/9h7bxCuN4M1uwV+/TmxQmLgM4vt6hVPRwO/pDa9lrUJGyjepfZ5WsFOB1AYKwE7hqcyIDeISJWNUf18AmbLOarCGvo X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2016 08:54:50.6983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0440 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Please ignore this. I should have read the whole thread before reply :( Sorry for spam. Suravee On 03/14/2016 12:25 PM, Suravee Suthikulpanit wrote: > > > On 03/07/2016 10:36 PM, Paolo Bonzini wrote: >> >> >> On 04/03/2016 21:46, Suravee Suthikulpanit wrote: >>> +static void svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec) >>> +{ >>> + struct vcpu_svm *svm = to_svm(vcpu); >>> + >>> + kvm_lapic_set_vector(vec, avic_get_bk_page_entry(svm, APIC_IRR)); >>> + >>> + if (vcpu->mode == IN_GUEST_MODE) { >>> + wrmsrl(SVM_AVIC_DOORBELL, >>> + __default_cpu_present_to_apicid(vcpu->cpu)); >>> + } else { >>> + kvm_vcpu_kick(vcpu); >>> + } >> >> You also need to add >> >> kvm_make_request(KVM_REQ_EVENT, vcpu); >> >> before the "if", similar to vmx_deliver_posted_interrupt. >> >> Paolo >> > > Actually, I should only need that just before the kvm_cpu_kick(vcpu) > isn't it. I don't think we need it in the case when sending doorbell. > > Thanks, > Suravee