From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965073AbcCNMZj (ORCPT ); Mon, 14 Mar 2016 08:25:39 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37877 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964849AbcCNMZe (ORCPT ); Mon, 14 Mar 2016 08:25:34 -0400 Subject: Re: [PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers To: Suravee Suthikulpanit , rkrcmar@redhat.com, joro@8bytes.org, bp@alien8.de, gleb@kernel.org, alex.williamson@redhat.com References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1457124368-2025-4-git-send-email-Suravee.Suthikulpanit@amd.com> <56DDA1CF.4080207@redhat.com> <56E66B43.1000802@amd.com> Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com From: Paolo Bonzini Message-ID: <56E6ADB4.9040700@redhat.com> Date: Mon, 14 Mar 2016 13:25:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E66B43.1000802@amd.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/03/2016 08:41, Suravee Suthikulpanit wrote: > Any particular reason why you do not recommend the use of bit field? 1) The current coding style is generally not using bitfields 2) Having to review patches that change working code unrelated to AVIC 3) Most of the fields are not even used when AVIC is enabled, so the benefit of the conversion is small. Paolo