From: Jiri Slaby <jslaby@suse.cz>
To: Luis Henriques <luis.henriques@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Christian König" <christian.koenig@amd.com>,
andersen@codepoet.org,
linux-kernel <linux-kernel@vger.kernel.org>,
"Nicolai Hähnle" <nicolai.haehnle@amd.com>,
stable@vger.kernel.org, "Sasha Levin" <sasha.levin@oracle.com>,
"Kamal Mostafa" <kamal@canonical.com>
Subject: Re: Oops in 3.10.99 -- NULL pointer dereference in radeon_fence_ref
Date: Mon, 14 Mar 2016 13:33:18 +0100 [thread overview]
Message-ID: <56E6AF8E.4090001@suse.cz> (raw)
In-Reply-To: <20160309135612.GA20283@charon.olymp>
On 03/09/2016, 02:56 PM, Luis Henriques wrote:
> On Mon, Mar 07, 2016 at 02:58:51PM -0800, Greg Kroah-Hartman wrote:
>> On Mon, Mar 07, 2016 at 10:06:47PM +0100, Christian König wrote:
>>> Am 07.03.2016 um 21:46 schrieb Greg Kroah-Hartman:
>>>> On Sun, Mar 06, 2016 at 07:50:14PM -0700, Erik Andersen wrote:
>>>>> The following patch to radeon_sa_bo_new that
>>>>> went into 3.10.99
>>>>>
>>>>> commit 8d5e1e5af0c667545c202e8f4051f77aa3bf31b7
>>>>> Author: Nicolai Hähnle <nicolai.haehnle@amd.com>
>>>>> Date: Fri Feb 5 14:35:53 2016 -0500
>>>>> drm/radeon: hold reference to fences in radeon_sa_bo_new
>>>>> commit f6ff4f67cdf8455d0a4226eeeaf5af17c37d05eb upstream.
>>>>>
>>>>> is triggering an Oops for me right when xscreensaver
>>>>> first began doing 3D stuff. After reverting this
>>>>> patch, xscreensaver has been happily running 3D stuff.
>>>>>
>>>>> Mar 6 18:00:43 sage kernel: BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
>>>>> Mar 6 18:00:43 sage kernel: IP: [<ffffffffa010345d>] radeon_fence_ref+0xd/0x50 [radeon]
>>>>> Mar 6 18:00:43 sage kernel: PGD 799e1d067 PUD 819186067 PMD 0
>>>>> Mar 6 18:00:43 sage kernel: Oops: 0002 [#1] SMP
>>>>>
>>>>> Mar 6 18:00:43 sage kernel: Stack:
>>>>> Mar 6 18:00:43 sage kernel: ffffffffa01607ec ffff88108a4e8000 ffff88108a4e8000 ffff880888fbc000
>>>>> Mar 6 18:00:43 sage kernel: ffff880ecbf11c78 0000fe2001000006 0000000000000000 0020000000000100
>>>>> Mar 6 18:00:43 sage kernel: 00000000000d1200 ffff880ecbf11c14 0000000000000000 0000000000000000
>>>>> Mar 6 18:00:43 sage kernel: Call Trace:
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffffa01607ec>] ? radeon_sa_bo_new+0x2ac/0x4f0 [radeon]
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffffa005fc9d>] ? ttm_eu_list_ref_sub+0x3d/0x60 [ttm]
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffffa0117c49>] radeon_ib_get+0x39/0x110 [radeon]
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffffa011a4ea>] radeon_cs_ioctl+0x69a/0xa70 [radeon]
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffffa008e2d2>] drm_ioctl+0x512/0x650 [drm]
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffff810a46e1>] ? do_futex+0x111/0xc30
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffff81182a45>] do_vfs_ioctl+0x305/0x520
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffff8107cd39>] ? vtime_account_user+0x69/0x80
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffff81182ce1>] SyS_ioctl+0x81/0xa0
>>>>> Mar 6 18:00:43 sage kernel: [<ffffffff8178210f>] tracesys+0xe1/0xe6
>>>>>
>>>>> $ lspci | grep VGA
>>>>> 03:00.0 VGA compatible controller: Advanced Micro Devices, Inc.
>>>>> [AMD/ATI] Redwood XT [Radeon HD 5670/5690/5730]
>>>> Next time, please cc: the people responsible for that patch as well...
>>>>
>>>> I can revert it, but maybe something else is going on here? Do you have
>>>> this same problem on 3.14, and 4.5-rc7?
>>>
>>> Hi Greg,
>>>
>>> yes that's an already known issue. Feel free to revert that one for now.
>>>
>>> I got it on my TODO list to provide a fixed patch for older kernel, but that
>>> can take a while.
>>>
>>> For the background Nicolais patch is correct, but assumes that
>>> radeon_fence_unref() can safely take NULL as the fence which is not the case
>>> for older kernels.
>>
>> Ok, thanks, now reverted.
>>
>
> And looks like a few more kernels may be affected as well. I'll
> revert it from 3.16 kernel, and I'm adding Kamal, Sasha and Jiri to
> the CC list.
Reverted from 3.12. Thanks!
--
js
suse labs
prev parent reply other threads:[~2016-03-14 12:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 2:50 Oops in 3.10.99 -- NULL pointer dereference in radeon_fence_ref Erik Andersen
2016-03-07 20:46 ` Greg Kroah-Hartman
2016-03-07 21:06 ` Christian König
2016-03-07 22:58 ` Greg Kroah-Hartman
2016-03-09 13:56 ` Luis Henriques
2016-03-09 16:31 ` Nicolai Hähnle
2016-03-09 16:38 ` Greg Kroah-Hartman
2016-03-14 12:33 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E6AF8E.4090001@suse.cz \
--to=jslaby@suse.cz \
--cc=andersen@codepoet.org \
--cc=christian.koenig@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=kamal@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.henriques@canonical.com \
--cc=nicolai.haehnle@amd.com \
--cc=sasha.levin@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).