From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934601AbcCNP0f (ORCPT ); Mon, 14 Mar 2016 11:26:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:39291 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934381AbcCNP0b (ORCPT ); Mon, 14 Mar 2016 11:26:31 -0400 Subject: Re: [PATCH 2/3] lpfc: fix misleading indentation To: Arnd Bergmann References: <1457965789-3373916-1-git-send-email-arnd@arndb.de> <1457965789-3373916-3-git-send-email-arnd@arndb.de> <56E6D69E.1050008@suse.de> <13330994.pIJCLN5xX1@wuerfel> Cc: martin.petersen@oracle.com, James.Bottomley@hansenpartnership.com, James Smart , Dick Kennedy , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke , Sebastian Herbszt From: Hannes Reinecke Message-ID: <56E6D824.3080809@suse.de> Date: Mon, 14 Mar 2016 16:26:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <13330994.pIJCLN5xX1@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2016 04:25 PM, Arnd Bergmann wrote: > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: >>> vports = lpfc_create_vport_work_array(phba); >>> - if (vports != NULL) >>> + if (vports != NULL) { >>> for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) { >>> struct Scsi_Host *shost; >>> shost = lpfc_shost_from_vport(vports[i]); >>> @@ -2877,7 +2877,8 @@ lpfc_online(struct lpfc_hba *phba) >>> } >>> spin_unlock_irq(shost->host_lock); >>> } >>> - lpfc_destroy_vport_work_array(phba, vports); >>> + } >>> + lpfc_destroy_vport_work_array(phba, vports); >>> >>> lpfc_unblock_mgmt_io(phba); >>> return 0; >>> >> Nope. >> >> vports is only valid from within the indentation block, so it should >> be moved into it. >> >> > > Well, every other user of the function also looks like > > vports = lpfc_create_vport_work_array(phba); > if (vports != NULL) { > do_something(vports); > } > lpfc_destroy_vport_work_array(phba, vports); > > and lpfc_destroy_vport_work_array() does nothing if its argument is NULL. > > I still think my patch is the correct fix for the warning. > Okay, good point. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)