From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754429AbcCOAjz (ORCPT ); Mon, 14 Mar 2016 20:39:55 -0400 Received: from mail-bn1bon0097.outbound.protection.outlook.com ([157.56.111.97]:47936 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753280AbcCOAjw (ORCPT ); Mon, 14 Mar 2016 20:39:52 -0400 Authentication-Results: lists.linux-foundation.org; dkim=none (message not signed) header.d=none;lists.linux-foundation.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header To: Peter Zijlstra , Borislav Petkov , References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> <56E64B68.3090505@amd.com> <20160314095856.GL6344@twins.programming.kicks-ass.net> <56E6BE7E.8010807@amd.com> <20160314141945.GE15800@pd.tnic> <20160314163913.GO6344@twins.programming.kicks-ass.net> CC: , , , , , , From: Suravee Suthikulpanit Message-ID: <56E759C3.5040707@amd.com> Date: Tue, 15 Mar 2016 07:39:31 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160314163913.GO6344@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [58.10.104.205] X-ClientProxiedBy: SIXPR04CA0028.apcprd04.prod.outlook.com (25.162.171.18) To BY1PR12MB0440.namprd12.prod.outlook.com (25.162.147.141) X-MS-Office365-Filtering-Correlation-Id: 43f4cd9c-aeea-4e04-938c-08d34c6a509c X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;2:FBMoD7678EpGdRD2gB/5bWUx/UmaYFIVswOxrPEQ33Jd9JmBffy5wRBMRgl9wkcevonsxaST2VT6ONbplCnGK2fSR2QpTgAXR4zAXKOLCryCwgXXKHlssfGjyeJrbKubQZ4RHw9wGr2CcJiQIjtgcAwh5G926BqMKbJlkgLE3Qnp2pekWt+ecqZF3c4m5Kk/;3:MauIXpkyAxb7O3Enqkjsq1qfkZv1x/vhEfKO2xaKQcbaMXS5132befRNFFmrHdMX/Q0BD3pepAf2VLfHT5Ubp3v0MWpHbvlACfvKH42qtnE9obUk3lD4FLrUE8jf/pZi;25:bvWDqId8lIHQAs34M0k8LfG08ZtiTyQ7pwV1B/QqedATsLfa7HYEu8bNjoD3oqmflWU63i4+YhTM7sqBQ9WooSZxvMjzxvVKV070ERWYjfmw4B94+/dz+b7iACfO96/QBS/+izcF58jeWf/iK62VmVlgGAP8JbfzIHnhypm17x6stPwRZEvorXUtDXXDU3XtOOWNSp1W3UO+R9T3gJ6aCT/Ptfarptc9Apwh/Xg1H/6e18CbfD9uJzz8fC1HOHNWtUvMpzK0sQmm0wau1xgYS/Vvf0WJ1HukUHNLJsB+HkWJd/Hb6mAP5gvAjRSHkIqPy+lLdR9akfCT59E4lgQsUA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;20:Wcp+gkIq9ntLrcz/z2yTItIjeNzfgU8+OloYPOFT+QNU3ckcbYllPCJzhAophetOEBb3NrxpQnUm8SCJjaJv/2f2tBPEidqRNyoSIOw3rM2E6FQGAqFhcHFdnCGknLUsWhVbVQtS12Nk9goLQel/nUGioMotP0Y8l2sl2Cuw9WK9/gtF2GDRHosOqhbb9lEK5gOfx+wNv5QwHyuneiGenwmheVYl5fYnwj+Tatt3YG+sVY/1bnkVcZnLbe1jAb+zV8NhHsPMDTPDsAvVxFwk0x0EerslhCc+1AkBXSrCGsLja1Km8QA9UFF0Z/uh32510nXcqkMeZde2ROOs+EHm2e/vcQcTAZDh+4mwZ03u23viw7cj4RayvgQsQyhDrJ0vvb0pzwWjXdfebQmQwAWUp1yC/nEIQth89+GUluEXc/hMbceUQGoRQ6wWJDUPHmW18j3aVv42b2ImbefCnF/6/uRAg2CbU4nVPuiVO0QMbYKzgI2eA96BiSZrHtl7y3O0;4:ZEW2gSC/88wZGNHiT6+xJ1t3y7B+lEsMo2fduDWIIr2Z/3to+y524NlKPbe4ydsmAvsOK03RudZK4tH1Y8epWAAfgwPR1iTZKv2RBXEy4ZiCsqcCCBVyLU2OvvB8Acn6UFQxgCXNNbPfLHYxpdcNi5vslrXaWLj1OsNbMfbeiqhGlrTg+BiYpZzhHUSrXSr0Bs99OO4Cjo+HMSPzTvSHrn44HyW1qszenYOJQGCDO5mAeSr2Rhbusqo2khZbJ3CqDt/5wBqTmRmqyho8hVEOuJUYbqkRBbyhlK8grwYrUJII/TNpj40R+g/RITJXNipidlvdENRyVf+AWBgYZkCqClFzZ00rCEbs9FZxg+NZQ3I25eAHpGVz675yaf1YxfwI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BY1PR12MB0440;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-Forefront-PRVS: 08828D20BC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(979002)(6009001)(164054003)(24454002)(479174004)(5008740100001)(80316001)(87266999)(66066001)(230700001)(59896002)(81166005)(93886004)(86362001)(47776003)(586003)(4001350100001)(3846002)(50986999)(6116002)(65806001)(76176999)(189998001)(36756003)(65816999)(4326007)(65956001)(64126003)(5004730100002)(54356999)(23746002)(42186005)(77096005)(33656002)(106356001)(92566002)(5001770100001)(2906002)(50466002)(1096002)(2950100001)(83506001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0440;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR12MB0440;23:q6fNr6IV7VTNqnR7UfXOmyESfF39caP4J49R4?= =?Windows-1252?Q?io3GpNSIVi6pfIhIf0fSL2X+07asrUXSlT+35vPVEG6Q83WFRyGW0rUp?= =?Windows-1252?Q?ifS93G24HlmNlAYS9JoK2R4SSfT2YIq7kqvBGP8t3wwUE8cayDJTeHiv?= =?Windows-1252?Q?yDVtY0hBVcg26VzyxV7Tz5RtoGBcS0/SDnc9O2a2RPV9QKz6wpKrsfgE?= =?Windows-1252?Q?9SfSf+xeWv6FOH4SLN0mRkOROliHW3LnVj8QKYnY6knr1PIkyg50M6jj?= =?Windows-1252?Q?D+xxOv55UpDGjjHNr9PpB4blbp0tnKItjjFDK86JQzs2E6ZfXhMt9Cc3?= =?Windows-1252?Q?tmCn1GrMwJK7LazHHhp2+kmX5nK21Py0WfYOoqDDMsbhq2eZ3Lg/bf/E?= =?Windows-1252?Q?Cbw1kKBYvAQ/TqNvDNi//tkfrnAOoLbDqeJ2LN05wYNYWCke3qERZPLz?= =?Windows-1252?Q?sgTH2TXTiYu34dmdHoPBMZFDv6+EGqYPKWd5lkov8m/tyv61gnbeNB7l?= =?Windows-1252?Q?5BwEDShdT8zZk1mrruHud/JiGY42pp0G5KqIwD96m3n+Q8AyLqUEu98n?= =?Windows-1252?Q?oV/ATXuZx4HWtugsZwwASMoWBt0CcpqW+SenEGunJe7UUkLU+LTsBSov?= =?Windows-1252?Q?UpZLiIHyDX6kW8NPFKt5mCJgK2d2NROp/lZH7ayOjSDATGhAKcBajKsz?= =?Windows-1252?Q?e1i3SZDHWxDT8IumZ/LREvFX/s41cWwlPakIfyWxfPVuV/Tz6Zcg1XyX?= =?Windows-1252?Q?mLq/HzWbo71aRt7uSxVi/eYPBhjKRrAX1NuKRKWsUKJpb5bc/HTfm5u+?= =?Windows-1252?Q?3sU+lcmJA4aCCDQmZpV92kHOIBnhyZBWJuvadYANj9dgjHSEeOGxKyKQ?= =?Windows-1252?Q?gQNEmbO9deGq46wNK5Rp1JM4+JgxHTjM5XiWEkXduV4TPD5LqyjmXXFo?= =?Windows-1252?Q?FNfUdrqc7K2qQXWsa0g6r6cNrZhXoxXkGwR0h4ZFbIEVgjw4M6aD+Zn8?= =?Windows-1252?Q?33MWRm5DZpjGwRctEaa3Ep1UwXAkdn8R5RutfWqW9dwpCzIdAw990QKb?= =?Windows-1252?Q?HKaAiLA5ZZBwsapYG3ugs3l9rpp87sRtDt4W3VZgPTvS2xKEVMME/H6N?= =?Windows-1252?Q?jlA0NJEQaO55g3kSEE6BVDtJUy/IciYITeAPzNNv9AJQBXj3tcZu4GcR?= =?Windows-1252?Q?N0yKwCUr+37cywDJ55e98XIlsIMshBw4fiyDG+rTUeyazpgoV9IyZFzR?= =?Windows-1252?Q?beDp/I3y8dPEM8PtoduAgVVEvnS1aIb29QLQxzDzTIiRqxgz+JRDYoX9?= =?Windows-1252?Q?nAy?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;5:gV55raxMj+e2OsSwuUMySnF1OJ2T8fT4VNmZmcBekrKyNag3HcPT/fTmc6UX0TZUGZ3hlKLl0ylbqWORwO3A/rn2CGZVCl/DHyH2EMw4CT8T6I7z50ZTTuKVjZipApqqsnGlKY3LU407uOSEpVI2jg==;24:yPMFz0lU73RyVMgscN9SwcHevUnWSdQbmxt6k7MDqfBmQ5BSKp7xeeRO7pGi/7Mjn1scckTQBs+eCoi9xd5tfYlg638LO6dLrpnqmT70aOg=;20:bYWPiDiwaGK31I/RRbJbysRukqmZUs1Hh63oWsWbMqS/rjkjcwuwzIsMeIAoD0T6N9hc8umsPRnB32aDeZc8GSdrmL+sBT3DLCp05UjzEYTY4xGx3MdVC3oIZAUIH3enZ0WDEgyXTWsSsFdVx0u+cWYKrsDYjjOKqC0axVQYfrqX5cnCGySO60OFsVjXXIROFl4cn/4y7HMZiWRHrM+zAljWgu0htKAf4SKlweeqFJic1UpKQqdf/nIfqFbKxXPm SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2016 00:39:46.5960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0440 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter/Boris/Joerg, On 3/14/16 23:39, Peter Zijlstra wrote: > On Mon, Mar 14, 2016 at 03:19:45PM +0100, Borislav Petkov wrote: >> On Mon, Mar 14, 2016 at 08:37:02PM +0700, Suravee Suthikulpanit wrote: >>> Basically, we are trying to match the current Perf hierarchy for AMD IOMMU >>> (arch/x86/events/amd/iommu.c). I can put it into >>> arch/x86/include/asm/perf_amd_iommu.h. What would you prefer? >> >> Yeah, I was going to say the same thing - match the hierarchy so that >> there are no confusions between paths. Makes sense to me. > > Well there's still the 'perf' vs' events' thing, but also what other > files did you want to put there? > > For now I think I prefer a filename without extra directories; we can > always move files about if there's more use later. > > Also, since its being used by both events/amd/iommu.c and > drivers/iommu/amd_iommu.c you can also chose a name in the latter > namespace. > Actually, I also found that there is currently the include/linux/amd-iommu.h, which contains extern function declarations defined in drivers/iommu/amd_iommu_init.c and drivers/iommu/amd_iommu_v2.c. What if I just merge the newly introduced arch/x86/include/perf/amd/iommu.h into the include/linux/amd-iommu.h? I do not see the point of having to separate things out into two files. Joerg, since you were maintaining that file, do you have any objection? Thanks, Suravee