From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755105AbcCPLM2 (ORCPT ); Wed, 16 Mar 2016 07:12:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59746 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966610AbcCPLMY (ORCPT ); Wed, 16 Mar 2016 07:12:24 -0400 Subject: Re: [PART1 RFC v2 05/10] KVM: x86: Detect and Initialize AVIC support To: Suravee Suthikulpanit , rkrcmar@redhat.com, joro@8bytes.org, bp@alien8.de, gleb@kernel.org, alex.williamson@redhat.com References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1457124368-2025-6-git-send-email-Suravee.Suthikulpanit@amd.com> <56DDAF2D.3060703@redhat.com> <56E841CC.4090806@amd.com> <56E844E2.6090507@redhat.com> <56E8FB8B.7050700@amd.com> <56E90943.3060100@redhat.com> <56E91793.90904@amd.com> Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com From: Paolo Bonzini Message-ID: <56E93F91.5080807@redhat.com> Date: Wed, 16 Mar 2016 12:12:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E91793.90904@amd.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/03/2016 09:21, Suravee Suthikulpanit wrote: >> Strictly speaking the address of the 0xFEE00000 translation is >> unnecessary and it could be all zeroes, but I suggest that you set up an >> APIC access page like Intel does (4k only), using the special memslot. >> The AVIC backing page can then point to lapic->regs. > > Ahh... you are right, this works also. Thanks for the pointer. I'm > fixing this, doing some more testing, and cleaning up the code. This has > simplify the init logic quite a bit. Awesome, thanks. Paolo