From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966705AbcCPNwi (ORCPT ); Wed, 16 Mar 2016 09:52:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:58740 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964787AbcCPNwg (ORCPT ); Wed, 16 Mar 2016 09:52:36 -0400 Subject: Re: [PATCH v3 6/8] arm64: dts: rockchip: Add power key to GeekBox To: Julien Chauveau References: <1457294038-14243-1-git-send-email-afaerber@suse.de> <1457294038-14243-7-git-send-email-afaerber@suse.de> <6BD669A2-4971-4702-8742-77C9994AA4E9@gmail.com> <56E93C43.1060500@suse.de> Cc: Mark Rutland , devicetree , Heiko Stuebner , Pawel Moll , Ian Campbell , Catalin Marinas , Will Deacon , LKML , linux-rockchip , Rob Herring , Kumar Gala , LAKML From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <56E96521.40304@suse.de> Date: Wed, 16 Mar 2016 14:52:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E93C43.1060500@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 16.03.2016 um 11:58 schrieb Andreas Färber: > Am 11.03.2016 um 00:04 schrieb Julien Chauveau: >>> @@ -70,6 +71,19 @@ >>> pinctrl-0 = <&ir_int>; >>> }; >>> >>> + keys: gpio-keys { [...] >>> + compatible = "gpio-keys"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pwr_key>; >>> + >>> + button@0 { [...] >>> + gpios = <&gpio0 2 GPIO_ACTIVE_LOW>; >>> + label = "GPIO Power"; >>> + linux,code = ; >> >> According to Documentation/input/event-codes.txt, there’s a special event type for the power button. >> Should we use it here for that purpose? >> >> linux,input-type = > > The other RK3368 boards don't, so unless you can give a justification to > convert all boards yet again and test how this makes a difference, I'd > rather not do experiments here but leave that to someone who knows what > they're doing and then do it consistently... For the record here's an evtest log: geekbox:~ # evtest No device specified, trying to scan all of /dev/input/event* Available devices: /dev/input/event0: gpio_ir_recv /dev/input/event1: MCE IR Keyboard/Mouse (gpio-rc-recv) /dev/input/event2: gpio-keys Select the device event number [0-2]: 2 Input driver version is 1.0.1 Input device ID: bus 0x19 vendor 0x1 product 0x1 version 0x100 Input device name: "gpio-keys" Supported events: Event type 0 (EV_SYN) Event type 1 (EV_KEY) Event code 116 (KEY_POWER) Properties: Testing ... (interrupt to exit) Event: time 1458136008.850429, type 1 (EV_KEY), code 116 (KEY_POWER), value 1 Event: time 1458136008.850429, -------------- SYN_REPORT ------------ systemd then goes on to shut down the system cleanly. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)