From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753728AbcCQD6e (ORCPT ); Wed, 16 Mar 2016 23:58:34 -0400 Received: from mail-bl2on0100.outbound.protection.outlook.com ([65.55.169.100]:45728 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752276AbcCQD6b (ORCPT ); Wed, 16 Mar 2016 23:58:31 -0400 Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PART1 RFC v2 07/10] svm: Add VMEXIT handlers for AVIC To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1457124368-2025-8-git-send-email-Suravee.Suthikulpanit@amd.com> <20160309205512.GD19459@potion.brq.redhat.com> CC: , , , , , , , , From: Suravee Suthikulpanit Message-ID: <56EA2B4F.7050201@amd.com> Date: Thu, 17 Mar 2016 10:58:07 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160309205512.GD19459@potion.brq.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: SIXPR04CA0018.apcprd04.prod.outlook.com (10.141.119.18) To BY1PR12MB0437.namprd12.prod.outlook.com (25.162.147.139) X-MS-Office365-Filtering-Correlation-Id: f62b5a6d-15a9-4b94-a079-08d34e1865a4 X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;2:sVqbSglQnS3bAR2Q0CtnWWYurDqpvKJlD9XoNAoGoAuzn9V5/tKR5KyFSGy6pUtmRkNqLdSSYiYu1tZJfua1qyHIZmivtz3LfBrC/pK4nqLSNq34MTKOLprEAKE96eOQ8CChysWwBuoidrAQ1v+Nu1XGlkkUiRbUIs3XOLQD5cepK+d1OfGjnz0l3K70pdBC;3:/canRf+lpvrIFE4jrPXnbdNVYFKdt2avWi6V8FPjIKNr/r0+TV7/B+82mmAXKu6Z9zPCdLkvqevV01KvRT3upGLqzkzZYxq3hyHw7qiJcitSP6SqV1Qik52ORcNp8OP9;25:bUGOcMFuBqUn1zvD6/DsqfAjAnqTv+f3ygSpoPToLSg2O02Jbcm9RUZwslzunthfoocLZfzWtUB3gah1t0gxsHZ5NnfTa0PuZZokkF9O6w1CMJ7uldVizman03KNeAtrLnjM1QmY2ffSNrq0IsLc/CZ0Gx7YDe24rwSg1teepdM5gJsZW3i0q5GX0cilNwdYhokImXX8ccyiqDc4fIWFyLqsQzLH7w6IL/zZiGp9YFgarwL30dDJShkR9cQMrIZBtdtMkmDApROJ9Odo1IpCdpR3uDE0rGIQCpKgcy3716m/smUR4F06z1tTq8g1Hvg6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0437; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;20:4OrV0tLwz7/gI31v69UDrqCW3IkF04t65jnLZvVjQ4YhdiuvoVbnJLQab+GLVswDJxTEAOkt4B5x/A55SteUZCyIohmWdIJsULdlssOg7qp54+3JDqCK3LwmZtQqr6AhC+GWp4g2gAhgl3YajQ4fMCpr0Mv6SMzTE+9PnuGPkyOqhiA4h0GNAKWLEEPumBBjDPplJnecj9+Jdqn/BuSYi98ABPtSvhwIbrxHN31QzwApHTFzZpCh9PfB8BhrMbMD6iKhX7ZrA6tjoOkp4Y4zrWE+K5Oyi3Ep/t9MQIJGSi+WGefjEuJsubJZenMYd/EqjnFT4u6KHlF2nDK6NjxhSokRnj2XeF2NiwoXMVQ8KAjV+G84DCfCz4XmRwWKC6Rmu9Ih8aoFKs2DXZieqLN0/HMHSD7HFgNWhTw/HhkN8ajCHnvQhkXEAYKv2jklCQwZedbhfPKbcF8uvDOnQ+EzSgi3w8rP8eI0sMg3elshRfRzlIYNDanXn3EAeTtlupra;4:dn1Us0B6N52A2VdYa17Rf8+2M/4XjAxtJSWP5aRaF/toNk3QM1mYDnMrjOiV4ANRzMt2bMBVaFvea8QKK+qvmnKj3VzCzC1TOf29wF77vRbIMpj2FS9lpDIzwfna8XUZJrCzuhuSniHAr4Emjc3uxOINSW1Qr3oUwyVraKY4YrQPneuyvSYfpkX2nbNm0rnvkC1u0JctGIfnU1PxTABAB/GSJmp57FmwxrND+0xqnTcyKJrDTT5jdffhaIl1uElV3DD/GzOXPRGdWakaK4GVCB5ySqBGhxDitnfA7XfR4E7t9KSDoqk9+xlc5inOgFlC833lAadxAMjN2fE1BjJC/07+uWQhr8vgLKMM7vd1A4VH0dwE3ZpmH5oh/n1XkEse X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BY1PR12MB0437;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0437; X-Forefront-PRVS: 0884AAA693 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(377454003)(479174004)(24454002)(164054003)(189998001)(92566002)(50466002)(33656002)(65956001)(86362001)(110136002)(117156001)(5008740100001)(77096005)(59896002)(64126003)(2950100001)(23676002)(47776003)(19580395003)(36756003)(66066001)(586003)(4326007)(76176999)(54356999)(87266999)(50986999)(65806001)(1096002)(42186005)(2906002)(81166005)(6116002)(3846002)(5004730100002)(2870700001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0437;H:[192.168.0.19];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjEyTUIwNDM3OzIzOnR6TzBHcXJKYUZPZGljK3J4SkwvcVpienI0?= =?utf-8?B?NDRlRnpkTnRlWDhJYS9SUHlEOUtETHhHQll4VGh0cDcyR3d6UFMxNVdmMS8x?= =?utf-8?B?Y3d2SmNiZ1QwSVp1Z1BPRDVNNmVMcWtEL3IrZDNFbFRnU0d0YTRJdEsrb1hK?= =?utf-8?B?UGVTTWVWblJwNk5Zampsd1N6OFNjRFpMUk9rUjBiL09aWWxFNnAvckpFTGtv?= =?utf-8?B?MzNXMkZwQXFtR1VPdlZFUXBYUUZ4Q2lKUUcrbFRKMU1qeG1CUTRnYVRpaEVV?= =?utf-8?B?RVUvOVgxOHRCazJhVysyMzhQdFpmQzRUUDZEVUJOZmhPMlgvRHMvZUl6Nm1F?= =?utf-8?B?TGsxMHlQMTNHaXhXR0I1TzQycFBTY3NPck5JSmtoMGNPWXNhZHFVdnBFSEpz?= =?utf-8?B?U1FrL2FoWFFMSmxpT0U0b0plNDhKcTdyVUFhWkNDQnk4dDQra09IVG1waDhE?= =?utf-8?B?NjI4NzFCWnZpWkFnT3FIUkt0NW5DbDBTdkNhM2hUZC9CRWRDWHlkSHl1UlIw?= =?utf-8?B?L0ZLY3VHa2RLVzJ0UmlvaHJOMVZSWmpCd3RVd0R5MVpmYzNxWFI2YXVvV0I1?= =?utf-8?B?ajhhYnJHa29GOFNnSnRTSFNDRURKQmg0RWJsSWFPU3hISnJ5QnZmaEp3cFIr?= =?utf-8?B?azk4NkpUU3YwUEJNckN3NGtKUnhRZU1HditRV0NOUjNMUEI4Q3Y0Yk5xWHFD?= =?utf-8?B?MStTbkxTZG4rVFVzZ3Y4VHZjV3dCWTFHM1JmNHltWThXVndzZmdMZUtOanEx?= =?utf-8?B?eGFtaHlySFhTMlo3VnpCbXMzeDk2Q3MwOWFycFpZSytkRFA2ditESklWQ3A5?= =?utf-8?B?UC9DZDNOby95SFk2b2pVemw1UFFuaXVuV1gyRnh1REZickp0U1M2ZUdzRnBt?= =?utf-8?B?VVB3YlJmMmVtR2oxR0JSR2MyU2oxdnhnL1ZrVmZUWVkxV2t4Vk1aSWRORzFr?= =?utf-8?B?YzFPa2lrOFNoNjlMdzVRZDZoRkNUWUI1SDNYZ0JVVlNtcnU3bTQxZE9IZ2ps?= =?utf-8?B?b0ljcStnekg0RHdLbUhEOCsyUmsxOVpBUmFJdFRTcUxHTll3bkZMeTFEazVy?= =?utf-8?B?T1pJckt1dGNHRTdtQ3VqdkVRMGJLT1lHenpsNUhBLy9BbXhCcGt4eEN0WU1Z?= =?utf-8?B?VXBwanFtaVc2V3YwdVJSci8yd2hkYVNCNjllbmF2enpUYWJUOUdkRXk3VVh3?= =?utf-8?B?RTUvYmkrYUNJUS8zL0hnaXJRNzV3OVkwWHIwNENCRGRXTEJJMDlHc21HUVNx?= =?utf-8?B?SG1CZVAwZkRDSmF3bm1aMlZUZEl3TTBhL2E1dm00dml2SHFlajA1ekx4UW52?= =?utf-8?B?MFFqUXVSZUdtLzVnWFNKZ0FhemxUVFZHbTh0RXNLUDFUaHRIZEJIa3VseGRW?= =?utf-8?B?NkJmQ1JwVFpzRE9wQ2FxUEVmalFCZ3lvTFpJVEZNei85c3k5K3RiTmI0bEFp?= =?utf-8?Q?Nz7h2Q=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;5:KWPbziM3XvX3WFrxdzjSgIQ61zviLRZ7b4WVL4VtdvkBk3T+W+cM1z874mvncdLwFMnR5pMD9QfHlGNqcsZ+geOnEiayr1wXRmhr8aqjPRPC+uXz0Cl4N3SRnxW8Gte+2Xe2BfVXk/ZU6QGRy2nmvQ==;24:EXDxuQGIrlbkamxLS4ETOZaTuZM4KBtcLqAQNHwDo2x3jhEZR5IVX+rnsvN0ImuLwVF13w51cCRahkmnJJRL5kuBbn9ddSgWuP4Hykrl7aw=;20:JEL8bk0A2lRomS9T+7sNdZIVDs+nEmiDTuGSkb8bJIugFyHq7Gx+CeO8gAQgRNIWkuWx9xymHu5BJi0CUZMXoyphtucrPj62nJ6izCDVfwc/QgxydJm7FumlYippgRhm+HCIYuhDksEvZ6PQGDP/0afDDk+g7/cbLZHiaRVdGautzh2WHBVEQs/FSKO3UyXIn1zOIDvOXtbUzgxnnK79pSnXZW/KU5zDqr/K+6pRisfLDNJIecrWV5i1qgwpRUlw X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2016 03:58:25.3028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0437 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Radim, On 03/10/2016 03:55 AM, Radim Krčmář wrote: >> >+ pr_debug("%s: offset=%#x, rw=%#x, vector=%#x, vcpu_id=%#x, cpu=%#x\n", >> >+ __func__, offset, rw, vector, svm->vcpu.vcpu_id, svm->vcpu.cpu); >> >+ >> >+ BUG_ON(offset >= 0x400); > These are valid faulting registers, so our implementation has to handle > them. (And the rule is to never BUG if a recovery is simple.) > Just want to clarify the part that you mentioned "to handle them". IIUC, offet 0x400 and above are for x2APIC stuff, which AVIC does not currently support. Also, since I have only advertised as xAPIC when enabling AVIC, if we run into the situation that the VM is trying to access these register, we should just ignore it (and not BUG). Do I understand that correctly? Thanks, Suravee