From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421AbcCRHHy (ORCPT ); Fri, 18 Mar 2016 03:07:54 -0400 Received: from mail-bn1bon0098.outbound.protection.outlook.com ([157.56.111.98]:11392 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750829AbcCRHHs (ORCPT ); Fri, 18 Mar 2016 03:07:48 -0400 Authentication-Results: lists.linux-foundation.org; dkim=none (message not signed) header.d=none;lists.linux-foundation.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header To: Peter Zijlstra , Borislav Petkov References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> <56E64B68.3090505@amd.com> <20160314095856.GL6344@twins.programming.kicks-ass.net> <56E6BE7E.8010807@amd.com> <20160314141945.GE15800@pd.tnic> <20160314163913.GO6344@twins.programming.kicks-ass.net> <56E759C3.5040707@amd.com> <20160315104017.GA4559@pd.tnic> <20160315105318.GU6344@twins.programming.kicks-ass.net> CC: , , , , , , , From: Suravee Suthikulpanit Message-ID: <56EBA92D.7010906@amd.com> Date: Fri, 18 Mar 2016 14:07:25 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160315105318.GU6344@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: SIXPR04CA0077.apcprd04.prod.outlook.com (10.141.119.35) To BY1PR12MB0438.namprd12.prod.outlook.com (25.162.147.14) X-MS-Office365-Filtering-Correlation-Id: ff032a32-7fa4-40b9-4476-08d34efc0158 X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;2:Y8vHogYLWitz9VbuQtE7hPGDyDWKOD/eILxo9u34saPLuKkVXlNBrbidge4zu4aB0AP2chF0VENyUKWVS/d0uZ+Lfr9nFA/AfLIVM7HwwIg5XB7qrxpre0iG+n13/PyT1KzBcczxBsIMEgsOJio0rSLwc/4nYoJS/BHKzIN5PXzk+jZK0XnRX4I32dQvI0iu;3:QZyukLlJ8F8MQd67RYiEk3527J50DM1/eCNuIWLsOZNzjz2iMMOxi69B/w2JCN4MYCWjewWFNQp/QJVHE5YnfbQmQDSadr5ZW/Ksk54bUcP+9e+5ir6BN5Nhf9mxWqVn;25:WcrluygZuEDljqW8XgPkKtIhWVcGo/OzeBmR1xtcuOJxHVEMHn50gi7ba+yN45E5wRueCPxtt1A2DJeas4vf2Rc2wBZQzOV0RWDoEduz1rlLdcAtHl9JwXw/ZEXjOwqoQSl3MCqje3iplwaaCCKaj5g2gHX1vzkSoQJJP93tmkUX+R6cc9kX4OXpzbJ5/8PUIZZR58fT3CjbGdZXfuGiw/NSychbUqTqoqvI/jW4CtrwlukAjUMPb0CvGUoDuAcPkpwH2o6QY/62mp0GJeomAHzVN//5PnOu+e57XOyzx9zqn++XU4yvgkrcwrE5zn470Ttom55ByffKjMLm4H5t9IcSm//SVxOLLxXa1FjfgydpODB3mqzTjX8Sulzj1HffdtM0Z294Glg0jhWway0bh/CrVACQyzP7iUucj4LdFT58n4clVOcpyCApxhC4ct4ny7V1q1p6tDC8oH9pqutEmKW/rYwdNBIWCB0tnsui2OgLpgJrC03Af4nLZwdQuudKIxcGUiqJQGv+YZaPDjufyg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0438; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;20:zpPdPBtz3VCEiZKJMhz+i2vsy/u/HNzvAeb1pEYGSVup7WUUzwsmxZe7knSZDOva9NF06t6OyI9UaxAs16L0osCd/bHnzr1xlFdEnXEfHHZaSOcKtpW0E5gAZKQLxn1z09HW2S4qj/anVtoBOWDZCjHxV3LFpSQ3seky1MeAt0yduHfocHG9prxy81S7KkMxbnGvAGj7m/4M1+ZQqeVEIebriMIplBYx1udtsWUpHXbm7T8JC4DJltyMrmac15ymPxUWaqkW7qpTyD3YxnSipogVl70QulPeCvUsdPHsemuzdBQVGXsixvwfoKnduQNQYfbJCZWMgk5JhYK1PDA7D7FaXsEB9LGC5FPUpalWLqAyq2aJ36jXzPO56+7eArJcqTpeP8JXmw3LwCU6YiOjS8SdRRxRl9xi3iUqdqj0JvIzzc6nUcGVOwaYbAKnw2XI9GboIUML8ndm4xXY7Lt+3CTxQUOqZBLyWePwqTlEFxzrOhTvJ5ymBqaV8rxmTxMm;4:kXJpr3UVbp+UdDn14jGF1NFKfuGebRfRw8Daf2OuHMKAVcZWQVpZ1PMgyRS17dpF0Wcw6nYQm7DnUp/4FVGdOKy3SWmHIwwZeZ5zgpKJbFJITjREg6K8qPmJI2wI6v8vgsnf4vyNdCW0xP2ECHqulUYSiX3tuc1j7BeQKrySBKYGJk0TYbsggx8JnLN5YtfePGnSep4WgNXnQBOKyKgmfQvvr7sVBHLoBO18m4rYM1+lLsj8H50GFxne5rP/FZ14fqexG+i6b1Ct4WImBH1NQUcg4rMwZ1F75OZH1ZRA6UavIKBSyEaG6xo1eRyBeYcWWkr3NInXxB+YCVo9GEjff84nKoqaU0dqLKo/WpNfYiPCNZFOtUbvKmu1GedJCr0i X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BY1PR12MB0438;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0438; X-Forefront-PRVS: 088552DE73 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(24454002)(377454003)(479174004)(164054003)(23746002)(50466002)(5001770100001)(5008740100001)(586003)(189998001)(4001350100001)(5004730100002)(92566002)(80316001)(86362001)(2950100001)(3846002)(6116002)(77096005)(64126003)(81166005)(230700001)(117156001)(93886004)(42186005)(36756003)(66066001)(65956001)(65806001)(76176999)(4326007)(47776003)(54356999)(50986999)(65816999);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0438;H:[192.168.0.19];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR12MB0438;23:ZXAiGSIEAUYbb1sL9SR1NEB7m1xeOO1BYWjCD?= =?Windows-1252?Q?QD+IOudg/Z6VsaxT5XVjcldRb4FOcHyKhLrN6xpZ0S8E10fgpDpL6fGt?= =?Windows-1252?Q?HlPSw7bRpE19HiZoSdv4evj96D5yhMIaChIf8u8Ri/UZJNWz49mLXr2S?= =?Windows-1252?Q?63R8AKq7Dj0yw31ec2UUYhPmFZZt4hEfvmCSQzFbaKZpi4rx+KKqZnmm?= =?Windows-1252?Q?3vNYgFQfjYXdnC8mwNEGyzsDl+MJGccv8QdVmJB8MqTVuUn5aF3Sv8ZD?= =?Windows-1252?Q?VH/crANWKgrHQ2O4ohuJJGkCgb6mdMGTZ1a430Ucpvu+Cm7eI4eKJRpJ?= =?Windows-1252?Q?rPPkkIz4g5EnvxQVgqCaLWzdfgFSJMHdj1oCepK/8saypaO7VzD/VIPN?= =?Windows-1252?Q?MzBhMx+XlkAZWnlmd601KHguV2E9XPN0GwaXSpHemymlDMLaE+hq1B9G?= =?Windows-1252?Q?fK5hG4rWa5y7/4oRZeXyPU4YPaoZiGwCVG4WH8DCY6NjUSt24VchKYha?= =?Windows-1252?Q?fqATtq0FB4upRcaAhtp9mUaUiQ17woth9p5/wDimGvMuQZq3Jt81q83J?= =?Windows-1252?Q?cKv9rcNC8qZdqj20nx5zGsKXDXL/Gostpxe7osV2kK708L1b/qd1d8p0?= =?Windows-1252?Q?t6PKHpNKgIdXHcYUhZ78HuOI01PDN5TCXckJKn7Mulrrxwqz3qmwfaHB?= =?Windows-1252?Q?fGiVqEYG8RpHPFAJ1X1df7IpzuPM818mydtluGfLSN35Bq9g1+K41gtT?= =?Windows-1252?Q?fe9E8vXxNywanUjSuOoYqkVED6bMGyAj1g07TMroQFbbY74/1yjBdwRB?= =?Windows-1252?Q?w6S3JNp932pJuKzvUVL8/O1NwZJsi0v2GWa9iua6nXuQtUunTbU0DQM0?= =?Windows-1252?Q?ntcvNiVnU9evwORw64UcISHVvRoO1nCxplMspTDbbxcxDuU256YVaH1A?= =?Windows-1252?Q?SsNflFoEUoqCtPTJq83nc7uocEdAHhWw6g/lLUeUb03ij89BuL+gkSVY?= =?Windows-1252?Q?nqTF6/PwoEDt4CJlZdCtx/sOfd6MeJbWfJcOOL0anO5k3ZLYb3OaI099?= =?Windows-1252?Q?yHy1YUHskm48lku0nIdu9vJ4PAFnZfUuu8CN96RkLh0M2j2I+u2w/cMt?= =?Windows-1252?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;5:RVdxpb6DTj6qmys1QtzUE9b1DY5sR4LK9ayzoVmmu0W77wL6pBzLm3I5hVZ1+L2mD/T5VA9OHgGfP2+1wf79HlQk97XY0TMHXuFxhxZkmciApcyPt/M9ox6irkvU8oKmzGff5Z9YbqYBni2kylhFRw==;24:7tZfq4PqqBaF/PzzgsfEvgH9U+LNdwvA6Gc57acA8iDGlPx3wND9fI3ERSUYsMhtfKJcmOmAafN8h0vExu3QDriRKsM52V45xra4FDUMLtQ=;20:wuHyJ5nYFeOzq8DH64/FouFS6elYr7zIJElSjpEOLsl6Dhd5zKQsZJBdMU+Qo1/8odor76fUcgbgkE8Kuf6XvAzWvP3gsDRbJXaAKehyNNo69YhRKdyLZ168ziFKe6so7jX+t7yXYjJz2y89xPliGr5Jzhmw+yQZfjG5gqOxbqiTMeJBrifJiTd6LUv02LQudXbRBMMWseUS58nWkRYtevXey+uxz5qx8tYO8Yb326wJcPTMF61LqiSK9Ai4VOUd SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2016 07:07:42.5189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0438 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 03/15/2016 05:53 PM, Peter Zijlstra wrote: > On Tue, Mar 15, 2016 at 11:40:17AM +0100, Borislav Petkov wrote: >> On Tue, Mar 15, 2016 at 07:39:31AM +0700, Suravee Suthikulpanit wrote: >>> What if I just merge the newly introduced arch/x86/include/perf/amd/iommu.h >>> into the include/linux/amd-iommu.h? I do not see the point of having to >>> separate things out into two files. >> >> Except that this header has x86-specific stuff and include/linux/ is >> arch-agnostic. > > Which would suggest that header is placed wrong, because I would expect > the amd-iommu to really be rather x86 specific. Or is AMD making ARM > parts for which this is useful too? > Actually the exposed APIs (in both files) are from the AMD IOMMU driver, which is not necessary x86-specific. They mostly use struct pci_dev, which is also arch-agnostic. It is correct that the current IOMMU IP is only available in x86 systems. However, if AMD plans to use the IOMMU IP in the ARM-based processors in the future, putting these into include/linux/amd-iommu.h would work better. Thanks, Suravee