From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754958AbcCRJJ7 (ORCPT ); Fri, 18 Mar 2016 05:09:59 -0400 Received: from mail-bn1bon0062.outbound.protection.outlook.com ([157.56.111.62]:50816 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754384AbcCRJJx (ORCPT ); Fri, 18 Mar 2016 05:09:53 -0400 Authentication-Results: lists.linux-foundation.org; dkim=none (message not signed) header.d=none;lists.linux-foundation.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header To: Borislav Petkov References: <20160312132224.GI6344@twins.programming.kicks-ass.net> <56E64B68.3090505@amd.com> <20160314095856.GL6344@twins.programming.kicks-ass.net> <56E6BE7E.8010807@amd.com> <20160314141945.GE15800@pd.tnic> <20160314163913.GO6344@twins.programming.kicks-ass.net> <56E759C3.5040707@amd.com> <20160315104017.GA4559@pd.tnic> <20160315105318.GU6344@twins.programming.kicks-ass.net> <56EBA92D.7010906@amd.com> <20160318090441.GA7817@pd.tnic> CC: Peter Zijlstra , , , , , , , , From: Suravee Suthikulpanit Message-ID: <56EBC5CD.7070701@amd.com> Date: Fri, 18 Mar 2016 16:09:33 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160318090441.GA7817@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: SIXPR04CA0050.apcprd04.prod.outlook.com (25.162.171.40) To BY1PR12MB0437.namprd12.prod.outlook.com (25.162.147.139) X-MS-Office365-Filtering-Correlation-Id: dcffd6c7-b744-491c-2e29-08d34f0d0f68 X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;2:15ohWqxKfOmtyyAMcepjF5/JhDY10Vz9TaB6RuYvzzJHGXTJiCGZB2ugUxyE/41NDnKz2/oB9Y9QHIgetLvjj+6P8HBjvm1xsJeo2ZRqsLOHiG3PdIr8k9dQdxn+dK1H/3usUJ0xfrsb3gzVsZztMYF7fYnYud2RGZ5HSrjayH+wNoADpBXJlt8cFEQxhe3q;3:rru3oaNhut1ybvfiSHG68upLX50k9+FMPkCjL5zUdAWB8bwy+hi7u+fu+4J0Pdc8B+8eVULSzZetRE4NFhoqJP3IaKcGJWgeThNXwSMo2+V3dkdlzWWZxiQ67owddEUx;25:nxx6eDd11ZX2bOgHXfhnrbNXWCOX65GOKxAlhPis8mOSXjnJisTnbhVL7joQ19JAbca2uPlaIg9GgL6t88ZNPqpmryf6//P2VmFxudCXJKLN1e2QE2WY9TdINVJ4DSurL6nhDP4g2Q0F3mwImSEVc5gq+NiMckjGhU5h3tI8aVI7ujvRl+ycxMa1umqliJTamEKC1tY9YAvtVbbuuOWwL4we27gTeB+JHeYbMHjVMM9WYSDshczNFldOhAfUBUvGZieWgMPvLXmnqol3tcSyMygoUXSWAFW3L+AIKxb7iRWDreLZLbDTz+gLZISqW+b7r1EcadYkkqY3UFC72RFOdV1OegT2Z7DHKay9zUlgLAqzheNgiIb1u+7K+1ahJQvvTwWpj8Ik0uJ139osFSl5Pkc3Uu53gHIYU/wzLVmdUYdlQcXFAPsB+CxUiWP5LTtc75rthDsSUcc+yfyp3whOpC7fruh+1Yt1zMDqFOHTYu5dbaqFRkiQ5RLwYZL07x0NneW4rYu+69EIbCMq14h/0Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0437; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;20:cUfU/LI40bKUBjvjRl6s/eXOD+JJQTB+SzVUBVC2MjWE1DEILHYApqM6H/7nFMG23tvCF6MNXFitjH4mwqsdPCj/ZY7gE3qbBc05GaL5KpRXWK/elRfHYdqK3W/icRLPNNAnI9LCaywsKYOLhrSThAFGg4EMgmKVfZO2IcFRmYFR7a9a3TYHDn1tWsi9oAilkA/HuvHX0ofMlPqGGo10khpYyheupHl5UmPFoSYqDs3wXkrSlKpcXga7LH3EG5dQdzxOLSiXZugcCoZJ5sD2+WxuoQiv0PXHAIYwW/2AbwICwEvNZcutHS2WoOT6335dtiMwI5IvwAzs9I+Hr5YGs1xxRAN+T9Hc4hDZTS00pApgy0KF5/i7gOEkh2VcRI0JwVBXnRqmSC4x/gCVZXhMjuX2N9Tiw+9G5TdeFeNM6wWvbZ2m2xmb4Ra5DqyiH9bc7H/eKyakUZpcnkrRSaVH4wZyB6YoUVKY9h/Qwem1JwQo5V8iUyFDKR59xc5CEz5I;4:bxKp1ZbLE1vDcy3gkTpNj+YIhfSnqmI3uI9BB46dzc0De809rG42aFkkXP5M3rvWxKwaQ+UYu9RpyHuseu0cfxGRaqeI1uMXhTheapLA4UU8fEZ1uPHjA2ReZiaq5LjYFwA9Ho3r1VDuMi/9KYZ1ffESrgmzk+nsen6DphdDPs0ORmqvYKUWOtwJ4jUDd5TUnSNp//OP0kOaEu0nN59f47tg8l/LNorAhF42V5LC3gZV4A4ciy9OB6PPKmnxn3Ar7gZnNKbJ0mCRCwvciuTyx9qm90BV6CwxkfNua8JszK6ZaxOU8JxqPuTis/W1uIMj9GTbpauf0LgU1cOw7lYp8RXWVxLGQAuby2zpwgHHcTKyc5MgPko4nsqKQBMpbDar X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BY1PR12MB0437;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0437; X-Forefront-PRVS: 088552DE73 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(479174004)(24454002)(377454003)(66066001)(110136002)(189998001)(80316001)(230700001)(65956001)(47776003)(83506001)(586003)(65806001)(42186005)(3846002)(6116002)(86362001)(93886004)(4001350100001)(1096002)(33656002)(2950100001)(36756003)(5004730100002)(77096005)(81166005)(4326007)(64126003)(2906002)(50466002)(59896002)(92566002)(23676002)(54356999)(5008740100001)(50986999)(76176999)(65816999);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0437;H:[192.168.0.19];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjEyTUIwNDM3OzIzOmloV1RSUnBrZHRlMnJiOEUydi9WRzRtenU2?= =?utf-8?B?czlOWWp6VDBMYjN0bWk3dno5Vzl0K2ZSZXluVFY3SVdaWTJmOHBiMnhyRmRR?= =?utf-8?B?YzNKeFVBcVZBMitEc3JhVWJOUjhXYlJJZXltdWVVK0lPSXhJbWs4TGpFVkoz?= =?utf-8?B?ajBYZlZTOHFBMHRBa3hNWEp4ZEh0SERXN0FDSU9lWVVxUm1WZE5GUG95MEF5?= =?utf-8?B?SVJ5SGpURWYxT2tTKzZodGtNVm9PNExwSVpqT3ZzVXBOVHNhL0VqZE9Qbldy?= =?utf-8?B?RlI5T1J0TlN2NkxBTW5MaWNLb2c1MDRjeDFaU3NTTlZGUlFRZXVabHJXMTdC?= =?utf-8?B?aHpKZFlFU0dROFVZZTgwemZacTNhV1E0b0JiRzJjQmFNRzdpd0d4MXhZNy9a?= =?utf-8?B?dVFlZ1YwR1pzTHBmMWlpZ0NBMDNvREExa0lCTms3YXQxdUErV3A0Tzl1UFZM?= =?utf-8?B?ZFdGZS9ORlFlQ05mOWNoMWZBaS9URjhFL2g0YXZhZHhxUkRtRVp6a3NUMTRW?= =?utf-8?B?QTdkcUhIVzJFRjdIdFRNZSs0cUVrNEFJR0dxYTNBV2tUSlI1R2tscmJCRHVz?= =?utf-8?B?cnNtS1JpNE0zTm9pQS96U1dCL1NadjJvWjhKM2krK0ZvazJmNXdUVWxUbi9R?= =?utf-8?B?OHAydUU0Nmlrb2R2Z2lGM2FRU29yZWh2NkErRDBLR2NvVjM2K09UcHRBMzcv?= =?utf-8?B?UEhKSThVekZqbEtmTC9rZkNWQWhtK3N4L2tkaE1ScHF3L0trR1VZT3p5L2N5?= =?utf-8?B?b2tzYnZidmhtbnhKNkhESE5qOWptMy9UTzc4dDduN09QVElRVmNaM0RLRGpB?= =?utf-8?B?SDEvMjg5MkVmeW5yUW9ZZUI5aVJOZ090cFVFbWMxVmpKVk1VMjhNUWZSa2g3?= =?utf-8?B?b2ZiZmdqT3NGL2lrVEs0Mm8rZVRxUjd1blVrQUJNSHBlV1E0YVZUR3hhaDdG?= =?utf-8?B?Z0Vmb3ZKRWNoTDYxTVIybkpxTkNPRmt4K0F6V1U4V1lTRkJ0YUVvc1pZdmt2?= =?utf-8?B?WS8zOXorazlCdGR6dTh4clFYWjRYRHhud3VhY3Jxdk9QWi9WcVNtbS9aNkNr?= =?utf-8?B?dis0UGhjWEdmQ1BxUmZRTFZvM0J0eGpXMExibUtvbmI2V0RVT3BPbUg0dWVp?= =?utf-8?B?d1dqRG1RSjdqdWhDRnh1V29Nc3BUdzVvSVdSazBxd1B5VEdneXRsTytGL3Jr?= =?utf-8?B?bGdHNmcvMDVPeWxrNXl6aUJCcTlqV1VxQ0FBbEkxMlA1a0daSnhwM1BWY3dY?= =?utf-8?B?SStlczRaVEE5WEY2YVU1WGR4WXMzcUM3Q053U0lJSUZwM2o4eVNuR2hENmxV?= =?utf-8?B?MSt4ODhJektGd0M1R2lJeWZ1UE5wcndBbm9aS21MRXJYTUU5L2JUTkVMaXRK?= =?utf-8?B?Zzh3SWNDZGZGSHNQSVBPam1QYjdwbGRSM0N2UkxBbnRGcHdENk9jYnVZeDF6?= =?utf-8?Q?UeINcgHRlpICHFIYor30CvkYw9M?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;5:zwJ4Xebb5F+tNFnLwyqj5kuwm0CYaCVxJ3bT0S/nPKGhwwg0Gzfko0ifx75soO7rrC9aaftjtUMAem2zV4Up8JzyWlu54CwWga95GZR89AhH+9Bod/oetXBD6Y8qYQ60L30z9HPHOOrWgXOnYLqh/w==;24:vkbDHZUdcdMLo+xp2vGymem/2On+b1ftNmWyLi5FHbmKt+mnfqAhXm2HZkHxgK/2fF14JccvZg98gY8+Ci0WK6IuYyYoRR72FoF0zMIK5jY=;20:steZSshoO9yxfSno7DKDBrL6OhXZWN7KF8ChSn0wfKxqBenKQRcLrFsG92Leo2s4XnICwZogpCWnEVbzMK1AZjNHMdfDwDRVx5lShsXFUs5Lj2KqeCIE6SMHwEnvgXoJn+DcPol/t4VSgUrTzX9VdtSUAme635ZU1cmL64Ilp1KeZLZceZTIWcnEqOuUYbY91SWVO85G3vV8FBXi4Mx1Hg+mdybUOSDPDWHrQKy0g/jTINcg94efy6o8OwWmqOgc SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2016 09:09:47.5088 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0437 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 03/18/2016 04:04 PM, Borislav Petkov wrote: > On Fri, Mar 18, 2016 at 02:07:25PM +0700, Suravee Suthikulpanit wrote: >> Actually the exposed APIs (in both files) are from the AMD IOMMU driver, >> which is not necessary x86-specific. They mostly use struct pci_dev, which >> is also arch-agnostic. It is correct that the current IOMMU IP is only >> available in x86 systems. However, if AMD plans to use the IOMMU IP in the >> ARM-based processors in the future, putting these into >> include/linux/amd-iommu.h would work better. > > Let's wait until AMD does that then. Moving the header is the easiest part. > But the whole point is that since we are moving it to consolidate these duplicated declarations, I think we should just put it in the most common place. The include/linux/amd-iommu.h file is already there. It's not like we have to create a brand new file, and then having to move it later. Regards, Suravee