From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752320AbcDARV7 (ORCPT ); Fri, 1 Apr 2016 13:21:59 -0400 Received: from lists.s-osg.org ([54.187.51.154]:60129 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbcDARV5 (ORCPT ); Fri, 1 Apr 2016 13:21:57 -0400 Subject: Re: [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5250 To: Krzysztof Kozlowski , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <1459493874-2366-1-git-send-email-k.kozlowski@samsung.com> <1459493874-2366-6-git-send-email-k.kozlowski@samsung.com> From: Javier Martinez Canillas Message-ID: <56FEAE29.6010405@osg.samsung.com> Date: Fri, 1 Apr 2016 13:21:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459493874-2366-6-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, Patch looks good to me, I have just one question below: On 04/01/2016 02:57 AM, Krzysztof Kozlowski wrote: > Fix following DTC warnings in all Exynos5250 boards: > > Warning (unit_address_vs_reg): Node /dp-controller@145B0000/display-timings/timing@0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /usb@12000000 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /usb@12000000/dwc3 has a reg or ranges property, but no unit name > Warning (unit_address_vs_reg): Node /hdmi has a reg or ranges property, but no unit name > Warning (unit_address_vs_reg): Node /mixer has a reg or ranges property, but no unit name > Warning (unit_address_vs_reg): Node /video-phy@10040720 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /fixed-regulator@0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /fixed-regulator@1 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /fixed-regulator@2 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /i2c@12C70000/trackpad has a reg or ranges property, but no unit name > Warning (unit_address_vs_reg): Node /i2c@12CD0000/lvds-bridge@20/ports/port@0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /i2c@12CD0000/lvds-bridge@20/ports/port@1 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /i2c-arbitrator/i2c@0/embedded-controller has a reg or ranges property, but no unit name > Warning (unit_address_vs_reg): Node /i2c-arbitrator/i2c@0/power-regulator has a reg or ranges property, but no unit name > Warning (unit_address_vs_reg): Node /i2c@12CA0000/embedded-controller has a reg or ranges property, but no unit name > > Signed-off-by: Krzysztof Kozlowski > --- [snip] > > - usb@12000000 { > + usb_dwc3 { > compatible = "samsung,exynos5250-dwusb3"; > clocks = <&clock CLK_USB3>; > clock-names = "usbdrd30"; The ePAPR document says that "The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model" So I wonder if this shouldn't be instead: usb_dwc3: usb { Although it seems that not all DT bindings follow this convention so probably the name in your patch is correct. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America