From: Dave Jiang <dave.jiang@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Xiangliang.Yu@amd.com, jdmason@kudzu.us, Allen.Hubbe@emc.com
Cc: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] NTB: Fix 'request_irq()' and 'free_irq()' inconsistancy
Date: Mon, 19 Dec 2016 10:04:24 -0700 [thread overview]
Message-ID: <56b16dd5-b83b-e8b0-bf79-2dd2bc56f1e1@intel.com> (raw)
In-Reply-To: <20161219055255.21418-1-christophe.jaillet@wanadoo.fr>
On 12/18/2016 10:52 PM, Christophe JAILLET wrote:
> 'request_irq()' and 'free_irq()' should have the same 'dev_id'.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acking the Intel driver portion.
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/ntb/hw/amd/ntb_hw_amd.c | 2 +-
> drivers/ntb/hw/intel/ntb_hw_intel.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c
> index 6ccba0d862df..a48c3e085eab 100644
> --- a/drivers/ntb/hw/amd/ntb_hw_amd.c
> +++ b/drivers/ntb/hw/amd/ntb_hw_amd.c
> @@ -598,7 +598,7 @@ static int ndev_init_isr(struct amd_ntb_dev *ndev,
>
> err_msix_request:
> while (i-- > 0)
> - free_irq(ndev->msix[i].vector, ndev);
> + free_irq(ndev->msix[i].vector, &ndev->vec[i]);
> pci_disable_msix(pdev);
> err_msix_enable:
> kfree(ndev->msix);
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
> index 7310a261c858..2413600aae30 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> @@ -472,7 +472,7 @@ static int ndev_init_isr(struct intel_ntb_dev *ndev,
>
> err_msix_request:
> while (i-- > 0)
> - free_irq(ndev->msix[i].vector, ndev);
> + free_irq(ndev->msix[i].vector, &ndev->vec[i]);
> pci_disable_msix(pdev);
> err_msix_enable:
> kfree(ndev->msix);
>
next prev parent reply other threads:[~2016-12-19 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 5:52 [PATCH] NTB: Fix 'request_irq()' and 'free_irq()' inconsistancy Christophe JAILLET
2016-12-19 17:04 ` Dave Jiang [this message]
2016-12-21 16:52 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b16dd5-b83b-e8b0-bf79-2dd2bc56f1e1@intel.com \
--to=dave.jiang@intel.com \
--cc=Allen.Hubbe@emc.com \
--cc=Xiangliang.Yu@amd.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jdmason@kudzu.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).