From: Randy Dunlap <rdunlap@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>,
mingo@kernel.org, torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, will@kernel.org,
paulmck@kernel.org, hch@lst.de, axboe@kernel.dk,
chris@chris-wilson.co.uk, davem@davemloft.net, kuba@kernel.org,
fweisbec@gmail.com, oleg@redhat.com, vincent.guittot@linaro.org
Subject: Re: [RFC][PATCH v2 10/10] irq_work: Add a few comments
Date: Tue, 18 Aug 2020 08:52:38 -0700 [thread overview]
Message-ID: <56be3f06-4d4a-4128-a8b4-dbe12d37ce78@infradead.org> (raw)
In-Reply-To: <20200818112418.591210082@infradead.org>
Hi Peter,
a few typos below...
On 8/18/20 3:51 AM, Peter Zijlstra wrote:
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> include/linux/irq_work.h | 80 +++++++++++++++++++++++++++++++++++++++++------
> kernel/irq_work.c | 10 +++++
> 2 files changed, 80 insertions(+), 10 deletions(-)
>
> --- a/include/linux/irq_work.h
> +++ b/include/linux/irq_work.h
> @@ -48,12 +47,45 @@ static inline bool irq_work_is_busy(stru
>
> #ifdef CONFIG_IRQ_WORK
>
> +/*
> + * irq_work_queue(): run @work in IRQ context on this CPU
> + * @work: work to run
> + *
> + * Self-IPI, NMI-safe
> + *
> + * When the function returns false; @work is already queued and
> + * any eventual execution of it's func() is guaranteed to see
its
> + * any state before the failing enqueue.
> + */
> bool irq_work_queue(struct irq_work *work);
> +
> +/*
> + * irq_work_queue_on(): run @work in IRQ context on @cpu
> + * @work: work to run
> + * @cpu: cpu to run @work on
> + *
> + * *NOT* NMI-safe
> + *
> + * When the function returns false; @work is already queued and
false,
> + * any eventual execution of it's func() is guaranteed to see
its
> + * any state before the failing enqueue.
> + */
> @@ -67,8 +99,36 @@ static inline bool irq_work_needs_cpu(vo
> +/*
> + * irq_work_queue_remote_state(): like irq_work_queue_remote() except dangerous
> + * @cpu:
> + * @work:
> + *
> + * DO NOT USE, this function is horrible/dangerous.
> + *
> + * The test-and-set-PENDING is not atomic, it also doesn't set
> + * the BUSY bit and with that breaks irq_work_sync().
> + *
> + * This means that the caller needs external serialization; life-time,
> + * where relevant, also needs to be externally orchestated.
orchestrated.
> + *
> + * There is no validation/debugging to help you if you get it wrong.
> + */
> extern int irq_work_queue_remote_static(int cpu, struct irq_work *work);
> +
> extern void irq_work_single(void *arg);
> #endif
>
--
~Randy
prev parent reply other threads:[~2020-08-18 15:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 10:51 [PATCH v2 00/10] smp: irq_work / smp_call_function rework Peter Zijlstra
2020-08-18 10:51 ` [PATCH v2 01/10] irq_work: Cleanup Peter Zijlstra
2020-08-18 10:51 ` [PATCH v2 02/10] smp: Cleanup smp_call_function*() Peter Zijlstra
2020-08-18 10:51 ` [PATCH v2 03/10] irq_work: Optimize irq_work_single() Peter Zijlstra
2020-08-18 10:51 ` [PATCH v2 04/10] irq_work: Unconditionally build on SMP Peter Zijlstra
2020-08-18 10:51 ` [PATCH v2 05/10] irq_work: Provide irq_work_queue_remote() Peter Zijlstra
2020-08-18 10:51 ` [RFC][PATCH v2 06/10] irq_work: Provide irq_work_queue_remote_static() Peter Zijlstra
2020-08-18 10:51 ` [RFC][PATCH v2 07/10] sched/fair: Exclude the current CPU from find_new_ilb() Peter Zijlstra
2020-08-18 10:51 ` [RFC][PATCH v2 08/10] smp,irq_work: Use the new irq_work API Peter Zijlstra
2020-08-18 16:25 ` Christoph Hellwig
2020-08-19 7:22 ` peterz
2020-08-19 18:50 ` Linus Torvalds
2020-08-19 19:41 ` peterz
2020-08-19 22:04 ` Linus Torvalds
2020-08-20 13:08 ` peterz
2020-08-20 6:20 ` Christoph Hellwig
2020-08-20 6:19 ` Christoph Hellwig
2020-08-20 13:40 ` peterz
2020-09-09 8:03 ` Christoph Hellwig
2020-08-18 10:51 ` [RFC][PATCH v2 09/10] smp: Make smp_call_function_single_async() safer Peter Zijlstra
2020-08-18 10:51 ` [RFC][PATCH v2 10/10] irq_work: Add a few comments Peter Zijlstra
2020-08-18 15:52 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56be3f06-4d4a-4128-a8b4-dbe12d37ce78@infradead.org \
--to=rdunlap@infradead.org \
--cc=axboe@kernel.dk \
--cc=chris@chris-wilson.co.uk \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=hch@lst.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).