From: "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, ashok.raj@intel.com
Subject: Re: [PATCH v9 1/5] PCI: Conditionally initialize host bridge native_* members
Date: Tue, 22 Sep 2020 13:50:21 -0700 [thread overview]
Message-ID: <56d9af56-223a-c141-bc05-9499fbd5ff0a@linux.intel.com> (raw)
In-Reply-To: <20200922203950.GA2227863@bjorn-Precision-5520>
On 9/22/20 1:39 PM, Bjorn Helgaas wrote:
> I got 1/5, 3/5, and 5/5 (and no cover letter). Is there a 2/5 and a
> 4/5? Not sure if I should wait for more, or review these three as-is?
I sent all 5 together with cover letter. Do you want me to send it again ?
>
> On Fri, Sep 18, 2020 at 12:58:30PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> If CONFIG_PCIEPORTBUS is not enabled in kernel then initialing
>> struct pci_host_bridge PCIe specific native_* members to "1" is
>> incorrect. So protect the PCIe specific member initialization
>> with CONFIG_PCIEPORTBUS.
>>
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>> ---
>> drivers/pci/probe.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
>> index 03d37128a24f..0da0fc034413 100644
>> --- a/drivers/pci/probe.c
>> +++ b/drivers/pci/probe.c
>> @@ -588,12 +588,14 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge)
>> * may implement its own AER handling and use _OSC to prevent the
>> * OS from interfering.
>> */
>> +#ifdef CONFIG_PCIEPORTBUS
>> bridge->native_aer = 1;
>> bridge->native_pcie_hotplug = 1;
>> - bridge->native_shpc_hotplug = 1;
>> bridge->native_pme = 1;
>> - bridge->native_ltr = 1;
>> bridge->native_dpc = 1;
>> +#endif
>> + bridge->native_ltr = 1;
>> + bridge->native_shpc_hotplug = 1;
>>
>> device_initialize(&bridge->dev);
>> }
>> --
>> 2.17.1
>>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
next prev parent reply other threads:[~2020-09-22 20:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 20:54 [PATCH v9 0/5] Simplify PCIe native ownership detection logic sathyanarayanan.kuppuswamy
2020-09-18 19:58 ` [PATCH v9 1/5] PCI: Conditionally initialize host bridge native_* members sathyanarayanan.kuppuswamy
2020-09-22 20:39 ` Bjorn Helgaas
2020-09-22 20:50 ` Kuppuswamy, Sathyanarayanan [this message]
2020-09-22 20:56 ` Bjorn Helgaas
2020-09-22 20:54 ` sathyanarayanan.kuppuswamy
2020-09-28 1:11 ` Kuppuswamy Sathyanarayanan
2020-09-18 19:58 ` [PATCH v9 3/5] ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native is set sathyanarayanan.kuppuswamy
2020-09-22 20:54 ` sathyanarayanan.kuppuswamy
2020-09-28 1:11 ` Kuppuswamy Sathyanarayanan
2020-09-18 19:58 ` [PATCH v9 5/5] PCI/DPC: Move AER/DPC dependency checks out of DPC driver sathyanarayanan.kuppuswamy
2020-09-22 20:54 ` sathyanarayanan.kuppuswamy
2020-09-28 1:11 ` Kuppuswamy Sathyanarayanan
2020-09-22 20:54 ` [PATCH v9 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic sathyanarayanan.kuppuswamy
2020-09-28 1:11 ` Kuppuswamy Sathyanarayanan
2020-09-28 1:11 ` [PATCH v9 0/5] Simplify PCIe native ownership detection logic Kuppuswamy Sathyanarayanan
2020-09-28 1:11 ` [PATCH v9 2/5] ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set Kuppuswamy Sathyanarayanan
2020-09-29 20:58 ` [PATCH v9 0/5] Simplify PCIe native ownership detection logic Kuppuswamy, Sathyanarayanan
2020-09-29 21:04 ` Bjorn Helgaas
2020-09-29 21:23 ` Kuppuswamy, Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d9af56-223a-c141-bc05-9499fbd5ff0a@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).