From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34138C43217 for ; Tue, 19 Apr 2022 23:55:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358545AbiDSX6k (ORCPT ); Tue, 19 Apr 2022 19:58:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230177AbiDSX6f (ORCPT ); Tue, 19 Apr 2022 19:58:35 -0400 Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 151921D338 for ; Tue, 19 Apr 2022 16:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1650412550; x=1681948550; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=KKbVILJHDOZ2N6m0wCdUFAHCkLkQrMH0aZI7ADXChcU=; b=SvegSOFN21sX9MOAObq6gv+/kaf4UCErQxBcAUX+WzU8ERMyN+gC0zZJ jTRxnEPWYsJQSqi1yAJB4ABA39mwoioHHTsSAxsnj1bGkDXvA6Cegx87s zkh7pS2Geiy29gJGNAf3BZZTjjMgPUPs6t7/j+Cf14Xxet35OM7lxlcBx XsMfGBW6VjMOkpRxLnTJZcK2KQED7+oeJoNqrLv2iPof3LgW6125OFrun IM6xQCYWHhTA8DIRbh8nMHbThJ/2CWdl8Qp2+bOp3x76w4e4gDiLy9oNv wS78e6HHYcLX5rhDGLshvktYqsHQmYpC0KV99UlicDk6JUaU9fxMrhapG A==; X-IronPort-AV: E=Sophos;i="5.90,274,1643644800"; d="scan'208";a="302502774" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 20 Apr 2022 07:55:48 +0800 IronPort-SDR: 40B7KFGofWv+kUTPbcpTAnQCQpHBcsjEus3SweG0lgFvDSWHW1SRykZKkqNlCL9a/dwPzi4DxU RlvIJzNDrtVPSRCBJBQ3ZOE2dLJMneSm4J1CZ3Gebue8yw8m+TVR3iMpeKNe4440oiXITbdlwJ I8/Vbj44mZxCQpnqWSECpHSmcr0Vf3EmglLsapEvokrUAJER0tT6bDhrXyQ6jmyUdc91iPD3EU 8JHe94exfOy0b1jCTrgAV4qXKvkGoOK501Tr1rvic9uF8TgukxVFU3mKItRJ8MHSzT/VCtjW9u E4yrZw2N5oIB6TNDXUpnW7fZ Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Apr 2022 16:26:53 -0700 IronPort-SDR: nvnwr2xjCW08Z+wb6yZy4MkxOE8pmdxhuBNcOdAnu++ggYFuC8984s86jULJV/7fBl7eYmqugS bV52cpK0ikyS4NyUYvDbKJhdlZKk1KF05mVKyxUJzImW3s30i12PbJ9sW7Yuf1UQEgXIm5edVi uYmDn6OLwlWnGEbEdm0HDi7wVZoOYKFJYq4ko6plCGMrPRGqlsO+4QcwuhYU/oUejOzJIor9ug RasFYlnWNQuenI1JUlWOA0zy/Xvl/16Fb+VdqCTyUVOYyNdEuG9ViDqOBrp2DDTz5FUvZBL1fu 29Q= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Apr 2022 16:55:49 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Kjgfq6cgtz1Rwrw for ; Tue, 19 Apr 2022 16:55:47 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1650412546; x=1653004547; bh=KKbVILJHDOZ2N6m0wCdUFAHCkLkQrMH0aZI 7ADXChcU=; b=LCqvtKdjRzDf5W/dOuU4+TSqtj4jJ6smpVH8RFQjhPvD0oWKSgK VNbKgZqe7cD95Wa4oWwwzQwFfFjHRTAt35h60/w1of/oOG9jfbrw4iqvuZS7dtTe aZtfiNytQfRTWGOEMs2tAcmlOzwo+vE0kys3+zkyflfi5RxJfbaxotJUsG4D0jJy WojFgUn199a5v964YoPbv5FCMw8NXqS+6upFcwqh5wpiQQtGpdju9BDzMHfoMB6A m60tmCvI2wmQoTXA6bLHrqCEivcB876f24T7gNJPXqdWy6pTqCQua5gzTqx0/f/H kRzjX0Tbt6TjZYydknqyZIUM109PRCFtLhg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id q2y5BaS7X3G8 for ; Tue, 19 Apr 2022 16:55:46 -0700 (PDT) Received: from [10.225.163.14] (unknown [10.225.163.14]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Kjgff0k5zz1Rvlx; Tue, 19 Apr 2022 16:55:37 -0700 (PDT) Message-ID: <56f889d7-2305-ba7a-42af-9580d8f7df93@opensource.wdc.com> Date: Wed, 20 Apr 2022 08:55:36 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 13/48] ARM: pxa: use pdev resource for palmld mmio Content-Language: en-US To: Arnd Bergmann , robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org Cc: Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , Linus Walleij , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org, Jens Axboe , Bartlomiej Zolnierkiewicz References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-14-arnd@kernel.org> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220419163810.2118169-14-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/20/22 01:37, Arnd Bergmann wrote: > From: Arnd Bergmann > > The palmld header is almost unused in drivers, the only > remaining thing now is the PATA device address, which should > really be passed as a resource. > > Cc: Jens Axboe > Cc: linux-ide@vger.kernel.org > Acked-by: Robert Jarzmik > Acked-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-pxa/palmld-pcmcia.c | 3 ++- > arch/arm/mach-pxa/palmld.c | 12 +++++++++--- > arch/arm/mach-pxa/{include/mach => }/palmld.h | 2 +- > drivers/ata/pata_palmld.c | 3 +-- > 4 files changed, 13 insertions(+), 7 deletions(-) > rename arch/arm/mach-pxa/{include/mach => }/palmld.h (98%) > > diff --git a/arch/arm/mach-pxa/palmld-pcmcia.c b/arch/arm/mach-pxa/palmld-pcmcia.c > index 07e0f7438db1..720294a50864 100644 > --- a/arch/arm/mach-pxa/palmld-pcmcia.c > +++ b/arch/arm/mach-pxa/palmld-pcmcia.c > @@ -13,9 +13,10 @@ > #include > > #include > -#include > #include > > +#include "palmld.h" > + > static struct gpio palmld_pcmcia_gpios[] = { > { GPIO_NR_PALMLD_PCMCIA_POWER, GPIOF_INIT_LOW, "PCMCIA Power" }, > { GPIO_NR_PALMLD_PCMCIA_RESET, GPIOF_INIT_HIGH,"PCMCIA Reset" }, > diff --git a/arch/arm/mach-pxa/palmld.c b/arch/arm/mach-pxa/palmld.c > index d85146957004..d821606ce0b5 100644 > --- a/arch/arm/mach-pxa/palmld.c > +++ b/arch/arm/mach-pxa/palmld.c > @@ -29,8 +29,8 @@ > #include > > #include "pxa27x.h" > +#include "palmld.h" > #include > -#include > #include > #include > #include > @@ -279,9 +279,15 @@ static inline void palmld_leds_init(void) {} > * HDD > ******************************************************************************/ > #if defined(CONFIG_PATA_PALMLD) || defined(CONFIG_PATA_PALMLD_MODULE) > +static struct resource palmld_ide_resources[] = { > + DEFINE_RES_MEM(PALMLD_IDE_PHYS, 0x1000), > +}; > + > static struct platform_device palmld_ide_device = { > - .name = "pata_palmld", > - .id = -1, > + .name = "pata_palmld", > + .id = -1, > + .resource = palmld_ide_resources, > + .num_resources = ARRAY_SIZE(palmld_ide_resources), > }; > > static struct gpiod_lookup_table palmld_ide_gpio_table = { > diff --git a/arch/arm/mach-pxa/include/mach/palmld.h b/arch/arm/mach-pxa/palmld.h > similarity index 98% > rename from arch/arm/mach-pxa/include/mach/palmld.h > rename to arch/arm/mach-pxa/palmld.h > index 99a6d8b3a1e3..ee3bc15b71a2 100644 > --- a/arch/arm/mach-pxa/include/mach/palmld.h > +++ b/arch/arm/mach-pxa/palmld.h > @@ -9,7 +9,7 @@ > #ifndef _INCLUDE_PALMLD_H_ > #define _INCLUDE_PALMLD_H_ > > -#include "irqs.h" /* PXA_GPIO_TO_IRQ */ > +#include /* PXA_GPIO_TO_IRQ */ > > /** HERE ARE GPIOs **/ > > diff --git a/drivers/ata/pata_palmld.c b/drivers/ata/pata_palmld.c > index 2448441571ed..400e65190904 100644 > --- a/drivers/ata/pata_palmld.c > +++ b/drivers/ata/pata_palmld.c > @@ -25,7 +25,6 @@ > #include > > #include > -#include > > #define DRV_NAME "pata_palmld" > > @@ -63,7 +62,7 @@ static int palmld_pata_probe(struct platform_device *pdev) > return -ENOMEM; > > /* remap drive's physical memory address */ > - mem = devm_ioremap(dev, PALMLD_IDE_PHYS, 0x1000); > + mem = devm_platform_ioremap_resource(pdev, 0); > if (!mem) > return -ENOMEM; > Acked-by: Damien Le Moal -- Damien Le Moal Western Digital Research