From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751342AbdAYHrl (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Jan 2017 02:47:41 -0500
Received: from webclient5.webclient5.de ([136.243.32.179]:53885 "EHLO
        webclient5.webclient5.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751297AbdAYHrk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Jan 2017 02:47:40 -0500
X-Greylist: delayed 383 seconds by postgrey-1.27 at vger.kernel.org; Wed, 25 Jan 2017 02:47:39 EST
Subject: Re: [alsa-devel] [PATCH 6/7] dmasound_core: Move two assignments for
 the variable "ret" in state_open()
To: SF Markus Elfring <elfring@users.sourceforge.net>,
        alsa-devel@alsa-project.org
References: <f2404d64-27c8-4afa-b893-fc72601c0136@users.sourceforge.net>
 <b4d0b274-23ac-4369-7119-a77e5108578b@users.sourceforge.net>
Cc: Jaroslav Kysela <perex@perex.cz>,
        Martin Koegler <martin.koegler@chello.at>,
        Takashi Iwai <tiwai@suse.com>,
        Takashi Sakamoto <o-takashi@sakamocchi.jp>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
From: Clemens Ladisch <clemens@ladisch.de>
Message-ID: <5701efac-3c37-8b6c-fbe7-89a54e988998@ladisch.de>
Date: Wed, 25 Jan 2017 08:40:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <b4d0b274-23ac-4369-7119-a77e5108578b@users.sourceforge.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

SF Markus Elfring wrote:
> A local variable was set to an error code in two cases before a concrete
> error situation was detected.

And why would that be a problem?

http://yarchive.net/comp/linux/error_jumps.html

> -	ret = -EBUSY;
> -	if (state.busy)
> +	if (state.busy) {
> +		ret = -EBUSY;
>  		goto out;
> +	}


Regards,
Clemens