From: Sebastian Andrzej Siewior <sebastian.siewior@linutronix.de>
To: Heiko Carstens <heiko.carstens@de.ibm.com>,
Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
rt@linutronix.de
Subject: Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call
Date: Tue, 5 Apr 2016 13:13:06 +0200 [thread overview]
Message-ID: <57039DC2.6090907@linutronix.de> (raw)
In-Reply-To: <20160405104912.GC3937@osiris>
On 04/05/2016 12:49 PM, Heiko Carstens wrote:
>> --- a/arch/s390/kernel/perf_cpum_sf.c
>> +++ b/arch/s390/kernel/perf_cpum_sf.c
>> @@ -1510,7 +1510,6 @@ static void cpumf_measurement_alert(stru
>> static int cpumf_pmu_notifier(struct notifier_block *self,
>> unsigned long action, void *hcpu)
>> {
>> - unsigned int cpu = (long) hcpu;
>> int flags;
>>
>> /* Ignore the notification if no events are scheduled on the PMU.
>> @@ -1523,11 +1522,15 @@ static int cpumf_pmu_notifier(struct not
>> case CPU_ONLINE:
>> case CPU_DOWN_FAILED:
>> flags = PMC_INIT;
>> - smp_call_function_single(cpu, setup_pmc_cpu, &flags, 1);
>> + local_irq_disable();
>> + setup_pmc_cpu(&flags);
>> + local_irq_enable();
>> break;
>
> ...but at least the CPU_DOWN_FAILED callback will not necessarily be called
> on the cpu that couldn't be brought offline.
I don't follow.
Sebastian
next prev parent reply other threads:[~2016-04-05 11:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 10:27 [PATCH] s390/cpum_sf: Remove superfluous SMP function call Anna-Maria Gleixner
2016-04-05 10:49 ` Heiko Carstens
2016-04-05 11:13 ` Sebastian Andrzej Siewior [this message]
2016-04-05 11:23 ` [PREEMPT-RT] " Heiko Carstens
2016-04-05 11:36 ` Heiko Carstens
2016-04-05 11:51 ` rcochran
2016-04-05 11:55 ` Heiko Carstens
2016-04-05 11:57 ` Sebastian Andrzej Siewior
2016-04-05 12:11 ` Heiko Carstens
2016-04-05 12:19 ` Sebastian Andrzej Siewior
2016-04-05 15:59 ` [PATCH] cpu/hotplug: fix rollback during error-out in __cpu_disable() Sebastian Andrzej Siewior
2016-04-06 19:51 ` Heiko Carstens
2016-04-07 15:14 ` Sebastian Andrzej Siewior
2016-04-08 6:19 ` Heiko Carstens
2016-04-08 12:40 ` [PATCH v2] " Sebastian Andrzej Siewior
2016-04-22 7:54 ` [tip:smp/urgent] cpu/hotplug: Fix " tip-bot for Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57039DC2.6090907@linutronix.de \
--to=sebastian.siewior@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rt@linutronix.de \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).