From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752391AbcDFR6t (ORCPT ); Wed, 6 Apr 2016 13:58:49 -0400 Received: from pygmy.kinoho.net ([134.0.27.24]:41199 "EHLO pygmy.kinoho.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbcDFR6r (ORCPT ); Wed, 6 Apr 2016 13:58:47 -0400 Subject: Re: [PATCH v2 10/14] USB: ch341: fix coding style To: Joe Perches , Johan Hovold References: <1459616843-23829-1-git-send-email-greg@chown.ath.cx> <1459616843-23829-11-git-send-email-greg@chown.ath.cx> <1459618198.15622.3.camel@perches.com> Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Grigori Goronzy Message-ID: <57054E4C.1090307@chown.ath.cx> Date: Wed, 6 Apr 2016 19:58:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1459618198.15622.3.camel@perches.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OsM1mPSdHtdeIhOAdDb7FQfDvCpGceRs0" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OsM1mPSdHtdeIhOAdDb7FQfDvCpGceRs0 Content-Type: multipart/mixed; boundary="ioUosobhRt5C7RfESM109OMe1cOMsigiw" From: Grigori Goronzy To: Joe Perches , Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <57054E4C.1090307@chown.ath.cx> Subject: Re: [PATCH v2 10/14] USB: ch341: fix coding style References: <1459616843-23829-1-git-send-email-greg@chown.ath.cx> <1459616843-23829-11-git-send-email-greg@chown.ath.cx> <1459618198.15622.3.camel@perches.com> In-Reply-To: <1459618198.15622.3.camel@perches.com> --ioUosobhRt5C7RfESM109OMe1cOMsigiw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/02/2016 07:29 PM, Joe Perches wrote: > Most of the whitespace only changes are undesired. >=20 Well, the style wasn't very consistent. I think consistency is important. So I took the liberty of deciding for one style and stuck to = it. > Multi-line statements here are using alignment to > open parenthesis which for some is the preferred > style. I didn't use alignment to open parentheses because that is often reducing the usable space per line too much. So you have to break lines a lot and code becomes less readable. Of course, I'm open to arguments if and why a particular style should be preferred. Maybe we should try to mostly avoid these bikeshed discussions though. :) Grigori --ioUosobhRt5C7RfESM109OMe1cOMsigiw-- --OsM1mPSdHtdeIhOAdDb7FQfDvCpGceRs0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXBU5SAAoJEOpmYE8Sf8H24yMP/2hRfjidiCehyjJhvqEg5Dlr RXEIwEgGmotv2V9pO1UuOcqlEC1aOc28UeeeLEx5rSljmWX6MAYv1EtgUDd5fqPL QchBWnYGt13PZ41UCk8TZ+vwMwDl4sukluwh7jWS/BfFc2miB3g/lgYN8YQdzpZr iSWHSF69j6nVd+NBwlwHIz9jr0Z22uopArZp0ACAMv7FCBrN77Snjz3UlzAM4Y1W 5bl/75ajGAzWfLj7zbHMkQAJis0DX9TwmiYwE/BnTdP+DVHudsIM58VeNOfiLpHs XCLg9AIrGkF8b5kI+f3ZDKhA818aTEiLaKD1S8zMYuGDMi6ed6pK9riY7mLwnWQi n3YlR6u6DBRyOaccAh5WtZLxzGly6ChB3/KD6KBoQF0kKWTs1K3xnCNNS+5FSRrP mQ32vj+ZY2f9Pe1qIaOnlUUr/8Crd08QAnkLFJwkPqX4l0XxKNSedrjX3FPyfX0Z inIbmoiL33PRDedtuFBNdqRA2umXxCiQ5U4IicBsRrLGwDGsSGjcmFWAShlAALtv aNp57UUnuDNjVjij72GHUJ2aOGyUdwsjcZqqHdP9nUy5cu/ncEtfGHLaKrWNRsAz yYqg9NrxjI1JKYxvd+h4eKlLVMcOMwyT5oMJzVzjryGRdojqaBELV7XQ1Oba3Di9 gx1W068aMhWawDd2+J8c =kkwm -----END PGP SIGNATURE----- --OsM1mPSdHtdeIhOAdDb7FQfDvCpGceRs0--