From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbcDGBLV (ORCPT ); Wed, 6 Apr 2016 21:11:21 -0400 Received: from pygmy.kinoho.net ([134.0.27.24]:41523 "EHLO pygmy.kinoho.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbcDGBLT (ORCPT ); Wed, 6 Apr 2016 21:11:19 -0400 Subject: Re: [PATCH v2 10/14] USB: ch341: fix coding style To: Johan Hovold References: <1459616843-23829-1-git-send-email-greg@chown.ath.cx> <1459616843-23829-11-git-send-email-greg@chown.ath.cx> <1459618198.15622.3.camel@perches.com> <57054E4C.1090307@chown.ath.cx> <20160406181048.GC29820@localhost> Cc: Joe Perches , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Grigori Goronzy Message-ID: <5705B3AA.8090201@chown.ath.cx> Date: Thu, 7 Apr 2016 03:11:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160406181048.GC29820@localhost> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kqRTiW4u1ceXd2o2s0SuE73qR1j8EIMeD" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kqRTiW4u1ceXd2o2s0SuE73qR1j8EIMeD Content-Type: multipart/mixed; boundary="1CxWCCd6V8vxtvXMKewduOVwPLOVkG2TD" From: Grigori Goronzy To: Johan Hovold Cc: Joe Perches , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <5705B3AA.8090201@chown.ath.cx> Subject: Re: [PATCH v2 10/14] USB: ch341: fix coding style References: <1459616843-23829-1-git-send-email-greg@chown.ath.cx> <1459616843-23829-11-git-send-email-greg@chown.ath.cx> <1459618198.15622.3.camel@perches.com> <57054E4C.1090307@chown.ath.cx> <20160406181048.GC29820@localhost> In-Reply-To: <20160406181048.GC29820@localhost> --1CxWCCd6V8vxtvXMKewduOVwPLOVkG2TD Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 04/06/2016 08:10 PM, Johan Hovold wrote: > As Joe already said, we generally don't want indentation-only changes t= o > existing code. Just try to stick to the style of the driver (even if > it's inconsistent at times). >=20 Hm, I don't get it. I understand that white-space-only changes are discouraged if they are freestanding and contributors don't follow up with any change to functionality (as outlined in development-process/4.Coding), but this is not the case here. IMHO, if the style of a module is inconsistent, it should be fixed at some point. The kind of policy you are presenting here will in the long run lead to messy code, and can't be found in any of the official documents (e.g. CodingStyle, SubmitChecklist, development-process/) either. It also encourages mixing white-space changes with patches that change functionality, which is a bad practice. I'll just drop the indentation changes. The rest is fine, I guess? Grigori --1CxWCCd6V8vxtvXMKewduOVwPLOVkG2TD-- --kqRTiW4u1ceXd2o2s0SuE73qR1j8EIMeD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXBbOwAAoJEOpmYE8Sf8H2oTQP/RAMseHl4cBAtjwn5Un6wHzP hau8nQ3PYPux9FAisCimSGCYoS28nmjrV8KRwdDRbhG/g7f4fyuxPo1VMT87VZnl dmjCX+zReQz6lSkMc1dLVTpUidPrRxDvEu+gK+sjMyymxk52f5J8Vgy2D7CbVcHv KEqLYk9paytE2XjH84o5zek1KyWnH8I8rRYQ5edk0aGsuNfxbYbWZqlNggEA8xoY TwB3u11xfVXmS1IbgrWNd2libQkGTXQkVakZLuGwnPw2AV0KeP+2+HLmQVOMsJFs l+A2Toci0/VLJGeyTpU5pnLBaRQJqZ2ZVr+BaqtRyJnRLBcNRv0QKQ5zsyc7VSZ3 CuRRb8xsRxeAAzbffXJlOrX7GgwR79fxLO4lpuiIZ5OqRqiQZOhAKG/FSCxCYRRm U3RjbTU3IiRGN6BaOu5+RfC5qNDEzm2pwTaUNVo0uzGVv/HuxKqiMGCrieL5+jG4 HuP5R/eXfc6ZT300E3j2Ja0fSPGi0KbrBVJ9dFNJgTFZ9MYmKdn7Yf7Eis61+35d FLGTxuO8rCq4d0ac2jm2Ag/HMGR19CsMggCVWH9+PEvxIj0hAgM/nBC7C1h+Nls1 l/BDpIfhJVoWiW5Bbnso/3ke02Cau35tU6QqpAFqzCpOGUxhPKTx1RzXvVJzBDOD xmh2tsewPVfxGrpmg403 =/azf -----END PGP SIGNATURE----- --kqRTiW4u1ceXd2o2s0SuE73qR1j8EIMeD--