From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbcDKEEY (ORCPT ); Mon, 11 Apr 2016 00:04:24 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:47945 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421AbcDKEES (ORCPT ); Mon, 11 Apr 2016 00:04:18 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee690-f79e56d0000012c4-5d-570b222f2430 Content-transfer-encoding: 8BIT Message-id: <570B222F.4030503@samsung.com> Date: Mon, 11 Apr 2016 13:03:59 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Anand Moon Cc: "myungjoo.ham@samsung.com" , Kyungmin Park , =?UTF-8?B?S3J6eXN6dG9mIEtvesWCb3dza2k=?= , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , "Rafael J. Wysocki" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Markus Reichl , Tobias Jakobi , "inki.dae@samsung.com" , Linux Kernel , Linux PM list , "linux-samsung-soc@vger.kernel.org" , linux-arm-kernel , devicetree Subject: Re: [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 References: <1460091646-28701-1-git-send-email-cw00.choi@samsung.com> <570B08F2.50302@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42JZI2JSqKuvxB1ucOK1gcX8I+dYLfrfLGS1 OPdqJaPFpPsTWCxevzC06H/8mtnibNMbdotNj6+xWlzeNYfN4nPvEUaLGef3MVms23iL3eL2 ZV6Ll0d+MFosvX6RyeJ24wo2iwnT17JYnDl9idWide8RdovDb9pZLdpWf2C1WLXrD6ODmMea eWsYPVqae9g8Lvf1MnnculPvsXPWXXaPlcu/sHlsWtXJ5rF5Sb3Hv2PsHluutrN49G1Zxejx eZNcAE8Ul01Kak5mWWqRvl0CV8bFb/sYC07xVJz9f429gfEbZxcjJ4eEgInEvc1/WCBsMYkL 99azdTFycQgJrGCU+Lf0IDNM0ZQNe5ghErMYJWY+fQLWwSsgKPFj8j0gm4ODWUBe4silbAhT XWLKlFyI8geMEnNefWAEifMKaEl8eBwH0skioCpx/MABsClsQOH9L26wgZSICkRIdJ+oBAmL CKhJXHm6ghVkDLPAKXaJ6S++soEkhAWyJFYeusgKMX8nk8THhe8YQRKcAsEScx6eYQFJSAh8 4JCY+GAaM8Q2AYlvkw+B3SkhICux6QDUX5ISB1fcYJnAKDYLyTezEL6ZhfDNAkbmVYyiqQXJ BcVJ6UUmesWJucWleel6yfm5mxiBKeT0v2cTdjDeO2B9iFGAg1GJh9fhGle4EGtiWXFl7iFG U6AbJjJLiSbnAxNVXkm8obGZkYWpiamxkbmlmZI472upn8FCAumJJanZqakFqUXxRaU5qcWH GJk4OKUaGO1bl4c4Hkh7Gijvk2RtxXvEvPC5h8lGj4tRlQLC1os3sF8tKw3hX7a49cqlorLE sO1WbPsE3jh8kdi03kD/o/InMzmHSH1hFz4nccaDax6KhbqvkZ4f4tIauUH2sQqbh/u6ywEc ySqH/4bJTCtazBlcvCny8IqrEzSm9rAt9ecTztM6n5ytxFKckWioxVxUnAgA/GP/5RwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGKsWRmVeSWpSXmKPExsVy+t9jQV19Je5wg65pmhbzj5xjteh/s5DV 4tyrlYwWk+5PYLF4/cLQov/xa2aLs01v2C02Pb7GanF51xw2i8+9RxgtZpzfx2SxbuMtdovb l3ktXh75wWix9PpFJovbjSvYLCZMX8ticeb0JVaL1r1H2C0Ov2lntWhb/YHVYtWuP4wOYh5r 5q1h9Ghp7mHzuNzXy+Rx6069x85Zd9k9Vi7/wuaxaVUnm8fmJfUe/46xe2y52s7i0bdlFaPH 501yATxRDYw2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6Z OUAPKymUJeaUAoUCEouLlfTtME0IDXHTtYBpjND1DQmC6zEyQAMJaxgzLn7bx1hwiqfi7P9r 7A2M3zi7GDk5JARMJKZs2MMMYYtJXLi3nq2LkYtDSGAWo8TMp09YQBK8AoISPybfA7I5OJgF 5CWOXMqGMNUlpkzJhSh/wCgx59UHRpA4r4CWxIfHcSCdLAKqEscPHACbwgYU3v/iBhtIiahA hET3iUqQsIiAmsSVpytYQcYwC5xil5j+4isbSEJYIEti5aGLrBDzdzJJfFz4jhEkwSkQLDHn 4RmWCYxARyJcNwvhulkI1y1gZF7FKJFakFxQnJSea5SXWq5XnJhbXJqXrpecn7uJEZymnknv YDy8y/0QowAHoxIP74vLXOFCrIllxZW5hxglOJiVRHjzFbjDhXhTEiurUovy44tKc1KLDzGa Av03kVlKNDkfmELzSuINjU3MjCyNzA0tjIzNlcR5H/9fFyYkkJ5YkpqdmlqQWgTTx8TBKdXA GNUtsDiq9+LLGJPoyJ95J523nfkceZLXr33ajredCj5HNC4duKIiYusa0e5ZnpMexniiLru/ sk7pp9/uSHH1s0tK7ecoHFu62CR0Jc9OyXfrf07KXxvxu7Z/wUXuH9r60lukr2mrRRa3vkhb vfLBoi9BX74eTI7cxKH85bD/n/L81XZKJvV9SizFGYmGWsxFxYkA3dxxG2kDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anand, On 2016년 04월 11일 13:01, Anand Moon wrote: > Hi Chanwoo, > > On 11 April 2016 at 07:46, Chanwoo Choi wrote: >> Hi Anand, >> >> On 2016년 04월 09일 03:24, Chanwoo Choi wrote: >>> Hi Anand, >>> >>> On Sat, Apr 9, 2016 at 3:11 AM, Anand Moon wrote: >>>> Hi Chanwoo, >>>> >> >> [snip] >> >>>>> >>>> >>>> I am observing following deadlock. Both on Odroid U3 and Odroid XU4. >>> >>> Thanks for your test. I'll test it again and fix it. >> >> This possible recursive locking is fixed with following diff: >> >> Thanks for your report. I'll fix it on next patchset[1] (v9). >> [1] https://lkml.org/lkml/2016/4/8/14 >> >> >> diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c >> index 28a9ae32d330..a4b0b02ee797 100644 >> --- a/drivers/devfreq/governor_passive.c >> +++ b/drivers/devfreq/governor_passive.c >> @@ -102,7 +102,7 @@ static int update_devfreq_passive(struct devfreq *devfreq, unsigned long freq) >> if (!devfreq->governor) >> return -EINVAL; >> >> - mutex_lock(&devfreq->lock); >> + mutex_lock_nested(&devfreq->lock, SINGLE_DEPTH_NESTING); >> >> ret = devfreq->governor->get_target_freq(devfreq, &freq); >> if (ret < 0) >> >> Best Regards, >> Chanwoo Choi >> > > Thanks you for these patches on devfreq. > These changes fix the warning. > > Tested-by: Anand Moon > > Tested on Odroid XU4 and Odroid U3. Thanks for your test and report. Best Regards, Chanwoo Choi