From: Chanwoo Choi <cw00.choi@samsung.com>
To: Roger Quadros <rogerq@ti.com>, myungjoo.ham@samsung.com
Cc: linux-kernel@vger.kernel.org,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v3] extcon: usb-gpio: Don't miss event during suspend/resume
Date: Tue, 12 Apr 2016 07:43:06 +0900 [thread overview]
Message-ID: <570C287A.8040002@samsung.com> (raw)
In-Reply-To: <570BAEFD.2050406@ti.com>
Hi Roger,
On 2016년 04월 11일 23:04, Roger Quadros wrote:
> Pin state might have changed during suspend/resume while
> our interrupts were disabled and if device doesn't support wakeup.
>
> Scan for change during resume for such case.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> v3:
> - use queue_delayed_work() instead of directly calling usb_extcon_detect_cable()
>
> v2:
> - only check for state change during resume if device wakeup is
>
> drivers/extcon/extcon-usb-gpio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index bc61d11..bad2159 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -185,6 +185,9 @@ static int usb_extcon_resume(struct device *dev)
> int ret = 0;
>
> enable_irq(info->id_irq);
> + if (!device_may_wakeup(dev))
> + queue_delayed_work(system_power_efficient_wq,
> + &info->wq_detcable, 0);
>
> return ret;
> }
>
Applied it.
Thanks,
Chanwoo Choi
prev parent reply other threads:[~2016-04-11 22:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 14:01 [PATCH] extcon: usb-gpio: Don't miss event during suspend/resume Roger Quadros
2016-04-07 23:39 ` Chanwoo Choi
2016-04-08 7:34 ` [PATCH v2] " Roger Quadros
2016-04-11 0:31 ` Chanwoo Choi
2016-04-11 8:37 ` Grygorii Strashko
2016-04-11 11:12 ` Chanwoo Choi
2016-04-11 11:39 ` Roger Quadros
2016-04-11 13:17 ` Chanwoo Choi
2016-04-11 14:02 ` Roger Quadros
2016-04-11 14:04 ` [PATCH v3] " Roger Quadros
2016-04-11 22:43 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570C287A.8040002@samsung.com \
--to=cw00.choi@samsung.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).