From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932278AbcDLJVy (ORCPT ); Tue, 12 Apr 2016 05:21:54 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:12384 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755962AbcDLJVw (ORCPT ); Tue, 12 Apr 2016 05:21:52 -0400 Subject: Re: [PATCH RFT 2/2] macb: kill PHY reset code To: Andrew Lunn , Sergei Shtylyov References: <81129033.NXiOLTg1so@wasted.cogentembedded.com> <2811962.eGX2i5RJbZ@wasted.cogentembedded.com> <20160411022802.GB4307@lunn.ch> CC: , From: Nicolas Ferre X-Enigmail-Draft-Status: N1110 Organization: atmel Message-ID: <570CBE42.50309@atmel.com> Date: Tue, 12 Apr 2016 11:22:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160411022802.GB4307@lunn.ch> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 11/04/2016 04:28, Andrew Lunn a écrit : > On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: >> With the 'phylib' now being aware of the "reset-gpios" PHY node property, >> there should be no need to frob the PHY reset in this driver anymore... >> >> Signed-off-by: Sergei Shtylyov >> >> --- >> drivers/net/ethernet/cadence/macb.c | 17 ----------------- >> drivers/net/ethernet/cadence/macb.h | 1 - >> 2 files changed, 18 deletions(-) >> >> Index: net-next/drivers/net/ethernet/cadence/macb.c >> =================================================================== >> --- net-next.orig/drivers/net/ethernet/cadence/macb.c >> +++ net-next/drivers/net/ethernet/cadence/macb.c >> @@ -2884,7 +2884,6 @@ static int macb_probe(struct platform_de >> = macb_clk_init; >> int (*init)(struct platform_device *) = macb_init; >> struct device_node *np = pdev->dev.of_node; >> - struct device_node *phy_node; >> const struct macb_config *macb_config = NULL; >> struct clk *pclk, *hclk = NULL, *tx_clk = NULL; >> unsigned int queue_mask, num_queues; >> @@ -2977,18 +2976,6 @@ static int macb_probe(struct platform_de >> else >> macb_get_hwaddr(bp); >> >> - /* Power up the PHY if there is a GPIO reset */ >> - phy_node = of_get_next_available_child(np, NULL); >> - if (phy_node) { >> - int gpio = of_get_named_gpio(phy_node, "reset-gpios", 0); >> - >> - if (gpio_is_valid(gpio)) { >> - bp->reset_gpio = gpio_to_desc(gpio); >> - gpiod_direction_output(bp->reset_gpio, 1); > > Hi Sergei > > The code you are deleting would of ignored the flags in the gpio I don't parse this. The code deleted does take the flag into account. And the DT property associated to it seems correct to me (I mean, with proper flag specification). > property, i.e. active low. The new code in the previous patch does > however take the flags into account. Did you check if there are any > device trees which have flags, which were never used, but are now > going to be used and thus break... Flag was used and you are saying that it's taken into account in new code... So, what's the issue? I see a difference in the way the "value" of gpiod_* functions is used. There may be a misunderstanding here... Bye, -- Nicolas Ferre