From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933087AbcDLK7L (ORCPT ); Tue, 12 Apr 2016 06:59:11 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:63218 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932338AbcDLK7I (ORCPT ); Tue, 12 Apr 2016 06:59:08 -0400 X-AuditID: cbfec7f5-f792a6d000001302-85-570cd4f9fc0c Subject: Re: [PATCH 7/7] ARM: dts: Add support of Bus frequency using VDD_INT for exynos5422-odroidxu3 To: Chanwoo Choi , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <1460091646-28701-1-git-send-email-cw00.choi@samsung.com> <1460091646-28701-8-git-send-email-cw00.choi@samsung.com> Cc: rjw@rjwysocki.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, linux.amoon@gmail.com, m.reichl@fivetechno.de, tjakobi@math.uni-bielefeld.de, inki.dae@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <570CD4F7.6000700@samsung.com> Date: Tue, 12 Apr 2016 12:59:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1460091646-28701-8-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t/xK7o/r/CEG2x5zWFx/ctzVov5R86x WvS/Wchqce7VSkaLSfcnsFi8fmFo0f/4NbPF2aY37BabHl9jtbi8aw6bxefeI4wWM87vY7JY t/EWu8Xty7wWL4/8YLRYev0ik8XtxhVsFhOmr2WxOHP6EqtF694j7BaH37SzWrSt/sBqsWrX H0YHcY8189YwerQ097B5XO7rZfK4dafeY+esu+weK5d/YfPYtKqTzWPzknqPf8fYPbZcbWfx 6NuyitHj8ya5AJ4oLpuU1JzMstQifbsEroy230tZCtaKVfxcvZ+tgXGeYBcjJ4eEgInE7E1/ WSFsMYkL99azdTFycQgJLGWUeHlkB5TzjFFics9bdpAqYYEMicN/FzKCJEQEFjFKbF7YzgxR 1cgo8Xn7JyYQh1lgLbPEq/ZGsMFsAsYSm5cvYQOxeQW0JN5NmwYWZxFQlXj9dzUTiC0qECHx ZO5JRogaQYkfk++xdDFycHAKuEmsfSYPYjIL6Encv6gFUsEsIC+xec1b5gmMArOQNMxCqJqF pGoBI/MqRtHU0uSC4qT0XCO94sTc4tK8dL3k/NxNjJAY/rqDcekxq0OMAhyMSjy8lm484UKs iWXFlbmHGCU4mJVEeNsvA4V4UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUg tQgmy8TBKdXAWBOZvPR72oPmw67nhL8ESNdN/sS5eg7fDIm3at/3BeZuKGLx/f5/KlNG/pZC j5zLC3LfVjx6yRxXx9Z+V8g91ObZ4sz0udvOV5w6qDzPvW22DnPPv/5Xj7e/sFMqUT6WtjXi hHNK8ulD54L/G1zzETV6FzVhCYe17Cf5Ka/nK5mvXm11z3bDayWW4oxEQy3mouJEAN5dQVfd AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2016 07:00 AM, Chanwoo Choi wrote: > This patch adds the bus device tree nodes for INT (Internal) block > to enable the AMBA bus frequency scaling and add the NoC (Network on Chip) > Probe Device Tree node to measure the bandwidht for AMBA AXI bus. > > The WCORE bus bus is parent device in INT block using VDD_INT. > > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 99 ++++++++++++++++++++++ > 1 file changed, 99 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 1bd507bfa750..2a74abe6fc5d 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -361,6 +361,22 @@ > cap-sd-highspeed; > }; > > +&nocp_mem0_0 { > + status = "okay"; > +}; > + > +&nocp_mem0_1 { > + status = "okay"; > +}; > + > +&nocp_mem0_2 { > + status = "okay"; > +}; > + > +&nocp_mem0_3 { > + status = "okay"; > +}; > + > &pinctrl_0 { > hdmi_hpd_irq: hdmi-hpd-irq { > samsung,pins = "gpx3-7"; > @@ -432,3 +448,86 @@ > vdd33-supply = <&ldo9_reg>; > vdd10-supply = <&ldo11_reg>; > }; > + > +&bus_wcore { > + devfreq-events = <&nocp_mem0_0>, <&nocp_mem0_1>, > + <&nocp_mem0_2>, <&nocp_mem0_3>; > + vdd-supply = <&buck3_reg>; > + exynos,saturation-ratio = <100>; > + status = "okay"; > +}; > + > +&bus_noc { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_fsys_apb { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_fsys { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_fsys2 { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_mfc { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_gen { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_peri { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_g2d { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_g2d_acp { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_jpeg { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_jpeg_apb { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_disp1_fimd { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_disp1 { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_gscl_scaler { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; > + > +&bus_mscl { > + devfreq = <&bus_wcore>; > + status = "okay"; > +}; Could you put the bus nodes in alphabetical order, both between them and in relation to others (so before &clock_audss)? Let's keep the file ordered. Best regards, Krzysztof