From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933291AbcDLLZU (ORCPT ); Tue, 12 Apr 2016 07:25:20 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:65216 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933178AbcDLLZR (ORCPT ); Tue, 12 Apr 2016 07:25:17 -0400 X-AuditID: cbfec7f5-f792a6d000001302-b7-570cdb1801a2 Subject: Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK To: Chanwoo Choi , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <1460091646-28701-1-git-send-email-cw00.choi@samsung.com> <1460091646-28701-6-git-send-email-cw00.choi@samsung.com> Cc: rjw@rjwysocki.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, linux.amoon@gmail.com, m.reichl@fivetechno.de, tjakobi@math.uni-bielefeld.de, inki.dae@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <570CDB16.2050001@samsung.com> Date: Tue, 12 Apr 2016 13:25:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1460091646-28701-6-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t/xa7oSt3nCDf4+1rO4/uU5q8X8I+dY LfrfLGS1OPdqJaPFpPsTWCxevzC06H/8mtnibNMbdotNj6+xWlzeNYfN4nPvEUaLGef3MVms 23iL3eL2ZV6Ll0d+MFosvX6RyeJ24wo2iwnT17JYnDl9idWide8RdovDb9pZLdpWf2C1WLXr D6ODuMeaeWsYPVqae9g8Lvf1MnnculPvsXPWXXaPlcu/sHlsWtXJ5rF5Sb3Hv2PsHluutrN4 9G1ZxejxeZNcAE8Ul01Kak5mWWqRvl0CV8bmJfvZC5axVlxf2szWwLiCpYuRk0NCwERi6Zdu ZghbTOLCvfVsXYxcHEICSxkltp2bCuU8Y5TYvusfI0iVsICPxN/1f5hBEiICixglNi9sZ4ao amSU6D63A6yFWWAts8Sr9kZWkBY2AWOJzcuXACU4OHgFtCR+vLUEMVkEVCVaX+WCVIgKREg8 mXsSbAGvgKDEj8n3wM7jFHCTmLvnOSNIObOAnsT9i1ogYWYBeYnNa94yT2AUmIWkYxZC1Swk VQsYmVcxiqaWJhcUJ6XnGukVJ+YWl+al6yXn525ihETw1x2MS49ZHWIU4GBU4uG1dOMJF2JN LCuuzD3EKMHBrCTCq3YDKMSbklhZlVqUH19UmpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWp RTBZJg5OqQZG4xZXwc1njmTkdwWLH21U9/3MqCycfN1j9v2Ds/v1zHZ6J97cdmrZtQWeC3rF PzFpqNj1T5HRYtzxJH7P3PLSn5OepXX/Wi+0Y/kNZ8FtNvO+PSwS3jbhz9LVc9PFjhxZtFne rv3xvhaNx7UtkbM5jSVXzDI+px9ceWSDQdL6/EaGUE2tb48klFiKMxINtZiLihMBpw0qh9wC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2016 07:00 AM, Chanwoo Choi wrote: > This patch adds the clock id for ACLK clock which is source clock of AMBA AXI > Bus. This clock should be handled in Bus frequency scaling driver. > > Signed-off-by: Chanwoo Choi > --- > drivers/clk/samsung/clk-exynos5420.c | 85 +++++++++++++++++++++++------------- > 1 file changed, 55 insertions(+), 30 deletions(-) The IDs itself look good but you are not adding only clock ID. You are changing all of them from NULL-flags to CLK_SET_RATE_PARENT. This should be explained in the commit message why you need it. Probably it should be also in separate commit. Best regards, Krzysztof